• P
    exec: make address spaces 64-bit wide · 57271d63
    Paolo Bonzini 提交于
    As an alternative to commit 818f86b8 (exec: limit system memory
    size, 2013-11-04) let's just make all address spaces 64-bit wide.
    This eliminates problems with phys_page_find ignoring bits above
    TARGET_PHYS_ADDR_SPACE_BITS and address_space_translate_internal
    consequently messing up the computations.
    
    In Luiz's reported crash, at startup gdb attempts to read from address
    0xffffffffffffffe6 to 0xffffffffffffffff inclusive.  The region it gets
    is the newly introduced master abort region, which is as big as the PCI
    address space (see pci_bus_init).  Due to a typo that's only 2^63-1,
    not 2^64.  But we get it anyway because phys_page_find ignores the upper
    bits of the physical address.  In address_space_translate_internal then
    
        diff = int128_sub(section->mr->size, int128_make64(addr));
        *plen = int128_get64(int128_min(diff, int128_make64(*plen)));
    
    diff becomes negative, and int128_get64 booms.
    
    The size of the PCI address space region should be fixed anyway.
    Reported-by: NLuiz Capitulino <lcapitulino@redhat.com>
    Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>
    57271d63
exec.c 74.4 KB