• E
    block: Make supported_write_flags a per-bds property · 4df863f3
    Eric Blake 提交于
    Pre-patch, .supported_write_flags lives at the driver level, which
    means we are blindly declaring that all block devices using a
    given driver will either equally support FUA, or that we need a
    fallback at the block layer.  But there are drivers where FUA
    support is a per-block decision: the NBD block driver is dependent
    on the remote server advertising NBD_FLAG_SEND_FUA (and has
    fallback code to duplicate the flush that the block layer would do
    if NBD had not set .supported_write_flags); and the iscsi block
    driver is dependent on the mode sense bits advertised by the
    underlying device (and is currently silently ignoring FUA requests
    if the underlying device does not support FUA).
    
    The fix is to make supported flags as a per-BDS option, set during
    .bdrv_open().  This patch moves the variable and fixes NBD and iscsi
    to set it only conditionally; later patches will then further
    simplify the NBD driver to quit duplicating work done at the block
    layer, as well as tackle the fact that SCSI does not support FUA
    semantics on WRITESAME(10/16) but only on WRITE(10/16).
    Signed-off-by: NEric Blake <eblake@redhat.com>
    Reviewed-by: NFam Zheng <famz@redhat.com>
    Acked-by: NStefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: NKevin Wolf <kwolf@redhat.com>
    4df863f3
block_int.h 28.3 KB