• J
    target-mips: Fix exceptions while UX=0 · 7871abb9
    James Hogan 提交于
    Commit 01f72885 ("target-mips: Status.UX/SX/KX enable 32-bit address
    wrapping") added a new hflag MIPS_HFLAG_AWRAP, which indicates that
    64-bit addressing is disallowed in the current mode, so hflag users
    don't need to worry about the complexities of working that out, for
    example checking both MIPS_HFLAG_KSU and MIPS_HFLAG_UX.
    
    However when exceptions are taken outside of exception level,
    mips_cpu_do_interrupt() manipulates the env->hflags directly rather than
    using compute_hflags() to update them, and this code wasn't updated
    accordingly. As a result, when UX is cleared, MIPS_HFLAG_AWRAP is set,
    but it doesn't get cleared on entry back into kernel mode due to an
    exception. Kernel mode then cannot access the 64-bit segments resulting
    in a nested exception loop. The same applies to errors and debug
    exceptions.
    
    Fix by updating mips_cpu_do_interrupt() to clear the MIPS_HFLAG_WRAP
    flag when necessary, according to compute_hflags().
    
    Fixes: 01f72885 ("target-mips: Status.UX/SX/KX enable 32-bit...")
    Signed-off-by: NJames Hogan <james.hogan@imgtec.com>
    Cc: Leon Alrae <leon.alrae@imgtec.com>
    Cc: Aurelien Jarno <aurelien@aurel32.net>
    Reviewed-by: NLeon Alrae <leon.alrae@imgtec.com>
    Signed-off-by: NLeon Alrae <leon.alrae@imgtec.com>
    7871abb9
helper.c 26.6 KB