• J
    blockjob: do not allow coroutine double entry or entry-after-completion · 4afeffc8
    Jeff Cody 提交于
    When block_job_sleep_ns() is called, the co-routine is scheduled for
    future execution.  If we allow the job to be re-entered prior to the
    scheduled time, we present a race condition in which a coroutine can be
    entered recursively, or even entered after the coroutine is deleted.
    
    The job->busy flag is used by blockjobs when a coroutine is busy
    executing. The function 'block_job_enter()' obeys the busy flag,
    and will not enter a coroutine if set.  If we sleep a job, we need to
    leave the busy flag set, so that subsequent calls to block_job_enter()
    are prevented.
    
    This changes the prior behavior of block_job_cancel() being able to
    immediately wake up and cancel a job; in practice, this should not be an
    issue, as the coroutine sleep times are generally very small, and the
    cancel will occur the next time the coroutine wakes up.
    
    This fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1508708Signed-off-by: NJeff Cody <jcody@redhat.com>
    Reviewed-by: NStefan Hajnoczi <stefanha@redhat.com>
    4afeffc8
blockjob.c 24.4 KB