• M
    vl: Fix bogus error message for implied mon ID clashing · 46ede58b
    Markus Armbruster 提交于
    monitor_parse() desugars --monitor, --qmp and -qmp-pretty to --mon.
    The ID it picks can clash with a user-specified ID.  When it happens,
    the error message is misleading.
    
    Reproducer:
    
        $ qemu --mon id=compat_monitor0 --monitor stdio
    
    Message before the patch:
    
        duplicate chardev: compat_monitor0
    
    There's no "duplicate chardev" here.  The problem is a duplicate
    monitor ID.  Moreover, the message provides no clue which option
    caused the problem.  The patch changes the message to:
    
        qemu: --monitor stdio: Duplicate ID 'compat_monitor0' for mon
    
    monitor_parse() is also used for creating a default monitor, but
    that's not done when the user specifies a monitor, so an ID clash is
    impossible then.
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    Signed-off-by: NMichael Tokarev <mjt@tls.msk.ru>
    46ede58b
vl.c 123.9 KB