• L
    linux-user: ioctl() command type is int · 45c874eb
    Laurent Vivier 提交于
    When executing a 64bit target chroot on 64bit host,
    the ioctl() command can mismatch.
    
    It seems the previous commit doesn't solve the problem in
    my case:
    
        9c6bf9c7 linux-user: Fix ioctl cmd type mismatch on 64-bit targets
    
    For example, a ppc64 chroot on an x86_64 host:
    
    bash-4.3# ls
    Unsupported ioctl: cmd=0x80087467
    Unsupported ioctl: cmd=0x802c7415
    
    The origin of the problem is in syscall.c:do_ioctl().
    
        static abi_long do_ioctl(int fd, abi_long cmd, abi_long arg)
    
    In this case (ppc64) abi_long is long (on the x86_64), and
    
        cmd = 0x0000000080087467
    
    then
        if (ie->target_cmd == cmd)
    
    target_cmd is int, so target_cmd = 0x80087467
    and to compare an int with a long, the sign is extended to 64bit,
    so the comparison is:
    
        if (0xffffffff80087467 == 0x0000000080087467)
    
    which doesn't match whereas it should.
    
    This patch uses int in the case of the target command type
    instead of abi_long.
    Signed-off-by: NLaurent Vivier <laurent@vivier.eu>
    Signed-off-by: NRiku Voipio <riku.voipio@linaro.org>
    45c874eb
syscall.c 306.5 KB