• A
    block: Clean up reopen_backing_file() in block/replication.c · 3c4e9647
    Alberto Garcia 提交于
    This function is used to put the hidden and secondary disks in
    read-write mode before launching the backup job, and back in read-only
    mode afterwards.
    
    This patch does the following changes:
    
      - Use an options QDict with the "read-only" option instead of
        passing the changes as flags only.
    
      - Simplify the code (it was unnecessarily complicated and verbose).
    
      - Fix a bug due to which the secondary disk was not being put back
        in read-only mode when writable=false (because in this case
        orig_secondary_flags always had the BDRV_O_RDWR flag set).
    
      - Stop clearing the BDRV_O_INACTIVE flag.
    
    The flags parameter to bdrv_reopen_queue() becomes redundant and we'll
    be able to get rid of it in a subsequent patch.
    Signed-off-by: NAlberto Garcia <berto@igalia.com>
    Reviewed-by: NMax Reitz <mreitz@redhat.com>
    Signed-off-by: NKevin Wolf <kwolf@redhat.com>
    3c4e9647
replication.c 20.9 KB