• G
    spice: fix coverity reported defect in display code · 51a09099
    Gerd Hoffmann 提交于
    Report:
    
    1. Condition surface, taking false branch
    406    if (surface && ssd->surface &&
    407        surface_width(surface) == pixman_image_get_width(ssd->surface) &&
    408        surface_height(surface) == pixman_image_get_height(ssd->surface)) {
    409        /* no-resize fast path: just swap backing store */
    ...
    
    10. alias_transfer: Assigning: ssd->ds = surface.
    440    ssd->ds = surface;
    
    11. var_deref_op: Dereferencing null pointer ssd->ds.
    CID 1264334 (#1 of 1): Dereference after null check (FORWARD_NULL)
    441    ssd->surface = pixman_image_ref(ssd->ds->image);
    
    Fix:
    
    Move code block dereferencing ssd->ds into the already existing
    if (ssd->ds) { ... } block.
    
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
    51a09099
spice-display.c 24.4 KB