• M
    change iov_* function prototypes to be more appropriate · dcf6f5e1
    Michael Tokarev 提交于
    Reorder arguments to be more natural, readable and
    consistent with other iov_* functions, and change
    argument names, from:
     iov_from_buf(iov, iov_cnt, buf, iov_off, size)
    to
     iov_from_buf(iov, iov_cnt, offset, buf, bytes)
    
    The result becomes natural English:
    
     copy data to this `iov' vector with `iov_cnt'
     elements starting at byte offset `offset'
     from memory buffer `buf', processing `bytes'
     bytes max.
    
    (Try to read the original prototype this way).
    
    Also change iov_clear() to more general iov_memset()
    (it uses memset() internally anyway).
    
    While at it, add comments to the header file
    describing what the routines actually does.
    
    The patch only renames argumens in the header, but
    keeps old names in the implementation.  The next
    patch will touch actual code to match.
    
    Now, it might look wrong to pay so much attention
    to so small things.  But we've so many badly designed
    interfaces already so the whole thing becomes rather
    confusing or error prone.  One example of this is
    previous commit and small discussion which emerged
    from it, with an outcome that the utility functions
    like these aren't well-understdandable, leading to
    strange usage cases.  That's why I paid quite some
    attention to this set of functions and a few
    others in subsequent patches.
    Signed-off-by: NMichael Tokarev <mjt@tls.msk.ru>
    dcf6f5e1
virtio-net.c 31.3 KB