• M
    fdc: Drop broken code for user-defined floppy geometry · 1f69c2b0
    Markus Armbruster 提交于
    bdrv_get_floppy_geometry_hint() fails to store through its parameter
    drive when bs has a geometry hint.  Makes fd_revalidate() assign
    random crap to drv->drive.
    
    Has been broken that way for ages.  Harmless, because:
    
    * The only way to set a geometry hint is -drive if=none,cyls=...
      Since commit c219331e, probably unintentional.
    
    * The only use of drv->drive is as argument to another
      bdrv_get_floppy_geometry_hint().  Which doesn't use it, since the
      geometry hint is still there.
    
    Drop the broken code, ignore -drive parameter cyls, heads and secs for
    floppies even with if=none, just like before commit c219331e.  Matches
    -help, which explains cyls, heads, secs as "hard disk physical
    geometry".
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    Signed-off-by: NKevin Wolf <kwolf@redhat.com>
    1f69c2b0
fdc.c 65.1 KB