• E
    qapi: Move duplicate collision checks to schema check() · 01cfbaa4
    Eric Blake 提交于
    With the recent commit 'qapi: Detect collisions in C member
    names', we have two different locations for detecting clashes -
    one at parse time, and another at QAPISchema*.check() time.
    Remove all of the ad hoc parser checks, and delete associated
    code (for example, the global check_member_clash() method is
    no longer needed).
    
    Testing this showed that the test union-bad-branch wasn't adding
    much: union-clash-branches also exposes the error message when
    branches collide, and we've recently fixed things to avoid an
    implicit collision with max.  Likewise, the error for
    enum-clash-member changes to report our new detection of
    upper case in a value name, unless we modify the test to use
    all lower case.
    
    The wording of several error messages has changed, but the
    change is generally an improvement rather than a regression.
    
    No change to generated code.
    Signed-off-by: NEric Blake <eblake@redhat.com>
    Message-Id: <1449033659-25497-15-git-send-email-eblake@redhat.com>
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    01cfbaa4
union-clash-branches.json 218 字节