1. 14 5月, 2010 1 次提交
    • D
      Add support for NIC hotplug using netdev_add in QEMU · ff45b4c2
      Daniel P. Berrange 提交于
      QEMU is gaining a new monitor command netdev_add for hotplugging
      NICs using the netdev backend code. We already support this on
      the command this, though it is disabled. This adds support for
      hotplug too, also to remain disabled until 0.13 QEMU is released
      
      * src/qemu/qemu_driver.c: Support netdev hotplug for NICs
      * src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h,
        src/qemu/qemu_monitor_json.c, src/qemu/qemu_monitor_json.h,
        src/qemu/qemu_monitor_text.c, src/qemu/qemu_monitor_text.h: Add
        support for netdev_add and netdev_remove commands
      ff45b4c2
  2. 13 5月, 2010 1 次提交
  3. 12 5月, 2010 8 次提交
    • J
      Fix monitor ref counting when adding event handle · d84bb6d6
      Jiri Denemark 提交于
      When closing a monitor using qemuMonitorClose(), we are aware of
      the possibility the monitor is still being used somewhere:
      
          /* NB: ordinarily one might immediately set mon->watch to -1
           * and mon->fd to -1, but there may be a callback active
           * that is still relying on these fields being valid. So
           * we merely close them, but not clear their values and
           * use this explicit 'closed' flag to track this state */
      
      but since we call virEventAddHandle() on that monitor without increasing
      its ref counter, the monitor is still freed which makes possible users
      of it quite unhappy. The unhappiness can lead to a hang if qemuMonitorIO
      tries to lock mutex which no longer exists.
      d84bb6d6
    • J
      Remove watches before calling REMOTE_PROC_CLOSE · 6ef9d9da
      Jiri Denemark 提交于
      First calling REMOTE_PROC_CLOSE and then removing watches might lead to
      a hang as HANGUP event can be triggered before the watches are actually
      removed but after virConnectPtr is already freed. As a result of that
      remoteDomainEventFired() would try to lock uninitialized mutex, which
      would hang for ever.
      6ef9d9da
    • J
      tests: use GPLv2+, not GPLv3 · c2c4abb4
      Jim Meyering 提交于
      * tests/cpuset: Change from GPLv3 to GPLv2+
      * tests/read-bufsiz: Likewise.
      * tests/read-non-seekable: Likewise.
      * tests/start: Likewise.
      * tests/undefine: Likewise.
      * tests/vcpupin: Likewise.
      * tests/virsh-all: Likewise.
      * tests/virsh-schedinfo: Likewise.
      * tests/virsh-synopsis: Likewise.
      c2c4abb4
    • E
      libvirt_proxy: link with -lpthread if needed · ff1d6f85
      Eric Blake 提交于
      Continuation of earlier patches to fix LIB_PTHREAD, only
      triggered by ./configure --with-xen-proxy (a la autobuild.sh).
      
      * proxy/Makefile.am (libvirt_proxy_LDADD): Add LIB_PTHREAD.
      ff1d6f85
    • C
      node_device: udev: Fix PCI product/vendor swappage · 74c7a346
      Cole Robinson 提交于
      Product and vendor values were swapped in the XML, which made virt-manager
      PCI device listing kinda useless.
      74c7a346
    • E
      build: update gnulib · e8a1a730
      Eric Blake 提交于
      * .gnulib: Update to latest.
      * bootstrap.conf (gnulib_modules): Import netdb.
      * src/esx/esx_util.c (AI_ADDRCONFIG): Rely on gnulib.
      * src/remote/remote_driver.c (AI_ADDRCONFIG): Likewise.
      * tools/virsh.c (WEXITSTATUS, O_SYNC): Likewise.
      e8a1a730
    • E
      build: allow older gettext · 03ae900f
      Eric Blake 提交于
      * bootstrap.conf (gnulib_modules): Use gettext-h, not gettext,
      since the latter drags in a depedency on gettext 0.18.
      Suggested by Bruno Haible.
      03ae900f
    • J
      tests: correct PATH in new test, for when running manually · e915962a
      Jim Meyering 提交于
      * tests/virsh-schedinfo: This test sets PATH internally, just in
      case you're running it manually.  Normally, the PATH setting from
      tests/Makefile.am's TESTS_ENVIRONMENT is sufficient.  Prepend the
      correct directory, and take advantage of the PATH setting in one
      more case.
      e915962a
  4. 11 5月, 2010 9 次提交
    • D
      Add env variable for debugging gnutls usage · 36a03bd2
      Daniel P. Berrange 提交于
      Allow debugging of GNUTLS interactions by setting
      
        LIBVIRT_GNUTLS_DEBUG=10 LIBVIRT_DEBUG=1 virsh
      
      * src/remote/remote_driver.c: Use LIBVIRT_GNUTLS_DEBUG to
        enable gnutls debugging
      36a03bd2
    • J
      tests: adjust copyrights on scripts: s/FSF/Red Hat/ · c5be8bcb
      Jim Meyering 提交于
      * tests/cpuset: Change copyright holder from FSF to Red Hat, Inc.
      * tests/read-bufsiz: Likewise.
      * tests/read-non-seekable: Likewise.
      * tests/start: Likewise.
      * tests/undefine: Likewise.
      * tests/vcpupin: Likewise.
      * tests/virsh-all: Likewise.
      * tests/virsh-synopsis: Likewise.
      c5be8bcb
    • J
      virsh: schedinfo --set invalid=value would simply ignore the option · 9a641564
      Jim Meyering 提交于
      For example, virsh -c test:///default schedinfo 1 --set P=k would
      mistakenly exit successfully, giving no indication that it had failed
      to set the scheduling parameter "P".
      * tools/virsh.c (cmdSchedinfo): Diagnose an invalid --set j=k option,
      rather than silently ignoring it.
      * tests/virsh-schedinfo: New test for the above.
      * tests/Makefile.am (test_scripts): Add it.
      Reported by Jintao Yang in http://bugzilla.redhat.com/586632
      9a641564
    • J
      virsh: fix a typo in a diagnostic · 56035151
      Jim Meyering 提交于
      * tools/virsh.c (cmdSchedInfoUpdate): Fix typo in a diagnostic:
      s/an long long/a long long/.  One in a comment, too.
      56035151
    • E
      delMacvtap: typo fix · 78a6af1f
      Eric Blake 提交于
      * src/util/macvtap.c (delMacvtap): Fix documentation.
      78a6af1f
    • E
      maint: allow VPATH use of remote_protocol-structs · 3876e010
      Eric Blake 提交于
      * src/Makefile.am (remote_protocol-structs): Ensure file lives in srcdir.
      3876e010
    • E
      docs/Makefile.am: remove unnecessary subshells · 1c589120
      Eric Blake 提交于
      * docs/Makefile.am (ChangeLog.html.in, %.html.tmp, %.html)
      (html/index.html, $(devhelphtml)): Avoid spurious subshells.
      1c589120
    • E
      maint: avoid spurious output if program not present · 7cdf2663
      Eric Blake 提交于
      Some shells warn about missing programs before redirection;
      the idiomatic way to silence them is to run the program check
      inside a subshell, with the redirections outside the subshell.
      But a subshell is only needed in places where it is reasonable
      to expect the use of such a noisy shell in the first place.
      
      * src/Makefile.am (remote_protocol-structs): Use subshell, for
      FreeBSD 8.0 /bin/sh.
      * cfg.mk (sc_preprocessor_indentation): Avoid subshell, since the
      only users running cfg.mk can be assumed to have decent tools.
      7cdf2663
    • E
      storage_encryption: silence clang warning · 23958aed
      Eric Blake 提交于
      For printf("%*s",foo,bar), clang complains if foo is not int:
      
      warning: field width should have type 'int', but argument has
      type 'unsigned int' [-Wformat]
      
      * src/conf/storage_encryption_conf.c
      (virStorageEncryptionSecretFormat, virStorageEncryptionFormat):
      Use correct type.
      * src/conf/storage_encryption_conf.h (virStorageEncryptionFormat):
      Likewise.
      23958aed
  5. 08 5月, 2010 6 次提交
    • J
      help avoid accidental remote_protocol.x changes · 180d4b2b
      Jim Meyering 提交于
      Now, if you update remote_protocol.x without also updating
      remote_protocol-structs to match, then "make check" will fail.
      * src/Makefile.am (remote_protocol-structs): Extract list of
      structs and member names from remote_protocol.o.
      (check-local): Depend on it.
      * src/remote_protocol-structs: New file.
      180d4b2b
    • E
      mingw32-libvirt.spec: bring up to date · d0616e35
      Eric Blake 提交于
      Right now, mingw32-portablexdr is not available in Fedora, but is
      present in fedora-mingw.git.  With that package, plus
      redhat-rpm-config and this patch, it is once again possible to build
      mingw32-libvirt from a Fedora 12 host.
      
      * mingw32-libvirt.spec.in (__debug_install_post): Override.
      (%files): Mention recent additions.
      d0616e35
    • M
      Manually revert "Fix pthread related link error for virt-aa-helper" · cc04c4ca
      Matthias Bolte 提交于
      This reverts commit b5b8a6db.
      
      That commit was not necessary. The problem is fixed by commit
      0e9b3a26, but I didn't rebuild
      it properly after pulling in the commit and didn't notice it.
      cc04c4ca
    • E
      Fix a typo in docs · 563d7ee3
      Ersek Laszlo 提交于
      563d7ee3
    • E
      build: use LIBADD, not LDFLAGS, for adding libraries · 48445ccf
      Eric Blake 提交于
      Per automake, LDFLAGS is used early in the line, and LIBADD
      (libraries) or LDADD (programs) is used late.  On platforms like
      cygwin, without lazy linking, this order matters.  Therefore, libtool
      commands, -L, and similar should be in LDFLAGS, but -l should be in
      L*ADD.
      
      * src/Makefile.am (*_LDFLAGS): Move libraries...
      (*_LIBADD): ...to their LIBADD counterpart.
      48445ccf
    • E
      maint: whitespace cleanups · e6125e49
      Eric Blake 提交于
      * src/Makefile.am: Fix some space-tab issues.
      e6125e49
  6. 07 5月, 2010 13 次提交
    • M
      Fix pthread related link error for virt-aa-helper · b5b8a6db
      Matthias Bolte 提交于
      Link virt-aa-helper explicitly with pthread. This is at least
      required on Ubuntu 10.04.
      b5b8a6db
    • M
      ea8d236b
    • J
      avoid link error in tests using libvirt_util; due to pthread_sigmask · 0e9b3a26
      Jim Meyering 提交于
      * src/Makefile.am (libvirt_util_la_LDFLAGS): Add $(LIB_PTHREAD),
      required, now that we're using gnulib's pthread module.
      0e9b3a26
    • M
      Remove unused nwfilter field from struct remote_error · 34a7f3f6
      Matthew Booth 提交于
      Change 965466c1 added a new field to struct remote_error, which broke
      the RPC protocol. Fortunately the new field is unused, so this change
      simply removes it again.
      
      * src/remote/remote_protocol.(c|h|x): Remove remote_nwfilter from struct
        remote_error
      34a7f3f6
    • W
      Implement SCSI disk unplugging · 6bc4ea5a
      Wolfgang Mauerer 提交于
      With the introduction of the generic qemu device model, unplugging
      SCSI disks works like a charm, so support it in libvirt.
      
      * src/qemu/qemu_driver.c: Add qemudDomainDetachSCSIDiskDevice() to do the
        unplugging, extend qemudDomainDetachDeviceAdd().
      Signed-off-by: NWolfgang Mauerer <wolfgang.mauerer@siemens.com>
      Signed-off-by: NEric Blake <eblake@redhat.com>
      6bc4ea5a
    • E
      qemu: use better types · 697426e4
      Eric Blake 提交于
      * src/qemu/qemu_driver.c (qemudFindDisk): Mark parameter const.
      (qemudShrinkDisks): Mark parameter unsigned.
      697426e4
    • W
      Refactor disk unplugging · dc1a2fcc
      Wolfgang Mauerer 提交于
      We can reuse some of the code for other purposes.
      Signed-off-by: NWolfgang Mauerer <wolfgang.mauerer@siemens.com>
      dc1a2fcc
    • E
      build: simplify checks for sched.h · 2de2d525
      Eric Blake 提交于
      * configure.ac: Remove redundant checks.
      2de2d525
    • E
      build: update gnulib · 062a25f0
      Eric Blake 提交于
      81 patches to gnulib, picks up several new syntax checks.
      
      * .gnulib: Update to latest.
      * .x-sc_prohibit_always_true_header_tests: New file.
      * bootstrap.conf (gnulib_modules): Add sched.
      * src/util/processinfo.c (includes): <sched.h> is now guaranteed.
      * src/network/bridge_driver.c (includes): Drop useless
      <strings.h>.
      * src/openvz/openvz_conf.c (includes): Likewise.
      * src/openvz/openvz_driver.c (includes): Likewise.
      * src/phyp/phyp_driver.c (includes): Likewise.
      * src/qemu/qemu_driver.c (includes): Likewise.
      * src/uml/uml_driver.c (includes): Likewise.
      062a25f0
    • E
      build: drop more redundant configure checks · 70e05fa6
      Eric Blake 提交于
      * configure.ac (AC_CHECK_FUNCS_ONCE, AC_SYS_LARGEFILE): Rely on
      gnulib for strtok_r and large file support.
      (AC_OBJEXT): Drop call now done by AC_PROG_CC.
      (m4_foreach_w): Drop macro guaranteed by gnulib.
      (AC_C_CONST): Drop call declared obsolete by autoconf.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      70e05fa6
    • E
      build: use gnulib's sys/wait.h · 8acaeb73
      Eric Blake 提交于
      * configure.ac: Drop sys/wait.h check.
      * src/libvirt.c (includes): Use header unconditionally.
      * src/remote/remote_driver.c (includes): Likewise.
      * src/storage/storage_backend.c (includes): Likewise.
      * src/util/ebtables.c (includes): Likewise.
      * src/util/hooks.c (includes): Likewise.
      * src/util/iptables.c (includes): Likewise.
      * src/util/util.c (includes): Likewise.
      8acaeb73
    • E
      build: use gnulib's uname · 5349cf1e
      Eric Blake 提交于
      * bootstrap.conf (gnulib_modules): Add uname.
      * configure.ac: Drop uname and sys/utsname.h checks.
      * src/nodeinfo.c (nodeGetInfo): Use uname unconditionally.
      5349cf1e
    • E
      build: rely on gnulib's pthread module · 9017b9bc
      Eric Blake 提交于
      Gnulib can guarantee that pthread.h exists, but for now, it is a dummy
      header with no support for most pthread_* functions.  Modify our
      use of pthread to use function checks, rather than header checks,
      to determine how much pthread support is present.
      
      * bootstrap.conf (gnulib_modules): Add pthread.
      * configure.ac: Drop all pthread.h checks.  Optimize function
      checks.  Add check for pthread functions.
      * src/Makefile.am (libvirt_lxc_LDADD): Ensure proper link.
      * src/remote/remote_driver.c (remoteIOEventLoop): Depend on
      pthread_sigmask, now that gnulib guarantees pthread.h.
      * src/util/util.c (virFork): Likewise.
      * src/util/threads.c (threads-pthread.c): Depend on
      pthread_mutexattr_init, as a witness of full pthread support.
      * src/util/threads.h (threads-pthread.h): Likewise.
      9017b9bc
  7. 06 5月, 2010 2 次提交