1. 23 2月, 2017 6 次提交
    • J
      virsh: Alter formatting a bit for output of domstats fields · ff029e44
      John Ferlan 提交于
      Alter the formatting of each line to not give the appearance of
      one long run-on sentence and to be consistent between the various
      elements of collected/displayed data. The formatting should fit
      within the 80 character display. This removes the need for commas
      at the end of each line.
      ff029e44
    • A
      qemu: Allow multiple bridges when pci-bridges is not available · 011d5465
      Andrea Bolognani 提交于
      qemuDomainAssignPCIAddresses() hardcoded the assumption
      that the only way to support devices on a non-zero bus is
      to add one or more pci-bridges; however, since we now
      support a large selection of PCI controllers that can be
      used instead, the assumption is no longer true.
      
      Moreover, this check was always redundant, because the
      only sensible time to check for the availability of
      pci-bridge is when building the QEMU command line, and
      such a check is of course already in place.
      
      In fact, there were *two* such checks, but since one of
      the two was relying on the incorrect assumption explained
      above, and it was redundant anyway, it has been dropped.
      011d5465
    • A
      tests: Reduce usage of legacy PCI controllers on PCIe machines · d4393c42
      Andrea Bolognani 提交于
      Up until a while ago, libvirt would automatically add a legacy
      PCI controllers combo (dmi-to-pci-bridge + pci-bridge) to any
      PCIe machine type (x86_64/q35 and aarch64/virt).
      
      As a result, a number of input and output files in the test
      suite ended up containing the legacy PCI controllers, even
      though they are not needed or in any way relevant to the
      feature being tested.
      
      Get rid of most of the occurrences. Most of the time, this
      just means removing the controllers from the input file and
      regenerating the output files; in a few instances, some
      minor tweaking is performed on the input file, most notably
      removing the memory balloon: as memory balloon support was
      not the scope of the test being changed, there is no loss
      of test coverage from doing so.
      
      Several occurrences of the legacy PCI controllers remain in
      the test suite, both because removing their usage would have
      required even more tweaking, and because we still want to
      have coverage of this perfectly valid combination.
      d4393c42
    • A
      conf: Make switch statements more strict · 77edbf51
      Andrea Bolognani 提交于
      When switching over the values in the virDomainControllerModelPCI
      enumeration, make sure the proper cast is in place so that the
      compiler can warn us when the coverage is not exaustive.
      
      For the same reason, remove the 'default' case from one of the
      existing switch statements.
      77edbf51
    • A
      qemu: Make switch statements more strict · 50d35953
      Andrea Bolognani 提交于
      When switching over the values in the virDomainControllerModelPCI
      enumeration, make sure the proper cast is in place so that the
      compiler can warn us when the coverage is not exaustive.
      
      For the same reason, fold some unstructured checks (performed by
      comparing directly against some values in the enumeration) inside
      an existing switch statement.
      50d35953
    • A
      conf: Remove dead code · c6a0fb8e
      Andrea Bolognani 提交于
      The switch in virDomainPCIControllerModelToConnectType()
      had some code that, while techically part of the
      _PCIE_SWITCH_DOWNSTREAM_PORT case, was in fact dead due
      to the early return.
      
      Get rid of the dead code, and fix the inaccurate function
      description while at it.
      c6a0fb8e
  2. 22 2月, 2017 15 次提交
  3. 21 2月, 2017 19 次提交