1. 25 6月, 2013 11 次提交
    • J
      Introduce VIR_TYPED_PARAMS_DEBUG macro for dumping typed params · fefb0d54
      Jiri Denemark 提交于
      All APIs that take typed parameters are only using params address in
      their entry point debug messages. With the new VIR_TYPED_PARAMS_DEBUG
      macro, all functions can easily log all individual typed parameters
      passed to them.
      fefb0d54
    • J
      Introduce virTypedParamsReplaceString internal API · 8a7f1166
      Jiri Denemark 提交于
      8a7f1166
    • J
      Introduce virTypedParamsCheck internal API · 637a7c86
      Jiri Denemark 提交于
      This API is useful for checking whether only a specific subset of
      supported typed parameters were passed.
      637a7c86
    • J
      util: Emit proper error code in virTypedParamsValidate · 40369ea6
      Jiri Denemark 提交于
      When unsupported parameter is passed to virTypedParamsValidate,
      VIR_ERR_ARGUMENT_UNSUPPORTED should be returned rather than
      VIR_ERR_INVALID_ARG, which is more appropriate for supported parameters
      used incorrectly.
      40369ea6
    • J
      c40ed416
    • J
      build: Fix check-aclrules in VPATH build · 2ebd8479
      Jiri Denemark 提交于
      2ebd8479
    • L
      pci: make virPCIDeviceDetach consistent in behavior · 9b4a6666
      Laine Stump 提交于
      virPCIDeviceDetach would previously sometimes consume the input device
      object (to put it on the inactive list) and sometimes not. Avoiding
      memory leaks required checking beforehand to see if the device was
      already on the list, and freeing the device object in the caller only
      if there wasn't already an identical object on the inactive list.
      
      This patch makes it consistent - virPCIDeviceDetach will *never*
      consume the input virPCIDevice object; if it needs to put one on the
      inactive list, it will create a copy and put *that* on the list. This
      way the caller knows that it is always their responsibility to free
      the device object they created.
      9b4a6666
    • L
      pci: eliminate memory leak in virPCIDeviceReattach · f962e8b6
      Laine Stump 提交于
      virPCIDeviceReattach was making the assumption that the dev object
      given to it was one and the same with the dev object on the
      inactiveDevs list. If that had been the case, it would not need to
      free the dev object it removed from the inactive list, because the
      caller of virPCIDeviceReattach always frees the dev object that it
      passes in. Since the dev object passed in is *never* the same object
      that's on the list (it is a different object with the same name and
      attributes, created just for the purpose of searching for the actual
      object), simply doing a "ListSteal" to remove the object from the list
      results in one leaked object; we need to actually free the object
      after removing it from the list.
      f962e8b6
    • L
      pci: new utility functions · 50a8d850
      Laine Stump 提交于
      * virPCIDeviceFindByIDs - find a device on a list w/o creating an object
          This makes searching for an existing device on a list lighter weight.
      
      * virPCIDeviceCopy - make a copy of an existing virPCIDevice object.
      
      * virPCIDeviceGetDriverPathAndName - construct new strings containing
          1) the name of the driver bound to this device.
          2) the full path to the sysfs config for that driver.
          (This code was lifted from virPCIDeviceUnbindFromStub, and replaced
          there with a call to this new function).
      50a8d850
    • L
      pci: change stubDriver from const char* to char* · 53e52b4a
      Laine Stump 提交于
      Previously stubDriver was always set from a string literal, so it was
      okay to use a const char * that wasn't freed when the virPCIDevice was
      freed. This will not be the case in the near future, so it is now a
      char* that is allocated in virPCIDeviceSetStubDriver() and freed
      during virPCIDeviceFree().
      53e52b4a
    • L
      syntax: virPCIDeviceFree is also a NOP for NULL args · d80d0d5d
      Laine Stump 提交于
      add it to the syntax-check list and fix the one offending caller.
      d80d0d5d
  2. 24 6月, 2013 23 次提交
  3. 22 6月, 2013 4 次提交
    • J
      netdev: accept NULL in virNetDevSetupControl · 695593fe
      Ján Tomko 提交于
      Commit b9c6b073 dropped the version of virNetDevSetupControl
      that didn't check for NULL arguments, but we call it like that
      in virNetDevBridgeDelete.
      695593fe
    • J
      xen: Implement virConnectGetSysinfo · 3a3b8f69
      Jim Fehlig 提交于
      virConnectGetSysinfo was never implemented in the legacy xen driver.
      This patch provides an implementation based on the qemu driver.
      3a3b8f69
    • J
      libxl: Implement virConnectGetSysinfo · fdc10e8d
      Jim Fehlig 提交于
      virConnectGetSysinfo was never implemented in the libxl driver.
      This patch provides an implementation based on the qemu driver.
      fdc10e8d
    • J
      libxl: Allow libxl to set NIC devid · ba64b971
      Jim Fehlig 提交于
      libxl contains logic to determine an appropriate devid for new devices
      that do not specify one in their configuration.  For all device types
      except NICs, the libxl driver allows libxl to determine devid.  Do the
      same for NICs.
      ba64b971
  4. 21 6月, 2013 2 次提交
    • J
      storage: add support for creating qcow2 images with extensions · 6298f74d
      Ján Tomko 提交于
      Add -o compat= and -o lazy_refcounts options for qemu-img.
      6298f74d
    • J
      conf: add features to volume target XML · 31d42506
      Ján Tomko 提交于
      Add <features> and <compat> elements to volume target XML.
      
      <compat> is a string which for qcow2 represents the QEMU version
      it should be compatible with. Valid values are 0.10 and 1.1.
      1.1 is implicit if the <features> element is present, otherwise
      qemu-img default is used. 0.10 can be specified to explicitly
      create older images after the qemu-img default changes.
      
      <features> contains optional features, so far
      <lazy_refcounts/> is available, which enables caching of reference
      counters, improving performance for snapshots.
      31d42506