1. 11 6月, 2010 2 次提交
    • M
      Check getenv("PATH") for NULL in virFindFileInPath · fc1da688
      Matthias Bolte 提交于
      Otherwise this will segfault if PATH is not defined.
      
      Reported by Emre Erenoglu
      fc1da688
    • J
      virsh: add snapshot backing store support to vol-create-as · b28a068b
      Justin Clift 提交于
      This patch adds two new parameters to the vol-create-as command:
      
       --backing-vol <volume-name-or-key-or-path>
       --backing-vol-format <format-of-backing-vol>
      
        virsh # vol-create-as guest_images_lvm snapvol1 5G --backing-vol \
                    rhel6vm1lun1
        Vol snapvol1 created
      
        virsh # vol-create-as image_dir qcow2snap2 5G --format qcow2 \
                    --backing-vol imagevol1.qcow2 \
                    --backing-vol-format qcow2
        Vol qcow2snap2 created
      
      Additionally, the virsh man page update fixes incorrect snapshot
      parameters that were included in my prior bulk volume command patch.
      b28a068b
  2. 10 6月, 2010 2 次提交
    • E
      build: fix some mingw issues · 3cf642a0
      Eric Blake 提交于
      On Fedora 13 with sufficient mingw32-* packages installed, running
      ./autobuild.sh failed to cross-compile to mingw because
      mingw32-pthreads installed a broken <pthread.h>.  With that
      issue fixed, the build still failed due to use of O_SYNC.
      Meanwhile, recent .spec.in changes got out of sync.
      
      * bootstrap.conf (gnulib_modules): Add fcntl-h, for O_SYNC.
      * .gnulib: Update to latest, to work around buggy pthreads-win32
      library.
      * bootstrap: Import latest from gnulib.
      * mingw32-libvirt.spec.in: Distribute new file.
      3cf642a0
    • E
      build: avoid pthreads-win32 on mingw · 6e5a04f0
      Eric Blake 提交于
      * src/util/threads.c (includes) [WIN32]: On mingw, favor native
      threading over pthreads-win32 library.
      * src/util/thread.h [WIN32] Likewise.
      Suggested by Daniel P. Berrange.
      6e5a04f0
  3. 09 6月, 2010 13 次提交
    • D
      Fix cgroup setup code to cope with root squashing NFS · c37c321c
      Daniel P. Berrange 提交于
      When a disk is on a root squashed NFS server, it may not be
      possible to stat() the disk file in virCgroupAllowDevice.
      The virStorageFileGetMeta method may also fail to extract
      the parent backing store. Both of these errors have to be
      ignored to avoid breaking NFS deployments
      
      * src/qemu/qemu_driver.c: Ignore errors in cgroup setup to
         keep root squash NFS happy
      c37c321c
    • J
    • J
      virsh: remove xen reference in header comment · 74231267
      Justin Clift 提交于
      With libvirt and virsh now being used for much more than Xen, this
      patch removes the outdated reference to Xen in the file header.
      74231267
    • M
      esx: Add proxy query parameter · 46c14d20
      Matthias Bolte 提交于
      Allow to specify a proxy to be used by libcurl.
      46c14d20
    • M
      esx: Refactor esxUtil_ParseQuery's parameter handling · 070f6100
      Matthias Bolte 提交于
      Pass a struct containing the parameters instead of passing each
      one individually. This make future extensions a bit simpler.
      070f6100
    • J
      virsh: add the volume commands to the virsh man page · cd2b1896
      Justin Clift 提交于
      This patch also includes the new vol-pool command.
      cd2b1896
    • J
      virsh: add new vol-pool command · 62f8674d
      Justin Clift 提交于
      This patch adds a new "vol-pool" command to virsh, to round out the
      identifier conversion functions for volumes in virsh.  Now it is
      possible to work with volumes when starting from just a volume key
      or volume path.
      62f8674d
    • E
      virsh: add --paused option to create · 734bbf0e
      Eric Blake 提交于
      * tools/virsh.c (opts_create): Add --paused option.
      (cmdCreate): Pass appropriate flag.
      * tools/virsh.pod: Document it.
      734bbf0e
    • E
      qemu: allow creation of a paused domain · 68e4793a
      Eric Blake 提交于
      https://bugzilla.redhat.com/show_bug.cgi?id=589465
      
      Some guests (eg with badly configured grub, or Windows' installation cd)
      require quick response from the console user. That's why we have a
      "launchPaused" option in vdsm.
      
      To implement it via libvirt, we need to ask libvirt not to call
      qemuMonitorStartCPUs() after starting qemu.  Calling virDomainStop
      immediately after the domain is up is inherently raceful.
      
      * src/qemu/qemu_driver.c (qemudStartVMDaemon): Add new parameter;
      all callers adjusted.
      (qemudDomainCreate): Implement support for new flag.
      68e4793a
    • E
      virDomainCreateXML: support new flag · 2502ebb3
      Eric Blake 提交于
      * include/libvirt/libvirt.h.in (virDomainCreateFlags): Add
      VIR_DOMAIN_START_PAUSED.
      * src/libvirt.c (virDomainCreateXML): Update documentation.
      * src/lxc/lxc_driver.c (lxcDomainCreateAndStart): Reject new flag
      as unimplemented.
      * src/opennebula/one_driver.c (oneDomainCreateAndStart):
      Likewise.
      * src/openvz/openvz_driver.c (openvzDomainCreateXML): Likewise.
      * src/phyp/phyp_driver.c (phypDomainCreateAndStart): Likewise.
      * src/qemu/qemu_driver.c (qemudDomainCreate): Likewise.
      * src/test/test_driver.c (testDomainCreateXML): Likewise.
      * src/uml/uml_driver.c (umlDomainCreate): Likewise.
      * src/vbox/vbox_tmpl.c (vboxDomainCreateXML): Likewise.
      * src/xen/xend_internal.c (xenDaemonCreateXML): Likewise.
      * src/xenapi/xenapi_driver.c (xenapiDomainCreateXML): Likewise.
      2502ebb3
    • D
      Fix leaks in udev device add/remove v3 · e7f3bad4
      David Allan 提交于
      * This patch is a modification of a patch submitted by Nigel Jones.
        It fixes several memory leaks on device addition/removal:
      
      1. Free the virNodeDeviceDefPtr in udevAddOneDevice if the return
         value is non-zero
      
      2. Always release the node device reference after the device has been
         processed.
      
      * Refactored for better readability per the suggestion of clalance
      e7f3bad4
    • D
      Add multiIQN tests · 77da2487
      David Allan 提交于
      * Fix broken rng schema
      * Add test input & output files
      77da2487
    • D
      Add multiiqn XML dump · 98fafb0c
      David Allan 提交于
      * Use virBufferEscapeString() per Dan B.
      98fafb0c
  4. 08 6月, 2010 17 次提交
    • D
      Fix test breakage from virtio serial changes · 9cb08020
      Daniel P. Berrange 提交于
      The virtio serial changes broke the test suite because they forgot
      to add the new address attribute to the domain XML schema. The
      xml2xml test also broke because the XML no longer roundtrips. This
      is due to testing of auto-addition of <controller> elements. Split
      that test case off into a separate XML file to avoid breakage
      
      * docs/schemas/domain.rng: Allow port number for virtio serial addresses
      * tests/qemuxml2argvdata/qemuxml2argv-channel-virtio.args,
        tests/qemuxml2argvdata/qemuxml2argv-channel-virtio.xml: Revert to
        a simple config to avoid breaking xml2xml test
      * tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-auto.xml,
        tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-auto.args: Add
        complex test case for auto-controller addition for xml2argv test
      * tests/qemuxml2argvtest.c: Add channel-virtio-auto test
      9cb08020
    • D
      Enable probing of VPC disk format type · f4365c73
      Daniel P. Berrange 提交于
      A look at the QEMU source revealed the missing bits of info about
      the VPC file format, so we can enable this now
      
      * src/util/storage_file.c: Enable VPC format, providing version
        and disk size offset fields
      f4365c73
    • D
      Ensure that PCI device is reattached to host if hotadd fails · 1c72695c
      Daniel P. Berrange 提交于
      When an attempt to hotplug a PCI device to a guest fails,
      the device was left attached to pci-stub. It is neccessary
      to reset the device and then attach it to the host driver
      again.
      
      * src/qemu/qemu_driver.c: Reattach PCI device to host if
        hotadd fails
      1c72695c
    • D
      Don't raise errors in the selinux restore code · f43dc26a
      Daniel P. Berrange 提交于
      The restore code is done in places where errors cannot be
      raised, since they will overwrite over pre-existing errors.
      
      * src/security/security_selinux.c: Only warn about failures
        in label restore, don't report errors
      f43dc26a
    • D
      Fix check for errors in device_add command in QEMU text monitor · c833efd3
      Daniel P. Berrange 提交于
      Any output at all from device_add indicates an error in the
      command execution. Thus it needs to check for reply != ""
      
      * src/qemu/qemu_monitor_text.c: Fix reply check for errors
        to treat any output as an error
      c833efd3
    • D
      Prefer UDEV to HAL drivers if both a compiled · 345ff369
      Daniel P. Berrange 提交于
      HAL is deprecated and UDEV is the future. Thus if both
      options are compiled, we should prefer use of UDEV over
      HAL
      
      * src/node_device/node_device_driver.c: Switch init
        order to try UDEV first, then HAL
      345ff369
    • D
      Add support for setting socket MLS level in SELinux driver · e72cc3c1
      Daniel J Walsh 提交于
      When SELinux is running in MLS mode, libvirtd will have a
      different security level to the VMs. For libvirtd to be
      able to connect to the monitor console, the client end of
      the UNIX domain socket needs a different label. This adds
      infrastructure to set the socket label via the security
      driver framework
      
      * src/qemu/qemu_driver.c: Call out to socket label APIs in
        security driver
      * src/qemu/qemu_security_stacked.c: Wire up socket label
        drivers
      * src/security/security_driver.h: Define security driver
        entry points for socket labelling
      * src/security/security_selinux.c: Set socket label based on
        VM label
      e72cc3c1
    • D
      Network duplicate UUID/name checking · 3bb37439
      Daniel P. Berrange 提交于
      The network driver is not doing correct checking for
      duplicate UUID/name values. This introduces a new method
      virNetworkObjIsDuplicate, based on the previously
      written virDomainObjIsDuplicate.
      
      * src/conf/network_conf.c, src/conf/network_conf.c,
        src/libvirt_private.syms: Add virNetworkObjIsDuplicate,
      * src/network/bridge_driver.c: Call virNetworkObjIsDuplicate
        for checking uniqueness of uuid/names
      3bb37439
    • D
      Fix error codes for missing storage pools · 627409d1
      Daniel P. Berrange 提交于
      The storage pool driver is mistakenly using the error code
      VIR_ERR_INVALID_STORAGE_POOL which is for diagnosing invalid
      pointers. This patch switches it to use VIR_ERR_NO_STORAGE_POOL
      which is the correct code for cases where the storage pool does
      not exist
      
      * src/storage/storage_driver.c: Replace VIR_ERR_INVALID_STORAGE_POOL
        with VIR_ERR_NO_STORAGE_POOL
      627409d1
    • D
      Storage pool duplicate UUID/name checking · e9364d9f
      Daniel P. Berrange 提交于
      The storage pool driver is not doing correct checking for
      duplicate UUID/name values. This introduces a new method
      virStoragePoolObjIsDuplicate, based on the previously
      written virDomainObjIsDuplicate.
      
      * src/conf/storage_conf.c, src/conf/storage_conf.c,
        src/libvirt_private.syms: Add virStoragePoolObjIsDuplicate,
      * src/storage/storage_driver.c: Call virStoragePoolObjIsDuplicate
        for checking uniqueness of uuid/names
      e9364d9f
    • D
      Fix auto-adding of virtio serial controllers · f4f91e7b
      Daniel P. Berrange 提交于
      The domain parsing code would auto-add a virtio serial controller
      if it saw any virtio serial channel defined. Unfortunately it
      always added a controller with index=0, even if the channel address
      specified an index != 0. It only added one controller, even if
      multiple controllers were referenced by channels. Finally, it let
      the ports+vectors parameters initialize to zero instead of -1, which
      prevented the controllers accepting any ports.
      
      * src/conf/domain_conf.c: Initialize ports+vectors when adding
        virtio serial controllers. Add all neccessary virtio serial
        controllers, instead of hardcoding controller 0
      * qemuxml2argvdata/qemuxml2argv-channel-virtio.args,
        qemuxml2argvdata/qemuxml2argv-channel-virtio.xml: Expand to
        test controller auto-add behaviour
      f4f91e7b
    • D
      Include port number with virtio serial devices · 2e56cfa7
      Daniel P. Berrange 提交于
      To ensure that the device addressing scheme is stable across
      hotplug/unplug, all virtio serial channels needs to have an
      associated port number in their address. This is then specified
      to QEMU using the nr=NNN parameter
      
      * src/conf/domain_conf.c, src/conf/domain_conf.h: Parsing
        for port number in vioserial address types.
      * src/qemu/qemu_conf.c: Set 'nr=NNN' parameter with virtio
        serial port number
      * tests/qemuxml2argvdata/qemuxml2argv-channel-virtio.args,
        tests/qemuxml2argvdata/qemuxml2argv-channel-virtio.xml: Expand
        data set to ensure coverage of port addressing
      2e56cfa7
    • D
      Disable use of 'reason' field in block IO event in QEMU · b490f2c1
      Daniel P. Berrange 提交于
      QEMU upstream decided against adding a 'reason' field to
      the block IO event in QMP. Disable this code to remove a
      annoying warning message. It will be renabled when the
      error string reason is re-introduced in QEMU
      b490f2c1
    • D
      Ensure UNIX domain sockets are removed on daemon shutdown · 53fc1d8a
      Daniel P. Berrange 提交于
      When libvirtd exits it is leaving UNIX domain sockets on
      the filesystem. These need to be removed.
      
      The qemudInitPaths() method has signficant code churn to
      switch from using a pre-allocated buffer on the stack, to
      dynamically allocating on the heap.
      
      * daemon/libvirtd.c, daemon/libvirtd.h: Store a reference
        to the UNIX domain socket path and unlink it on shutdown
      53fc1d8a
    • J
      3093daf1
    • J
      Fix AppArmor save/restore.Add stdin_path to qemudStartVMDaemon() args. · 97b68a49
      Jamie Strandboge 提交于
      Refactor to update AppArmor security driver to adjust profile for
      save/restore. This addresses the following bugs:
      
       https://bugzilla.redhat.com/show_bug.cgi?id=529363
       https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/457716
      97b68a49
    • J
      Add stdin_path to qemudStartVMDaemon() args. · 2b57478e
      Jamie Strandboge 提交于
      Adjust args to qemudStartVMDaemon() to also specify path to stdin_fd,
      so this can be passed to the AppArmor driver via SetSecurityAllLabel().
      
      This updates all calls to qemudStartVMDaemon() as well as setting up
      the non-AppArmor security driver *SetSecurityAllLabel() declarations
      for the above. This is required for the following
      "apparmor-fix-save-restore" patch since AppArmor resolves the passed
      file descriptor to the pathname given to open().
      2b57478e
  5. 06 6月, 2010 1 次提交
  6. 05 6月, 2010 4 次提交
    • L
      Adjust block size used by dd to speed QEMU domain save operations. · 20206a4b
      Laine Stump 提交于
      See https://bugzilla.redhat.com/show_bug.cgi?id=599091
      
      Saving a paused 512MB domain took 3m47s with the old block size of 512
      bytes. Changing the block size to 1024*1024 decreased the time to 56
      seconds. (Doubling again to 2048*1024 yielded 0 improvement; lowering
      to 512k increased the save time to 1m10s, about 20%)
      20206a4b
    • L
      Fix dereference of potentially freed pointer in qemudDomainSaveFlags · 1d45e1b6
      Laine Stump 提交于
      The pointer to the xml describing the domain is saved into an object
      prior to calling VIR_REALLOC_N() to make the size of the memory it
      points to a multiple of QEMU_MONITOR_MIGRATE_TO_FILE_BS. If that
      operation needs to allocate new memory, the pointer that was saved is
      no longer valid.
      
      To avoid this situation, adjust the size *before* saving the pointer.
      
      (This showed up when experimenting with very large values of
      QEMU_MONITOR_MIGRATE_TO_FILE_BS).
      1d45e1b6
    • J
      Fixes for commit 211dd1e9 · b1eb7f2e
      Jim Fehlig 提交于
      Fixes for issues in commit 211dd1e9 noted by by Jim Meyering.
      
      1. Allocate content buffer of size content_length + 1 to ensure
         NUL-termination.
      2. Limit content buffer size to 64k
      3. Fix whitespace issue
      
      V2:
        - Add comment to clarify allocation of content buffer
        - Add ATTRIBUTE_NONNULL where appropriate
        - User NULLSTR macro
      b1eb7f2e
    • E
      autobuild.sh: avoid bashism · fc6d5b26
      Eric Blake 提交于
      * autobuild.sh: Replace 'set -o pipefail' with POSIX alternative.
      Reported by Matthias Bolte.
      fc6d5b26
  7. 04 6月, 2010 1 次提交
    • J
      Allocate buffer to hold xend response · 211dd1e9
      Jim Fehlig 提交于
      There are cases when a response from xend can exceed 4096 bytes, in
      which case anything beyond 4096 is ignored. This patch changes the
      current fixed-size, stack-allocated buffer to a dynamically allocated
      buffer based on Content-Length in HTTP header.
      211dd1e9