- 27 2月, 2008 6 次提交
-
-
由 Jim Meyering 提交于
* src/Makefile.am (virsh_SOURCES): Add util-lib.h.
-
由 Jim Meyering 提交于
* src/capabilities.c: Include <config.h> from the .c file, * src/capabilities.h: ... not from the .h file.
-
由 Richard W.M. Jones 提交于
-
由 Daniel P. Berrange 提交于
-
由 Richard W.M. Jones 提交于
* src/qemu_driver.c: Implement virDomainBlockStats for QEMU/KVM using QEMU/KVM 'info blockstats' command (Richard Jones). * src/qemu_driver.c, src/qemu_conf.h: const-correctness fixes (Jim Meyering).
-
由 Richard W.M. Jones 提交于
* src/xm_internal.c: handle the case where <mac/> clause in Xen domain interface has no address attribute (Shigeki Sakamoto).
-
- 26 2月, 2008 2 次提交
-
-
由 Daniel Veillard 提交于
-
由 Daniel Veillard 提交于
src/remote_internal.c src/test.c src/util.c src/util.h src/xen_unified.c: added probe interface at the driver level, use that to improve default hypervisor selection in the absence of a given URI when connecting Daniel
-
- 25 2月, 2008 2 次提交
-
-
由 Daniel Veillard 提交于
* src/Makefile.am src/util-lib.h: fix done with Jim to allow compilation of virsh with the static libraries. Daniel
-
由 Jim Meyering 提交于
* .x-sc_avoid_write: Exempt src/util-lib.c, too. * Makefile.maint (sc_unmarked_diagnostics): Filter out false positives. * src/storage_backend_fs.c (virStorageBackendFileSystemVolCreate): Use safewrite, not write. * src/storage_backend_logical.c (virStorageBackendLogicalBuildPool): Likewise.
-
- 23 2月, 2008 1 次提交
-
-
由 Jim Meyering 提交于
Avoid warnings like this: file:nnn:format not a string literal and no format arguments * qemud/qemud.c: Insert a "%s" format argument. * qemud/remote.c: Likewise. * src/iptables.c: Likewise. * src/qemu_driver.c: Likewise. * src/storage_backend.c: Likewise. * src/storage_backend_fs.c: Likewise. * src/storage_backend_iscsi.c Likewise. * src/storage_backend_logical.c: Likewise. * src/storage_conf.c: Likewise. * src/storage_driver.c: Likewise.
-
- 22 2月, 2008 6 次提交
-
-
由 Jim Meyering 提交于
Also add "make syntax-check" rules to ensure no new uses sneak in. There are many uses of write like this: if (write (fd, xml, towrite) != towrite) return -1; The problem is that the syscall can succeed, yet write less than the requested number of bytes, so the caller should retry rather than simply failing. This patch changes most of them to use util.c's safewrite wrapper, which encapsulates the process. Also, there were a few cases in which the retry loop was open-coded, and I replaced those, too. * Makefile.maint (sc_avoid_write): New rule, to avoid recurrence. * .x-sc_avoid_write: New file. Record two legitimate exemptions. * qemud/qemud.c (sig_handler, qemudClientWriteBuf): Use safewrite, not write. * src/conf.c (__virConfWriteFile): Likewise. * src/qemu_conf.c (qemudSaveConfig, qemudSaveNetworkConfig): Likewise. * src/qemu_driver.c (qemudWaitForMonitor, qemudStartVMDaemon) (qemudVMData, PROC_IP_FORWARD): Likewise. * proxy/libvirt_proxy.c: Include "util.h". (proxyWriteClientSocket): Use safewrite. * src/test.c (testDomainSave, testDomainCoreDump): Likewise. * src/proxy_internal.c (virProxyWriteClientSocket): Likewise. * src/virsh.c: Include "util-lib.h". (vshOutputLogFile): Use safewrite. * src/console.c: Include "util-lib.h". (vshRunConsole): Use safewrite.
-
由 Jim Meyering 提交于
We currently use safewrite from inside libvirt and don't want to publish any such function name. However, we do want to use it in applications like virsh, libvirtd and libvirt_proxy that link with libvirt. To that end, this change moves that function definition (along with the nearly identical saferead) into a new file, util-lib.c. To avoid maintaining separate copies of even such small functions, we simply include that new file from util.c. Then, the separate applications that need to use safewrite simply compile and link with util-lib.c. Of course, this does mean that each of those applications will containing two copies of these functions. However, the functions are so small that it's not worth worrying about that. * src/util.c (saferead, safewrite): Move function definitions to util-lib.c and include that .c file. * src/util-lib.c (saferead, safewrite): New file. Functions from src/util.c with slight change (s/int r =/ssize_t r =/) to reflect read/write return type. * src/util-lib.h: Declare the two moved functions. * src/util.h: Remove declarations. Include src/util-lib.h. * proxy/Makefile.am (libvirt_proxy_SOURCES): Add src/util-lib.c. * qemud/Makefile.am (libvirtd_SOURCES): Likewise. * src/Makefile.am (virsh_SOURCES): Add util-lib.c. Remove some SP-before-TAB.
-
由 Jim Meyering 提交于
* src/iptables.c (iptRulesSave) [!ENABLE_IPTABLES_LOKKIT]: Mark parameter as used.
-
由 Jim Meyering 提交于
* tests/statstest.c (testQuietError) [!WITH_XEN]: Don't define.
-
由 Jim Meyering 提交于
* src/openvz_conf.c (openvzSetUUID): Rewrite to avoid unchecked lseek, write, and close as well as a potential file descriptor leak.
-
由 Jim Meyering 提交于
* src/openvz_conf.c (openvzLocateConfDir, openvzGetVPSUUID): (openvzSetUUID): Don't dereference NULL upon failure.
-
- 21 2月, 2008 5 次提交
-
-
由 Richard W.M. Jones 提交于
* src/openvz_conf.c: Double-free fix (Anton Protopopov).
-
由 Daniel P. Berrange 提交于
-
由 Jim Meyering 提交于
* docs/examples/index.py: Don't emit trailing blanks. * docs/examples/Makefile.am: Regenerate.
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
- 20 2月, 2008 18 次提交
-
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-
由 Daniel P. Berrange 提交于
-