1. 28 6月, 2015 3 次提交
  2. 27 6月, 2015 6 次提交
    • J
      qemu: Resolve Coverity RESOURCE_LEAK · 782355a7
      John Ferlan 提交于
      Commit id '15fa84ac' added the alias fetch, but forgot to free it.
      782355a7
    • J
      docs: Clarification for when allowed to use 'lun' for "volume" · 91b96438
      John Ferlan 提交于
      While re-reading what I wrote for commit id '785a8940', I realized
      I needed to clarify that being able to present as a 'lun', the mode
      property for the pool source element needed to be "host" (or empty)
      and not "direct".
      
      It was described correctly later in the mode host description, but
      this just ensures it's not missed here as well.
      Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
      91b96438
    • L
      docs: document when pcie-root/dmi-to-pci-bridge support was added · 10e207bb
      Laine Stump 提交于
      Also move the mention of version numbers for the various PCI
      controller models up to the end of the sentence where they are first
      given, to avoid confusion.
      10e207bb
    • L
      qemu: ignore assumptions about hotplug requirement when address is from config · 9a12b6cd
      Laine Stump 提交于
      Certain PCI buses don't support hotplug, and when automatically
      assigning PCI addresses for devices, libvirt is very conservative in
      its assumptions about whether or not a device will need to be
      hotplugged/unplugged in the future. But if the user manually assigns
      an address, they likely are aware of any hotplug requirements of the
      device (or at least they should be).
      
      In short, after this patch, automatically PCI address assignment will
      assume that the device must be plugged in to a hot-pluggable slot, but
      manually assignment can place the device in any bus that is
      compatible, regardless of whether or not it supports hotplug. If the
      user makes a mistake and plugs the device into a bus that doesn't
      support hotplug, then later tries to do a hot-unplug, qemu will give
      an appropriate error.
      
      (in the future we may want to add a "hotpluggable" attribute to all
      devices, with default being "yes" for autoassign, and "no" for manual
      assign).
      9a12b6cd
    • L
      qemu: always permit PCI devices to be manually assigned to a PCIe bus · 1e15be1b
      Laine Stump 提交于
      When support for the pcie-root and dmi-to-pci-bridge buses on a Q35
      machinetype was added, I was concerned that even though qemu at the
      time allowed plugging a PCI device into a PCIe port, that it might not
      be supported in the future. To prevent painful backtracking in the
      possible future where this happened, I disallowed such connections
      except in a few specific cases requested by qemu developers (indicated
      in the code with the flag VIR_PCI_CONNECT_TYPE_EITHER_IF_CONFIG).
      
      Now that a couple years have passed, there is a clear message from
      qemu that there is no danger in allowing PCI devices to be plugged
      into PCIe ports. This patch eliminates
      VIR_PCI_CONNECT_TYPE_EITHER_IF_CONFIG and changes the code to always
      allow PCI->PCIe or PCIe->PCI connection *when the PCI address is
      specified in the config. (For newly added devices that haven't yet
      been given a PCI address, the auto-placement still prefers using the
      correct type of bus).
      1e15be1b
    • L
      qemu: refactor qemuBuildControllerDevStr to eliminate future duplicate code · 1074fc50
      Laine Stump 提交于
      The PCI case of the switch statement in this function contains another
      switch statement with a case for each model. Currently every model
      except pci-root and pcie-root has a check for index > 0 (since only
      those two can have index==0), and the function should never be called
      for those two anyway. If we move the check for !pci[e]-root to the top
      of the pci case, then we can move the check for index > 0 out of the
      individual model cases. This will save repeating that check for the
      three new controller models about to be added.
      1074fc50
  3. 26 6月, 2015 20 次提交
  4. 25 6月, 2015 11 次提交