1. 10 7月, 2009 1 次提交
    • J
      build: automatically rerun ./bootstrap when needed · f272378d
      Jim Meyering 提交于
      When "git pull" (or any other operation) brings in a new version of the
      gnulib git submodule, you must rerun the autogen.sh script.  With this
      change, "make" now fails and tells you to run ./autogen.sh, when needed.
      * autogen.sh: Maintain a new file, .git-module-status, containing
      the current submodule status.  If it doesn't exist or its content
      is different from what "git submodule status" prints, then run
      ./bootstrap
      * .gitignore: Add .git-module-status
      * cfg.mk: Diagnose out of date submodule and fail.
      * README-hacking: Update not to mention bootstrap.
      * Makefile.am (MAINTAINERCLEANFILES): Add .git-module-status,
      so that "make maintainerclean" will remove it.
      f272378d
  2. 08 7月, 2009 4 次提交
    • J
      use gnumakefile and maintainer-makefile modules from gnulib · bf773e04
      Jim Meyering 提交于
      * bootstrap (modules): Add gnumakefile and maintainer-makefile.
      * GNUmakefile: Remove file, now provided by gnulib.
      * Makefile.maint: Remove.  Replaced by maint.mk from gnulib.
      .gitignore: Add GNUmakefile and maint.mk.
      * cfg.mk (prev_version_file): Disable this feature.
      Setting this to /dev/null avoids an otherwise harmless diagnostic.
      bf773e04
    • J
      skip some of gnulib's new rules · 360194bf
      Jim Meyering 提交于
      * cfg.mk (local-checks-to-skip): Add these: sc_error_message_uppercase,
      sc_program_name, sc_require_test_exit_idiom, sc_makefile_check.
      360194bf
    • J
      Prepare to use maint.mk from gnulib · c120fcc0
      Jim Meyering 提交于
      Since Makefile.maint will soon come from gnulib's maint.mk,
      sync Makefile.maint to have the same contents (modulo minor
      things).  In syncing it, we have to remove some libvirt-specific
      rules.  Since we want to keep them (of course), put those in cfg.mk.
      * Makefile.maint: Merge from gnulib's maint.mk.
      * cfg.mk (sc_avoid_write): New rule.  From Makefile.cfg.
      (sc_prohibit_strcmp_and_strncmp): Likewise, and rename.
      (sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise.
      (sc_prohibit_nonreentrant): Likewise.
      (sc_prohibit_ctype_h): Likewise.
      (sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise.
      (sc_prohibit_virBufferAdd_with_string_literal): Likewise.
      (sc_prohibit_gethostby): Likewise.
      (sc_libvirt_unmarked_diagnostics): Likewise.  Also, rename the
      rule, inserting "_libvirt", since this rule is a specialization of
      the one in gnulib.
      * GNUmakefile: Include cfg.mk, not Makefile.cfg
      * .x-sc_prohibit_strcmp_and_strncmp: New file.
      * Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
      c120fcc0
    • J
      * Makefile.cfg: Rename to... · 96c807fe
      Jim Meyering 提交于
      * cfg.mk: ...this.  New file.
      96c807fe
  3. 03 2月, 2009 3 次提交
    • J
      build: enable redundant-const check · dff21147
      Jim Meyering 提交于
      * Makefile.cfg (local-checks-to-skip): Remove sc_redundant_const.
      * src/lxc_controller.c: Remove redundant "const"(s).
      * src/storage_backend_fs.c: Likewise.
      * src/util.h: Likewise.
      * src/xen_internal.c: Likewise.
      * tests/qparamtest.c: Likewise.
      dff21147
    • J
      syntax-check: enable more checks · 08f87e3d
      Jim Meyering 提交于
      * Makefile.cfg (local-checks-to-skip): Don't skip sc_m4_quote_check.
      Don't skip sc_prohibit_nonreentrant.
      * Makefile.nonreentrant (NON_REENTRANT): Comment out until we've
      remove all remaining uses of strerror.
      08f87e3d
    • J
      cleanup: remove useless if-before-VIR_FREE · c18ccff4
      Jim Meyering 提交于
      * Makefile.cfg (useless_free_options): Also check for VIR_FREE.
      * src/iptables.c (iptRulesFree): Remove useless if-before-VIR_FREE.
      * src/remote_internal.c (remoteAuthSASL): Likewise.
      * src/test.c (testOpenFromFile): Likewise.
      c18ccff4
  4. 29 1月, 2009 1 次提交
  5. 21 1月, 2009 1 次提交
  6. 15 5月, 2008 1 次提交
  7. 29 4月, 2008 1 次提交
  8. 21 4月, 2008 1 次提交
  9. 08 2月, 2008 2 次提交
    • J
      Enable another syntax-check rule. · db4037e5
      Jim Meyering 提交于
      * Makefile.cfg (local-checks-to-skip): Remove sc_no_have_config_h.
      * qemud/mdns.c: Remove "#ifdef HAVE_CONFIG_H".
      * Makefile.maint (sc_no_have_config_h): Tighten up regexp,
      so that the above mention of "HAVE_CONFIG_H" doesn't match.
      * .x-sc_no_have_config_h: New file, to exempt gnulib/ straggler.
      db4037e5
    • J
      Remove more useless if tests before "free"-like functions. · e8ff93b4
      Jim Meyering 提交于
      * build-aux/useless-if-before-free: Rename from ...
      * build-aux/find-unnecessary-if-before-free: ... this.  Remove file.
      Also changed it so that new names are no longer hard-coded in the
      script.  Instead, they're supplied via options:
      * Makefile.cfg (useless_free_options): Define.
      Add xmlXPathFreeObject to the list of free-like functions it detects.
      * Makefile.maint (sc_avoid_if_before_free): Reflect script renaming.
      * .x-sc_avoid_if_before_free: Likewise.
      * src/openvz_conf.c (openvzParseXML): Remove useless "if"-before-free.
      * src/qemu_conf.c (qemudParseXML, qemudParseNetworkXML): Likewise.
      * src/virsh.c (cmdVNCDisplay, cmdTTYConsole, cmdDetachInterface):
      (cmdDetachDisk): Likewise.
      * src/xm_internal.c (xenXMConfigSetIntFromXPath): Likewise.
      (xenXMConfigSetStringFromXPath, xenXMParseXMLToConfig): Likewise.
      (xenXMDomainAttachDevice, xenXMAttachDisk, xenXMAttachInterface):
      (xenXMDomainDetachDevice): Likewise.
      * src/xml.c (virXPathString): Likewise.
      * tests/xmlrpctest.c (checkRequestValue): Likewise.
      e8ff93b4
  10. 06 2月, 2008 1 次提交
  11. 04 2月, 2008 1 次提交
  12. 30 1月, 2008 6 次提交
    • J
      Enable two more tests. · 1be2c8c8
      Jim Meyering 提交于
      * Makefile.cfg (local-checks-to-skip)
      [sc_cast_of_x_alloc_return_value, sc_cast_of_argument_to_free]: Enable.
      1be2c8c8
    • J
      Enable the <assert.h>-checking test; fix violations. · 2c725623
      Jim Meyering 提交于
      * Makefile.cfg (local-checks-to-skip)
      [sc_prohibit_assert_without_use]: Enable.
      * qemud/mdns.c: Don't include <assert.h>; no uses of assert here.
      * qemud/qemud.c: Likewise.
      * qemud/remote.c: Likewise.
      2c725623
    • J
      Enable the po-check test; fix violations. · 05ae9d8b
      Jim Meyering 提交于
      * Makefile.cfg (local-checks-to-skip) [po-check]: Enable.
      * po/POTFILES.in: Add three file names.  Sort.
      05ae9d8b
    • J
      Enable the <config.h>-requiring test; fix violations · a3781881
      Jim Meyering 提交于
      Use <config.h>, not "config.h", per autoconf documentation.
      * Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable.
      * .x-sc_require_config_h: New file, to list exempted files.
      * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.
      a3781881
    • J
      Enable the duplicate-"the" test; fix violations · 9e4c8fcb
      Jim Meyering 提交于
      * Makefile.cfg (local-checks-to-skip) [sc_the_the]: Enable.
      * docs/virsh.pod: Remove a duplicate "the".
      * libvirt.spec.in: Likewise.
      * virsh.1: Likewise.
      9e4c8fcb
    • J
      Add framework for code style- and syntax-checking rules. · cc337da2
      Jim Meyering 提交于
      	Almost all tests are initially disabled via the list in Makefile.cfg.
      	* Makefile.am (EXTRA_DIST): Add .x-sc_avoid_if_before_free.
      	Omit names of files that automake includes automatically.
      	* .x-sc_avoid_if_before_free: New file.
      	* build-aux/vc-list-files: Likewise.
      	* build-aux/find-unnecessary-if-before-free: Likewise.
      	* GNUmakefile, Makefile.cfg, Makefile.maint: New files.
      cc337da2