- 21 4月, 2016 13 次提交
-
-
由 Cole Robinson 提交于
My commit 0d157957 crashes on a URI without a scheme, like via 'virsh --connect frob' Add a check on uri->server too while we are at it, and centralize them all
-
由 Erik Skultety 提交于
Commit a8743c39 removed keepalive_required attribute from daemon, added a test case for it, but forgot to enable the test itself in virnetdaemontest. Signed-off-by: NErik Skultety <eskultet@redhat.com>
-
由 Erik Skultety 提交于
We already did this once, but somehow commit 252610f7 managed to bring the tabs back again. Signed-off-by: NErik Skultety <eskultet@redhat.com>
-
由 Erik Skultety 提交于
Commit a4746114 renamed virnetservertest to virnetdaemontest to reflect some refactor changes to virNetServer code (which moved daemon-related parts to virNetDaemon module). Moving test data from virnetserverdata to virnetdaemondata was also part of the commit, but the commit failed to clean half of the files that were copied (rather than moved). Signed-off-by: NErik Skultety <eskultet@redhat.com>
-
由 Roman Bogorodskiy 提交于
Re-do 0217089b so it does not add regression for commit c0726e07 that allowed to print help without making a connection to the daemon.
-
由 Andrea Bolognani 提交于
The autoconf documentation recommends to always use this construct when creating symbolic links with $(LN_S) to avoid unexpected behavior.
-
由 Andrea Bolognani 提交于
The current rule fails if the target already exists: cd /home/jenkins/build/libvirt/lib && \ ln -s libnss_libvirt.so.1 nss_libvirt.so.1 ln: nss_libvirt.so.1: File exists Makefile:3357: recipe for target 'install-exec-hook' failed However, all other rules concerned with installation are idempotent and will happily overwrite an existing target, so this one should as well.
-
由 Andrea Bolognani 提交于
We use $(LN_S) for creating symbolic links, but the appropriate autoconf macro was not included among the checks for external programs.
-
由 Andrea Bolognani 提交于
autotools provide those for our convenience, so let's use them everywhere instead of mixing in native command invocation.
-
由 Peter Krempa 提交于
The only place that uses it doesn't warrant a separate label.
-
由 Peter Krempa 提交于
After failing to parse the perf event list, the code would return failure without freeing the previously acquired object. Rearrange the code to avoid the problem. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1329046
-
由 Roman Bogorodskiy 提交于
Currently, if a connection URI was specified on the command line by the '-c' switch, virsh connects to it, but after connecting overrides its value with the one it tries to obtain from the VIRSH_DEFAULT_CONNECT_URI environment variable. This makes virsh connecting to the wrong URI if it disconnects from the hypervisor and then tries to reconnect, and also leaks the original connname. Fix by calling virGetEnvBlockSUID() before virshParseArgv().
-
由 Cole Robinson 提交于
The proper nwfilter docs go into full detail, but we should still have a brief bit about domain XML in the domain documentation
-
- 20 4月, 2016 27 次提交
-
-
由 Michal Privoznik 提交于
Our uninstall script is not exact counterpart of install one. Therefore we are leaving couple of files behind. This should not happen. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Michal Privoznik 提交于
While we could leave it behind as an indelible sign that libvirt has been running on host, other users might not be that fond of it. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Michal Privoznik 提交于
We have this code in our Makefile that tries to remove /etc/libvirt/nwfilter if directory is left empty after all our example nwfilters were uninstalled. However, the check for that is missing quotation marks thus rendering the test useless: test -z allow-arp.xml allow-dhcp-server.xml .. qemu-announce-self.xml || \ rmdir "/some/path/libvirt.git/_install/etc/libvirt/nwfilter" /bin/sh: line 0: test: too many arguments Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Michal Privoznik 提交于
On BSD we are creating this symlink to libnss_libvirt.so called nss_libvirt.so. That's just the way it is on BSD. However, when uninstalling, we try to remove libnss_libvirt.so instead of the symlink. Moreover, if file we are trying to remove does not exist we error out instead of ignoring the error. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Nikolay Shirokovskiy 提交于
We don't have input devices in SDK thus for define/dumpxml operations to be consistent we need to: 1. on dumpxml: infer input devices from other parts of config. It is already done in prlsdkLoadDomain. 2. on define: check that input devices are the same that will be infer back on dumpxml operation. The second part should be fixed. Signed-off-by: NNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
-
由 Nikolay Shirokovskiy 提交于
It is on par with prlsdkLoadDomain actions. Signed-off-by: NNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
-
由 Simon Arlott 提交于
The VM does not need read permission for its own VNC socket to create(), bind(), accept() connections or to receive(), send(), etc. on connections. https://bugzilla.redhat.com/show_bug.cgi?id=1312573
-
由 Cole Robinson 提交于
Remove all the plumbing needed for the different qcow-create/kvm-img non-raw file creation. We can drop the error messages because CreateQemuImg will thrown an error for us but with slightly less fidelity (unable to find qemu-img), which I think is acceptable given the unlikeliness of that error in practice.
-
由 Cole Robinson 提交于
This an ubuntu/debian packaging convention. At one point it may have been an actually different binary, but at least as of ubuntu precise (the oldest supported ubuntu distro, released april 2012) kvm-img is just a symlink to qemu-img for back compat. I think it's safe to drop support for it
-
由 Cole Robinson 提交于
qcow-create was a crippled qemu-img impl that shipped with xen. I think supporting this was only relevant for really old distros that didn't have a proper qemu package, like early RHEL5. I think it's fair to drop support
-
由 Cole Robinson 提交于
virsh vol-clone is expected to clone a volume within a single pool; it doesn't work for cloning across pools. Clarify the docs https://bugzilla.redhat.com/show_bug.cgi?id=1103714
-
由 Cole Robinson 提交于
VIR_ERR_NO_SUPPORT maps to the error string this function is not supported by the connection driver and is largely only used for when a driver doesn't have any implementation for a public API. So its usage with invalid net-update requests is a bit out of place. Instead use VIR_ERR_OPERATION_UNSUPPORTED which maps to: Operation not supported And is what qemu's hotplug routines use in similar scenarios
-
由 Cole Robinson 提交于
do_open and winsock_init don't follow the naming pattern of other functions in this file. Rename them to match
-
由 Cole Robinson 提交于
This reverts commit 1e9808d3. We shouldn't advertise libvirtd.socket activation, since currently it means VM/network/... autostart won't work as expected. We tried to find a middle ground by installing the config file without an [Install] section, since systemd won't allow .socket to be enabled without one... or at least it did do that; presently on f24 it allows activating the socket quite happily. This also caused user confusion[1] Just remove the socket file. I've filed a new RFE to track coming up with a solution to the autostart problem[2], we can point users at that if there's more confusion: [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1279348 [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1326136
-
由 Andrea Bolognani 提交于
Commit 3a773c43 introduced the testCompareNetXML2XMLResult enumeration; however, in one instance the result variable was assigned a value from the very similar testCompareDocXML2XMLResult enumeration, leading to a build error. networkxml2xmltest.c:33:42: error: implicit conversion from enumeration type 'testCompareDomXML2XMLResult' to different enumeration type 'testCompareNetXML2XMLResult' [-Werror,-Wenum-conversion] testCompareNetXML2XMLResult result = TEST_COMPARE_DOM_XML2XML_RESULT_SUCCESS; ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Use the proper value (TEST_COMPARE_NET_XML2XML_RESULT_SUCCESS) instead.
-
由 Andrea Bolognani 提交于
-
由 Andrea Bolognani 提交于
Implement support for saving GIC capabilities in the cache and read them back.
-
由 Andrea Bolognani 提交于
Take the GIC capabilities stored in a virQEMUCaps instance and update a virDomainCaps instance appropriately.
-
由 Andrea Bolognani 提交于
Add information about GIC capabilities to virDomainCaps and update the formatter to include them in the XML output.
-
由 Andrea Bolognani 提交于
We need to expose GIC capabilities in the domain capabilities XML: update the schema to validate documents that contain the new information.
-
由 Andrea Bolognani 提交于
QEMU introduced the query-gic-capabilities QMP command with commit 4468d4e0f383: use the command, if available, to probe available GIC capabilities. The information obtained is stored in a virQEMUCaps instance, and will be later used to fill in a virDomainCaps instance.
-
由 Andrea Bolognani 提交于
The struct contains a single boolean field, 'supported': the meaning of this field is too generic to be limited to devices only, and in fact it's already being used for other things like loaders and OSs. Instead of trying to come up with a more generic name just get rid of the struct altogether.
-
qemu://system由 Cole Robinson 提交于
It's a fairly common error that a user tries to connect to a URI like qemu://system or qemu://session (missing a slash). This errors like: $ virsh --connect qemu://session error: failed to connect to the hypervisor error: Unable to resolve address 'session' service '16514': No address associated with hostname If you already know that the standard qemu URI has 3 slashes, that error will make it obvious enough. But new user's may not get it. There's even a RHEL support page explicitly mentioning it!: https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/Virtualization_Deployment_and_Administration_Guide/sect-Troubleshooting-Common_libvirt_errors_and_troubleshooting.html Catch this error early in libvirt.c virConnectOpen for qemu (and vbox which has similar rules https://bugzilla.redhat.com/show_bug.cgi?id=1038304
-
由 Mikhail Feoktistov 提交于
libvirt handles empty source as NULL, while vz sdk as "" thus we need a bit of conversion. Signed-off-by: NNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
-
由 Nikolay Shirokovskiy 提交于
-
由 Nikolay Shirokovskiy 提交于
Current implementation does not detect all incompatible configurations. For example if we have in vzsdk bootorder "cdrom1, cdrom0" (that is "hdb, hda" in case of ide cdroms) and cdroms do not have disk images inserted. In this case boot order check code fails to distiguish them at all as for both PrlVmDev_GetFriendlyName gives "". Well the consequences are only missing warnings but as we just have introduced all the necessary tools to face the problem - let's fix it. Signed-off-by: NNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
-
由 Nikolay Shirokovskiy 提交于
Actually using disk PrlVmDev_GetFriendlyName as id on detaching volumes is not a problem. We can only detach hard disks and these can not have empty friendly names. But upcoming update device functionality for cdroms can not use disk source as id at all as update operation typically change this same source value. Thus we will need to use cdrom bus and cdrom target name as cdrom id. So in attempt to use same id scheme for all purpuses lets fix hard disk detach function to use new id. Signed-off-by: NNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
-