1. 17 5月, 2008 2 次提交
  2. 16 5月, 2008 9 次提交
    • J
      * src/xml.c: Include "c-ctype.h". · a770c2ab
      Jim Meyering 提交于
      a770c2ab
    • J
      start using c-ctype functions · c1ee35af
      Jim Meyering 提交于
      Up to now, we've been avoiding ctype functions like isspace, isdigit,
      etc.  because they are locale-dependent.  Now that we have the c-ctype
      functions, we can start using *them*, to make the code more readable
      with changes like these:
      
      -        /* This may not work on EBCDIC. */
      -        if ((*p >= 'a' && *p <= 'z') ||
      -            (*p >= 'A' && *p <= 'Z') ||
      -            (*p >= '0' && *p <= '9'))
      +        if (c_isalnum(*p))
      
      -    while ((*cur >= '0') && (*cur <= '9')) {
      +    while (c_isdigit(*cur)) {
      
      Also, some macros in conf.c used names that conflicted with
      standard meaning of "BLANK" and "SPACE", so I've adjusted them
      to be in line with the definition of e.g., isblank.
      In addition, I've wrapped those statement macros with do {...} while (0),
      so that we can't forget the ";" after a use.  There was one like that
      already (fixed below).  The missing semicolon would mess up automatic
      indenting.
      * src/buf.c (virBufferURIEncodeString):
      * src/conf.c (IS_EOL, SKIP_BLANKS_AND_EOL, SKIP_BLANKS)
      (virConfParseLong, virConfParseValue, virConfParseName)
      (virConfParseSeparator, virConfParseStatement, IS_BLANK, IS_CHAR)
      (IS_DIGIT, IS_SPACE, SKIP_SPACES):
      * src/nodeinfo.c:
      * src/qemu_conf.c (qemudParseInterfaceXML):
      * src/qemu_driver.c (qemudDomainBlockStats):
      * src/sexpr.c:
      * src/stats_linux.c:
      * src/util.c (virParseNumber, virDiskNameToIndex):
      * src/uuid.c (hextobin, virUUIDParse):
      * src/virsh.c:
      * src/xml.c (parseCpuNumber, virParseCpuSet):
      c1ee35af
    • J
      avoid a double-free bug · 0dc23afb
      Jim Meyering 提交于
      * src/qemu_conf.c (qemudParseXML): Ensure that "obj" is either
      NULL or a valid malloc'd pointer before we might "goto error"
      where it is freed.
      0dc23afb
    • D
      Remove use of strcmp() · 65c2738e
      Daniel P. Berrange 提交于
      65c2738e
    • D
      Fixe default disk bus selection logic · 25f860dc
      Daniel P. Berrange 提交于
      25f860dc
    • D
      Support Xenner bootloader · 763a59d8
      Daniel P. Berrange 提交于
      763a59d8
    • D
      Pass -name arg to QEMU when available · 0f1b6dd0
      Daniel P. Berrange 提交于
      0f1b6dd0
    • D
      3a7b528d
    • D
      2c37f479
  3. 15 5月, 2008 11 次提交
  4. 13 5月, 2008 3 次提交
    • J
      avoid "not a string literal..." warnings · e830d525
      Jim Meyering 提交于
      * src/qemu_conf.c (qemudParseInterfaceXML): Add "%s".
      (qemudBuildCommandLine, qemudGenerateXML): Likewise.
      e830d525
    • D
    • D
      Enable libvirtd drivers to handle signals, in lxc, sigchld triggers vm cleanup · 94311de5
      David L. Leskovec 提交于
      Mon May 12 23:32:21 PST 2008 David L. Leskovec <dlesko@linux.vnet.ibm.com>
      
      	* qemud/qemud.c: get siginfo with signals, distribute to drivers that
          register a handler
      	* src/driver.h: add sighandler function to state driver table
      	* src/internal.h: define virStateSigDispatcher functions
      	* src/libvirt.c: add __virStateSigDispatcher function
      	* src/libvirt_sym.version: add __virStateSigDispatcher
      	* src/lxc_driver.c: add sig handler function, cleanup vm when sigchld
          received from container process
      	* src/qemu_driver.c: NULL for sig handler (no handler) in state driver
      	* src/remote_internal.c: NULL for sig handler (no handler) in state driver
      	* src/storage_driver.c: NULL for sig handler (no handler) in state driver
      94311de5
  5. 10 5月, 2008 1 次提交
  6. 09 5月, 2008 9 次提交
    • J
      Add new files from gnulib. · 7967662a
      Jim Meyering 提交于
      * gnulib/lib/c-ctype.c: New file.
      * gnulib/lib/c-ctype.h: Likewise.
      * gnulib/tests/test-c-ctype.c: Likewise.
      * gnulib/tests/test-vc-list-files-git.sh: Likewise.
      * gnulib/tests/test-vc-list-files-cvs.sh: Likewise.
      7967662a
    • J
      Use gnulib's c-ctype.h, not <ctype.h>. · 25534052
      Jim Meyering 提交于
      # Convert uses of isspace to c_isspace, isdigit to c_isdigit, etc.
      re=$(man isspace|grep is.....,.is|sed 's/ -.*//' \
        |tr -s ', \n' \||sed 's/^|//;s/|$//')
      git grep -l -E "$re"|grep -Ev 'Chan|gnulib' \
        |xargs perl -pi -e 's/\b('"$re"')\b/c_$1/g'
      # Remove all uses of to_uchar
      git grep -l to_uchar|xargs perl -pi -e 's/to_uchar\((.*?)\)/$1/g'
      * src/util.h (to_uchar): Remove definition.
      (TOLOWER): Remove definition.
      (__virMacAddrCompare): Use c_tolower, not TOLOWER.
      Globally:
        Where needed, change <ctype.h> to <c-ctype.h>.
        Remove unnecessary inclusion of <ctype.h>.
      Ensure the global changes are never needed again:
      * Makefile.maint (sc_avoid_ctype_macros): Prohibit use of ctype
      macros.   Recommend c-ctype.h instead.
      (sc_prohibit_c_ctype_without_use): New rule.
      (sc_prohibit_ctype_h): New rule.  Disallow use of <ctype.h>.
      25534052
    • J
      Prepare to use gnulib's c-type module. · 82892f13
      Jim Meyering 提交于
      * bootstrap: Move module list into separate variable w/less syntax.
      (modules): Add c-ctype.
      Update the following from gnulib:
      * build-aux/useless-if-before-free:
      * build-aux/vc-list-files:
      * gnulib/lib/Makefile.am:
      * gnulib/lib/getaddrinfo.h:
      * gnulib/m4/gnulib-cache.m4:
      * gnulib/m4/gnulib-comp.m4:
      * gnulib/m4/inet_ntop.m4:
      * gnulib/tests/Makefile.am:
      * gnulib/tests/test-getaddrinfo.c:
      82892f13
    • D
      autostart for running Xen domains · 5e1bd046
      Daniel Veillard 提交于
      * src/xen_unified.c src/xend_internal.c src/xend_internal.h: patch
        from Cole Robinson implementing autostart for running Xen domains
      Daniel
      5e1bd046
    • J
      sytnax-check: add a check for risky ctype macro use · eb046f9d
      Jim Meyering 提交于
      * Makefile.maint (sc_risky_ctype_macros): New rule.
      eb046f9d
    • J
      avoid one more ctype vs. sign-extension problem · b8111adf
      Jim Meyering 提交于
      * src/util.c (TOLOWER): Also convert tolower argument.
      b8111adf
    • J
      complete the previous change · 6d132b54
      Jim Meyering 提交于
      6d132b54
    • J
      add "const" and "static" attributes to file-scoped globals · 71225100
      Jim Meyering 提交于
      * src/storage_backend_fs.c (fileTypeInfo): Add "static" and two
      "const" attributes.
      (FileTypeInfo): Name the previously anonymous struct,
      so the declaration of fileTypeInfo looks more conventional.
      * src/xend_internal.c (sound_models): Mark as static, and
      as an array of "const" entries.
      
      These were relatively new additions to the list from here:
      nm src/*.o|grep ' D '
      71225100
    • D
      *** empty log message *** · 6ca76333
      David L. Leskovec 提交于
      6ca76333
  7. 08 5月, 2008 5 次提交