1. 29 9月, 2010 5 次提交
    • E
      phyp: Checking for NULL values when building new guest · ee2cb983
      Eduardo Otubo 提交于
      When creating a new gust, the function phypBuildLpar() was not
      checking for NULL values
      
      src/phyp/phyp_driver.c: check the definition arguments to avoid a segmentation
        fault in phypBuildLpar()
      ee2cb983
    • J
      configure: tweak logic flow of virtport check · 8bd11f37
      Justin Clift 提交于
      This fixes a small logic bug, where passing --without-macvtap
      on the configure line, or otherwise indicating a lack of
      support for macvtap, causes configure to bail.
      8bd11f37
    • J
      mpath: disable devmapper-multipath checking on non-linux · fc812dd9
      Justin Clift 提交于
      The configure script was breaking on MacOS X unless passed:
      
        --without-storage-mpath
      
      This patch leverages Stefan Bergers earlier work for nwfilter,
      so non-linux systems don't even attempt to build multipath.
      fc812dd9
    • S
      Rework configure logic for virtualport support · b502a6eb
      Stefan Berger 提交于
      In this patch I am reworking the logic around detecting virtual port support and requiring the libnl dependency.
      
      - It requires --with-macvtap and displays an error in case of --without-macvtap --with-virtualport.
      - It tests for availability of certain data in include files and displays an error in case the include file is not at the correct level and --with-virtualport was chosen
      - displays 'checking' messages for macvtap and virtualport support and results
      - libnl support is required when macvtap is found or requested; if libnl is not there, please supply without-macvtap
      b502a6eb
    • J
      mac os x: use awk selected by build system rather than first in path · 81e329eb
      Justin Clift 提交于
      Prior to this patch, the ChangeLog generation was hard coded to use
      "awk", when it should have been using the AWK variable set by our
      build system.
      
      This breaks compilation on a newly installed OS X system, where the
      default path has the Mac (non GNU) awk in the default search PATH
      before any installed GNU awk (gawk).
      81e329eb
  2. 28 9月, 2010 4 次提交
  3. 27 9月, 2010 1 次提交
  4. 25 9月, 2010 1 次提交
    • S
      nwfilter: report if ip(6)tables rules would not be active · 570d0404
      Stefan Berger 提交于
      The patch below reports a warning in the log if the generated ip(6)tables rules would not be effective due to the proc filesystem entries
      
          /proc/sys/net/bridge/bridge-nf-call-iptables
          /proc/sys/net/bridge/bridge-nf-call-ip6tables
      
      containing a '0'. The warning tells the user what to do. I am rate-limiting the warning message to appear only every 10 seconds.
      570d0404
  5. 24 9月, 2010 3 次提交
  6. 23 9月, 2010 7 次提交
    • P
      Fix spelling of Xen in comments · 4dfde8cd
      Philipp Hahn 提交于
      4dfde8cd
    • E
      maint: update to latest gnulib · 76d87a59
      Eric Blake 提交于
      * .gnulib: Update to latest.
      * bootstrap.conf (gnulib_modules): Add new termios module.
      (gnulib_tool_option_extras): Make libtool usage explicit.
      * src/util/util.c (includes): Gnulib now guarantees termios.h.
      * bootstrap: Resync from gnulib.
      76d87a59
    • M
      esx: Allow '-' in VMX entry names · 0f9c2460
      Matthias Bolte 提交于
      Add a test for this.
      
      Reported by Frank Dirks.
      0f9c2460
    • C
      pciFindStubDriver should return NULL on error · 12172d18
      Chris Wright 提交于
      pciFindStubDriver currently returns 0 in one of the error cases.
      While it's correct...NULL is more readable.
      Signed-off-by: NChris Wright <chrisw@redhat.com>
      12172d18
    • J
      libvirt-guests: start late and stop early · c5acd376
      Jiri Denemark 提交于
      libvirt-guests init script should be started as late as possible during
      host startup and stopped as early as possible during host shutdown to
      make sure required services are already/still up and running at the time
      libvirt-guests runs.
      c5acd376
    • D
      Make SASL work over UNIX domain sockets · 3a73eaeb
      Daniel P. Berrange 提交于
      The addrToString methods were not coping with UNIX domain sockets
      which have no normal host+port address. Hardcode special handling
      for these so that SASL routines can work over UNIX sockets. Also
      fix up SSF logic in remote client so that it presumes that a UNIX
      socket is secure
      
      * daemon/remote.c: Fix addrToString for UNIX sockets.
      * src/remote/remote_driver.c: Fix addrToString for UNIX sockets
        and fix SSF logic to work for TLS + UNIX sockets in the same
        manner
      3a73eaeb
    • D
      Refactor some daemon code to facilitate introduction of static probes · e8066d53
      Daniel P. Berrange 提交于
      Refactor some daemon code to facilitate the introductioin of static
      probes, sanitizing function exit paths in many places
      
      * daemon/libvirtd.c: Pass the dname string into remoteCheckDN
        to let caller deal with failure paths. Add separate exit paths
        to remoteCheckCertificate for auth failure vs denial. Merge
        all exit paths in qemudDispatchServer to one cleanup block
      * daemon/remote.c: Add separate exit paths to SASL & PolicyKit
        functions for auth failure vs denial
      e8066d53
  7. 22 9月, 2010 2 次提交
  8. 17 9月, 2010 2 次提交
    • E
      tests: silence qemuargv2xmltest noise · 9e3525df
      Eric Blake 提交于
      Before this patch, the testsuite was noisy:
      
      TEST: qemuargv2xmltest
            ........................................ 40
            ................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace
      20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
      .                        57  OK
      PASS: qemuargv2xmltest
      
      It's not a real failure (which is why the test was completing
      successfully), so much as an intentional warning to the user that use
      of the qemu namespace has the potential for undefined effects that
      leaked through the default logging behavior.  After this patch series,
      all tests can access any logged data, and this particular test can
      explicitly check for the presence or absence of the warning, such that
      the test output becomes:
      
      TEST: qemuargv2xmltest
            ........................................ 40
            .................                        57  OK
      PASS: qemuargv2xmltest
      
      * tests/testutils.h (virtTestLogContentAndReset): New prototype.
      * tests/testutils.c (struct virtTestLogData): New struct.
      (virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset):
      New functions.
      (virtTestMain): Always capture log data emitted during tests.
      * tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
      Use flag to mark which tests expect noisy stderr.
      (testCompareXMLToArgvFiles): Add parameter to test whether stderr
      was appropriately silent.
      9e3525df
    • E
      tests: clean up qemuargv2xmltest · 10c59280
      Eric Blake 提交于
      Since commit 107a7bd0, the extraFlags argument was unused.
      
      * tests/qemuargv2xmltest.c (DO_TEST): Drop extraFlags argument.
      Adjust all callers.
      10c59280
  9. 16 9月, 2010 5 次提交
  10. 14 9月, 2010 5 次提交
    • E
      maint: silence warning from libtool · 8a93dafc
      Eric Blake 提交于
      I got tired of seeing this.
      
      config.status: executing libtool commands
      /bin/rm: cannot remove `libtoolT': No such file or directory
      config.status: executing po-directories commands
      
      While I was at it, there were a couple other unused variables.
      
      * configure.ac (RM, MV, TAR): Drop; nothing in libvirt directly uses
      this, and assigning RM interferes with libtool.
      8a93dafc
    • S
      Rebuild network filter for UML guests on updates · 38ba6e16
      Soren Hansen 提交于
      When nwfilter support was added to UML, I didn't realise the UML driver
      needed instrumentation to make updating nwfilters on the fly work. This
      patch adds this bit of glue.
      Signed-off-by: NSoren Hansen <soren@linux2go.dk>
      38ba6e16
    • J
      virsh: Use virBuffer for generating XML · fc3247f2
      Jiri Denemark 提交于
      cmdAttachInterface and cmdAttachDisk still used vshRealloc and sprintf
      for generating XML, which is hardly maintainable. Let's get rid of this
      old code.
      fc3247f2
    • E
      build: use portable sed expressions · 249a5b35
      Eric Blake 提交于
      * src/Makefile.am (libvirt.def, libvirt_qemu.def): '\}' and '\t'
      are not required by POSIX.  Use '}' and literal tab instead.
      (install-data-local): Avoid sed -i.
      * tests/read-bufsiz: Likewise.
      Reported by Mitchell Hashimoto.
      249a5b35
    • J
      docs: improve wording for the dev guide · 3b167dfa
      Justin Clift 提交于
      Wording tweak suggested by David Jorm, author of the libvirt App Dev Guide.
      3b167dfa
  11. 13 9月, 2010 1 次提交
  12. 10 9月, 2010 4 次提交
    • J
      docs: add the app dev guide · 7ebe2149
      Justin Clift 提交于
      Added a workable initial page for the libvirt Application
      Development Guide, giving the online viewable options +
      the available download ones (pdf, epub, srpm).
      
      Added a link to the PDF to the main Downloads page, plus
      neatened the html tags throughout the page as they
      were a bit of a mess.
      
      Added --enable-compile-warnings=error to the autogen line,
      as suggested by Eric Blake.
      7ebe2149
    • D
      Libvirt release 0.8.4 · 9a8e152f
      Daniel Veillard 提交于
      update news, spec and french localizaton
      9a8e152f
    • C
      buf: Fix possible infinite loop in EscapeString, VSnprintf · 18af6f4e
      Cole Robinson 提交于
      The current code will go into an infinite loop if the printf generated
      string is >= 1000, AND exactly 1 character smaller than the amount of free
      space in the buffer. When this happens, we are dropped into the loop body,
      but nothing will actually change, because count == (buf->size - buf->use - 1),
      and virBufferGrow returns unchanged if count < (buf->size - buf->use)
      
      Fix this by removing the '- 1' bit from 'size'. The *nprintf functions handle
      the NULL byte for us anyways, so we shouldn't need to manually accommodate
      for it.
      
      Here's a bug where we are actually hitting this issue:
      https://bugzilla.redhat.com/show_bug.cgi?id=602772
      
      v2: Eric's improvements: while -> if (), remove extra va_list variable,
          make sure we report buffer error if snprintf fails
      
      v3: Add tests/virbuftest which reproduces the infinite loop before this
          patch, works correctly after
      18af6f4e
    • G
      Fix block statistics with newer versions of Xen · 8a70113a
      Guido Günther 提交于
      Apparently the xen block device statistics moved from
      "/sys/devices/xen-backend/vbd-%d-%d/statistics/%s"
      to
      "/sys/bus/xen-backend/devices/vbd-%d-%d/statistics/%s"
      
      * src/xen/block_stats.c: try the extra path in case of failure to
        find the statistics in /sys
      8a70113a