1. 09 5月, 2017 10 次提交
    • M
      eb18683f
    • M
      util: Remove virsysfs and instead enhance virFileReadValue* functions · 7008e108
      Martin Kletzander 提交于
      It is no longer needed thanks to the great virfilewrapper.c.  And this
      way we don't have to add a new set of functions for each prefixed
      path.
      
      While on that, add two functions that weren't there before, string and
      scaled integer reading ones.  Also increase the length of the string
      being read by one to accompany for the optional newline at the
      end (i.e. change INT_STRLEN_BOUND to INT_BUFSIZE_BOUND).
      Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>
      7008e108
    • M
      tests: Add virfilewrapper -- the new super "mock" · ae60ea48
      Martin Kletzander 提交于
      This mock (which is actually not mock at all, see later) can redirect
      all accesses to a path into another path.  There is no need to
      create mocks for particular directories, you just create a directory
      with all the data a redirect the test there.
      
      In the future, this should also be able to register callbacks for
      calls/paths, e.g. when the test is going to write into anything under
      "/sys/devices", call function fce();  Then in the open() call we would
      add information about the fd into some structure and in write() we
      would call fce() with parameters like @path to write to, @data to
      be written and pointer to optional return value, so that fce() itself
      could stop the call from happening or change its behaviour.  But
      that's an idea for a latter day.
      
      This is not a mock because it will not be preloaded, but compiled in
      the test itself.  See future patches for usage.
      Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>
      ae60ea48
    • E
      mdev: Cleanup code after commits @daf5081b and @2739a983 · 8fc72e1c
      Erik Skultety 提交于
      So, because mingw is somehow OK with dereferencing a pointer within a
      VIR_DEBUG macro, compared to outside of it to which it complained with a
      "potential NULL pointer dereference" error (still a false positive), we
      can make the code a tiny bit cleaner.
      Sighed-by: NErik Skultety <eskultet@redhat.com>
      Signed-off-by: NErik Skultety <eskultet@redhat.com>
      8fc72e1c
    • D
      Don't use ceph-devel on Fedora · 47275940
      Daniel P. Berrange 提交于
      A previous commit changed the spec to use librbd1-devel on
      RHEL-7, since this replaces ceph-devel from RHEL-6:
      
        commit 6cfc8834
        Author: Peter Krempa <pkrempa@redhat.com>
        Date:   Thu Mar 5 11:40:54 2015 +0100
      
          spec: Enable RBD storage driver in RHEL-7
      
          Use correct package names too as they differ.
      
      RHEL-7 inherited this rename from Fedora though, so it should
      have also made Fedora use the new names.
      
      This was missed, because Fedora still provides a (deprecated)
      back-compat RPM for ceph-devel that just pulls in librbd1-devel
      (and others).
      
      Fixing this stops libvirt pulling Java into the build root in
      Fedora.
      Reviewed-by: NPavel Hrdina <phrdina@redhat.com>
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      47275940
    • A
      HACKING: Document developer tooling · 1b461815
      Andrea Bolognani 提交于
      Advertise some of the useful developer tooling libvirt
      integrates with out of the box.
      1b461815
    • A
      Add YouCompleteMe support · 64b474a8
      Andrea Bolognani 提交于
      YouCompleteMe[1] is a vim plugin that implements semantic
      code completion using libclang.
      
      For non-trivial projects such as libvirt, the plugin needs
      some help figuring out where to find the various header
      files: generate its configuration file at configure time
      so that the plugin works out of the box.
      
      [1] http://valloric.github.io/YouCompleteMe/
      64b474a8
    • A
      Add color_coded support · a50dee9f
      Andrea Bolognani 提交于
      color_coded[1] is a vim plugin that implements semantic
      syntax highlighting using libclang.
      
      For non-trivial projects such as libvirt, the plugin needs
      some help figuring out where to find the various header
      files: generate its configuration file at configure time
      so that the plugin works out of the box.
      
      [1] https://github.com/jeaye/color_coded
      a50dee9f
    • E
      Post-release version bump to 3.4.0 · ca719455
      Erik Skultety 提交于
      Signed-off-by: NErik Skultety <eskultet@redhat.com>
      ca719455
    • D
      configure: enforce presence of python for build · 42c7b9e5
      Daniel P. Berrange 提交于
      The API docs extractor, ESX code generator and keycodemapdb tools
      rely on python. Historically every platform that this present, but
      with switch to Python3 by default, we're increasingly seeing
      installs without a /usr/bin/python.
      
      This tightens up the check during configure, so it exits immediately
      if python is missing, rather than leaving an empty $(PYTHON) make
      variable which leads to more obscure errors later.
      
      Also add it as a build dep for Mingw, since Fedora build roots no
      longer get python2 by default. This was not previously a major
      problem, since both ESX & API generated files were included in
      EXTRA_DIST, but the keycodemapdb generated files are not, so we
      require python all the time now.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      42c7b9e5
  2. 06 5月, 2017 1 次提交
  3. 05 5月, 2017 1 次提交
    • M
      virNWFilterObjListFree: Don't leak nwfilters->objs · 772e4247
      Michal Privoznik 提交于
      When adding a nwfilter onto the list in
      virNWFilterObjListAssignDef() this array is re-allocated to match
      demand for new size. However, it is never freed leading to a
      leak:
      
      ==26535== 136 bytes in 1 blocks are definitely lost in loss record 1,079 of 1,250
      ==26535==    at 0x4C2E2BE: realloc (vg_replace_malloc.c:785)
      ==26535==    by 0x54BA28E: virReallocN (viralloc.c:245)
      ==26535==    by 0x54BA384: virExpandN (viralloc.c:294)
      ==26535==    by 0x54BA657: virInsertElementsN (viralloc.c:436)
      ==26535==    by 0x55DB011: virNWFilterObjListAssignDef (virnwfilterobj.c:362)
      ==26535==    by 0x55DB530: virNWFilterObjListLoadConfig (virnwfilterobj.c:503)
      ==26535==    by 0x55DB635: virNWFilterObjListLoadAllConfigs (virnwfilterobj.c:539)
      ==26535==    by 0x2AC5A28B: nwfilterStateInitialize (nwfilter_driver.c:250)
      ==26535==    by 0x5621C64: virStateInitialize (libvirt.c:770)
      ==26535==    by 0x124379: daemonRunStateInit (libvirtd.c:881)
      ==26535==    by 0x554AC78: virThreadHelper (virthread.c:206)
      ==26535==    by 0x8F5F493: start_thread (in /lib64/libpthread-2.23.so)
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
      772e4247
  4. 04 5月, 2017 6 次提交
  5. 03 5月, 2017 10 次提交
    • M
      qemuDomainDetachDeviceUnlink: Don't unlink files we haven't created · 2f0b3b10
      Michal Privoznik 提交于
      Even though there are several checks before calling this function
      and for some scenarios we don't call it at all (e.g. on disk hot
      unplug), it may be possible to sneak in some weird files (e.g. if
      domain would have RNG with /dev/shm/some_file as its backend). No
      matter how improbable, we shouldn't unlink it as we would be
      unlinking a file from the host which we haven't created in the
      first place.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: NCedric Bosdonnat <cbosdonnat@suse.com>
      2f0b3b10
    • M
      qemuDomainAttachDeviceMknodRecursive: Don't try to create devices under preserved mount points · b3418f36
      Michal Privoznik 提交于
      Just like in previous commit, this fixes the same issue for
      hotplug.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: NCedric Bosdonnat <cbosdonnat@suse.com>
      b3418f36
    • M
      qemuDomainCreateDeviceRecursive: Don't try to create devices under preserved mount points · e30dbf35
      Michal Privoznik 提交于
      While the code allows devices to already be there (by some
      miracle), we shouldn't try to create devices that don't belong to
      us. For instance, we shouldn't try to create /dev/shm/file
      because /dev/shm is a mount point that is preserved. Therefore if
      a file is created there from an outside (e.g. by mgmt application
      or some other daemon running on the system like vhostmd), it
      exists in the qemu namespace too as the mount point is the same.
      It's only /dev and /dev only that is different. The same
      reasoning applies to all other preserved mount points.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: NCedric Bosdonnat <cbosdonnat@suse.com>
      e30dbf35
    • M
      qemuDomainCreateDeviceRecursive: pass a structure instead of bare path · 26c14be8
      Michal Privoznik 提交于
      Currently, all we need to do in qemuDomainCreateDeviceRecursive() is to
      take given @device, get all kinds of info on it (major & minor numbers,
      owner, seclabels) and create its copy at a temporary location @path
      (usually /var/run/libvirt/qemu/$domName.dev), if @device live under
      /dev. This is, however, very loose condition, as it also means
      /dev/shm/* is created too. Therefor, we will need to pass more arguments
      into the function for better decision making (e.g. list of mount points
      under /dev). Instead of adding more arguments to all the functions (not
      easily reachable because some functions are callback with strictly
      defined type), lets just turn this one 'const char *' into a 'struct *'.
      New "arguments" can be then added at no cost.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: NCedric Bosdonnat <cbosdonnat@suse.com>
      26c14be8
    • M
      qemuDomainBuildNamespace: Move /dev/* mountpoints later · a7cc039d
      Michal Privoznik 提交于
      When setting up mount namespace for a qemu domain the following
      steps are executed:
      
      1) get list of mountpoints under /dev/
      2) move them to /var/run/libvirt/qemu/$domName.ext
      3) start constructing new device tree under /var/run/libvirt/qemu/$domName.dev
      4) move the mountpoint of the new device tree to /dev
      5) restore original mountpoints from step 2)
      
      Note the problem with this approach is that if some device in step
      3) requires access to a mountpoint from step 2) it will fail as
      the mountpoint is not there anymore. For instance consider the
      following domain disk configuration:
      
          <disk type='file' device='disk'>
            <driver name='qemu' type='raw'/>
            <source file='/dev/shm/vhostmd0'/>
            <target dev='vdb' bus='virtio'/>
            <address type='pci' domain='0x0000' bus='0x00' slot='0x0a' function='0x0'/>
          </disk>
      
      In this case operation fails as we are unable to create vhostmd0
      in the new device tree because after step 2) there is no /dev/shm
      anymore. Leave aside fact that we shouldn't try to create devices
      living in other mountpoints. That's a separate bug that will be
      addressed later.
      
      Currently, the order described above is rearranged to:
      
      1) get list of mountpoints under /dev/
      2) start constructing new device tree under /var/run/libvirt/qemu/$domName.dev
      3) move them to /var/run/libvirt/qemu/$domName.ext
      4) move the mountpoint of the new device tree to /dev
      5) restore original mountpoints from step 3)
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: NCedric Bosdonnat <cbosdonnat@suse.com>
      a7cc039d
    • A
      news: Add more v3.3.0 entries · 624bc926
      Andrea Bolognani 提交于
      These entries cover a number of features, improvements and
      bug fixes that had not been documented during the development
      cycle.
      624bc926
    • A
      news: Tweak existing v3.3.0 entries · 0d309813
      Andrea Bolognani 提交于
      Some of the content was not following the (loosely established)
      style, and some of the XML was not aligned properly.
      0d309813
    • J
      client: Report proper close reason · 42faf316
      Jiri Denemark 提交于
      When we get a POLLHUP or VIR_EVENT_HANDLE_HANGUP event for a client, we
      still want to read from the socket to process any accumulated data. But
      doing so inevitably results in an error and a call to
      virNetClientMarkClose before we get to processing the hangup event (and
      another call to virNetClientMarkClose). However the close reason passed
      to the second virNetClientMarkClose call is ignored because another one
      was already set. We need to pass the correct close reason when marking
      the socket to be closed for the first time.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1373859Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
      42faf316
    • J
      qemu: Fix persistent migration of transient domains · 59307fad
      Jiri Denemark 提交于
      While fixing a bug with incorrectly freed memory in commit
      v3.1.0-399-g5498aa29, I accidentally broke persistent migration of
      transient domains. Before adding qemuDomainDefCopy in the path, the code
      just took NULL from vm->newDef and used it as the persistent def, which
      resulted in no persistent XML being sent in the migration cookie. This
      scenario is perfectly valid and the destination correctly handles it by
      using the incoming live definition and storing it as the persistent one.
      
      After the mentioned commit libvirtd would just segfault in the described
      scenario.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1446205Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
      59307fad
    • D
      Fix padding of encrypted data · 71890992
      Daniel P. Berrange 提交于
      If we are encoding a block of data that is 16 bytes in length,
      we cannot leave it as 16 bytes, we must pad it out to the next
      block boundary, 32 bytes. Without this padding, the decoder will
      incorrectly treat the last byte of plain text as the padding
      length, as it can't distinguish padded from non-padded data.
      
      The problem exhibited itself when using a 16 byte passphrase
      for a LUKS volume
      
        $ virsh secret-set-value 55806c7d-8e93-456f-829b-607d8c198367 \
             $(echo -n 1234567812345678 | base64)
        Secret value set
      
        $ virsh start demo
        error: Failed to start domain demo
        error: internal error: process exited while connecting to monitor: >>>>>>>>>>Len 16
        2017-05-02T10:35:40.016390Z qemu-system-x86_64: -object \
          secret,id=virtio-disk1-luks-secret0,data=SEtNi5vDUeyseMKHwc1c1Q==,\
          keyid=masterKey0,iv=zm7apUB1A6dPcH53VW960Q==,format=base64: \
          Incorrect number of padding bytes (56) found on decrypted data
      
      Notice how the padding '56' corresponds to the ordinal value of
      the character '8'.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      71890992
  6. 02 5月, 2017 2 次提交
  7. 28 4月, 2017 10 次提交