Use virTrimSpaces instead of a custom implementation.

Also use the more common "Unable to initialize mutex" string
and virReportSystemError instead of virStrerror.

They are no longer used.

Open code the call to udev_device_get_sysattr_value
in the one place where it's needed.

Callers only check for an error or a specific integer value.

The callers only care for an error, and a missing attribute
is simply NULL.

Most of the code paths free it right after converting it to
an integer.

We only care about the failure, not a missing property.

There is no need to differentiate between PROPERTY_FOUND
and PROPERTY_MISSING - we can just look if the string is non-NULL.

Historically, we added heads=1 to videos, but for example for qxl, we
did not reflect that on the command line.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1283207Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>

Add capabilities for both qxl and qxl-vga devices.
Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>

Error out on parsing errors and use a local const char pointer
instead of chained ifs to check whether we found a match.

Since the switch to VIR_STRDUP this function returns 1 on success,
but the caller treats any non-zero value as failure.

Use udevHasDeviceProperty instead of udevGetStringProperty.
We do not need to copy the string since we do not need it.

Also add braces around the if body, since the change made
syntax check complain.

Two out of three callers free it right after converting it to a number.

Also change the comment at the beginning of the function, because
the comment inside the function told me to.

Open code the error message.

Remove the debug message, open code the error in the two udevGetUint
callers and use a more specific error in SCSI and PCI processing.

The wrapper adds an error message or a debug log.

Since we already log the properties we get from udev as strings,
there is no much use for the debug logs.

Open code the error message and delete the function.

Use virStrToLong_ui instead of udevStrToLong_ui, reformat the code
and report a more specific error message.

Instead of separating it into STRPEFIX and str + strlen.

A variable without use is pointless.

Remove it, since we have no use for it.

If we have not allocated driver yet, there is nothing to cleanup.

Remove the ret variable and return early if there is no driver.

This will simplify cleanup.

Move pci_system_init and pci_system_cleanup into separate functions,
to make the conditional compilation easier to read.

Most of the code paths had to reset it to -1 and returning 0 was
only possible if we made it to the end of the function.

Initialize it to -1 and only set it to 0 if we reach the end, as we do
in most of libvirt code.

The sd_notify method is used to tell systemd when libvirtd
has finished starting up. All it does is send a datagram
containing the string parameter to systemd on a UNIX socket
named in the NOTIFY_SOCKET environment variable. Rather than
pulling in the systemd libraries for this, just code the
notification directly in libvirt as this is a stable ABI
from systemd's POV which explicitly allows independant
implementations:

See "Reimplementable Independently" column in the
"$NOTIFY_SOCKET Daemon Notifications" row:

https://www.freedesktop.org/wiki/Software/systemd/InterfacePortabilityAndStabilityChart/

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1314881Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Move the module from qemu_command.c to a new module virqemu.c and
rename the API to virQEMUBuildObjectCommandline.

This API will then be shareable with qemu-img and the need to build
a security object for luks support.
Signed-off-by: NJohn Ferlan <jferlan@redhat.com>

Create helper virStorageBackendCreateQemuImgSetInput to set the input
Signed-off-by: NJohn Ferlan <jferlan@redhat.com>

Split out a helper from virStorageBackendCreateQemuImgCmdFromVol
to check the encryption - soon a new encryption sheriff will be
patroling and that'll mean all sorts of new checks.
Signed-off-by: NJohn Ferlan <jferlan@redhat.com>

Split the qcow setting of encryption secrets into a helper
Signed-off-by: NJohn Ferlan <jferlan@redhat.com>

Bring style more in line with more recent code.
Signed-off-by: NJohn Ferlan <jferlan@redhat.com>

I was asked the other day what's event loop and how libvirt uses
it. Well, I haven't found any good sources on the Internet so I
thought of writing the documentation on my own.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>

Remove the live attribute and mark the definition as transient
whether the domain is runing or not.

There were only two callers left calling with live=false:
* testDomainStartState, where the domain already is active
  because we assigned vm->def->id just a few lines above the call
* virDomainObjGetPersistentDef, which now only calls
  virDomainObjSetDefTransient for an active domain

Calling virDomainObjSetDefTransient with live=false is a no-op
on an inactive domain.

Only call it on an active domain, since this is the only place using
the live bool.

Commit 45ec297d from November 2010:
    Make state driver device hotplug/update actually transient
added virDomainObjSetDefTransient calls to the domain startup
function in several drivers.

In November 2011, commit 8866eed0:
    Set aliases for LXC/UML console devices
added a call earlier in the startup function, without removing the
existing ones.

Also, in the UML driver it seems the function never did anything
useful - vm->def->id is set asynchronnously in umlNotifyEvent.
At the time of calling virDomainObjSetDefTransient with live=false,
vm->def->id was likely still -1, making the call a no-op.

* docs/news.html.in: update with 1.3.5 data