1. 20 2月, 2008 1 次提交
  2. 08 2月, 2008 4 次提交
    • M
      Fix gcc-4.3.0 "inlining failed" warning. · 3da5504e
      Mark McLoughlin 提交于
      * src/internal.h: move xstrol() variants from here ...
      
      * src/util.[ch]: ... to here and rename to virStrToLong()
      
      * src/libvirt_sym.version: export __virStrToLong_i() for
      virsh and qemud.
      
      * src/nodeinfo.c, src/stats_linux.c, src/virsh.c,
        src/xend_internal.c, qemud/qemud.c: replace xstrtol()
      calls with virStrToLong()
      
      * src/nodeinfo.h: don't include internal.h, which was only
      needed for xstrtol(), but instead include libvirt.h which
      is suffificient for the declarations in the header.
      3da5504e
    • D
      virHashRemoveSet bugfixes · e9b3bc77
      Daniel Veillard 提交于
      * src/hash.c: fix a couple of problems in virHashRemoveSet based
        on Hiroyuki Kaguchi patch and explanations.
      Daniel
      e9b3bc77
    • J
      Mark all qemudLog diagnostics for translation. · 247df6e4
      Jim Meyering 提交于
      * po/POTFILES.in: Add names of many new files.
      * Makefile.maint (err_func_re): Add qemudLog.
      Mark diagnostics with _(...).  Split some long lines.
      * qemud/qemud.c (remoteCheckCertFile, remoteInitializeGnuTLS):
      (qemudDispatchSignalEvent, qemudSetCloseExec, qemudSetNonBlock):
      (qemudWritePidFile, qemudListenUnix, remoteMakeSockets):
      (remoteListenTCP, qemudInitPaths, qemudInitialize):
      (qemudNetworkInit, remoteInitializeTLSSession, remoteCheckDN):
      (remoteCheckCertificate, remoteCheckAccess, qemudDispatchServer):
      (qemudClientReadBuf, qemudDispatchClientRead):
      (qemudClientWriteBuf, qemudDispatchClientWrite, qemudOneLoop):
      (remoteConfigGetStringList, checkType, GET_CONF_STR):
      (remoteConfigGetAuth, remoteReadConfigFile, main):
      * qemud/remote.c (remoteDispatchAuthSaslInit, remoteSASLCheckSSF):
      (remoteSASLCheckAccess, remoteDispatchAuthSaslStart):
      (remoteDispatchAuthSaslStep, remoteDispatchAuthSaslInit):
      (remoteDispatchAuthSaslStart, remoteDispatchAuthSaslStep):
      (qemudGetSocketIdentity, remoteDispatchAuthPolkit):
      * src/iptables.c (notifyRulesUpdated, MAX_FILE_LEN, iptRulesSave):
      (iptRulesReload):
      * src/qemu_conf.c (qemudExtractVersionInfo, qemudLoadConfig):
      (qemudLoadNetworkConfig, qemudScanConfigDir):
      * src/qemu_driver.c (qemudSetCloseExec, qemudSetNonBlock):
      (qemudAutostartConfigs, qemudStartup, qemudReload):
      (qemudWaitForMonitor, qemudStartVMDaemon, qemudVMData):
      (qemudShutdownVMDaemon, qemudStartNetworkDaemon):
      (qemudShutdownNetworkDaemon, qemudMonitorCommand):
      (qemudDomainUndefine, qemudNetworkUndefine):
      * src/uuid.c (virUUIDGenerate):
      * src/xm_internal.c (xenXMAttachInterface):
      247df6e4
    • J
      Remove more useless if tests before "free"-like functions. · e8ff93b4
      Jim Meyering 提交于
      * build-aux/useless-if-before-free: Rename from ...
      * build-aux/find-unnecessary-if-before-free: ... this.  Remove file.
      Also changed it so that new names are no longer hard-coded in the
      script.  Instead, they're supplied via options:
      * Makefile.cfg (useless_free_options): Define.
      Add xmlXPathFreeObject to the list of free-like functions it detects.
      * Makefile.maint (sc_avoid_if_before_free): Reflect script renaming.
      * .x-sc_avoid_if_before_free: Likewise.
      * src/openvz_conf.c (openvzParseXML): Remove useless "if"-before-free.
      * src/qemu_conf.c (qemudParseXML, qemudParseNetworkXML): Likewise.
      * src/virsh.c (cmdVNCDisplay, cmdTTYConsole, cmdDetachInterface):
      (cmdDetachDisk): Likewise.
      * src/xm_internal.c (xenXMConfigSetIntFromXPath): Likewise.
      (xenXMConfigSetStringFromXPath, xenXMParseXMLToConfig): Likewise.
      (xenXMDomainAttachDevice, xenXMAttachDisk, xenXMAttachInterface):
      (xenXMDomainDetachDevice): Likewise.
      * src/xml.c (virXPathString): Likewise.
      * tests/xmlrpctest.c (checkRequestValue): Likewise.
      e8ff93b4
  3. 07 2月, 2008 7 次提交
  4. 06 2月, 2008 3 次提交
  5. 05 2月, 2008 2 次提交
    • J
      Eliminate all uses of virBufferAdd with string literals. · fb66d5ab
      Jim Meyering 提交于
      * Makefile.maint (sc_prohibit_virBufferAdd_with_string_literal):
      New rule.
      * src/buf.h (virBufferAddLit): Define.
      * src/conf.c (virConfSaveValue): Use virBufferAddLit, in place
      of virBufferAdd everywhere possible.
      (virConfSaveEntry): Likewise.
      * src/qemu_conf.c (qemudGenerateXML, qemudGenerateNetworkXML): Likewise.
      * src/qemu_driver.c (qemudGetFeatures, qemudGetCapabilities): Likewise.
      * src/test.c (testDomainDumpXML, testNetworkDumpXML): Likewise.
      * src/xen_internal.c (xenHypervisorMakeCapabilitiesXML): Likewise.
      * src/xend_internal.c (xend_parse_sexp_desc_os): Likewise.
      (xend_parse_sexp_desc, sexpr_to_xend_topology_xml): Likewise.
      * src/xm_internal.c (xenXMDomainFormatXML, xenXMDomainPinVcpu): Likewise.
      * src/xml.c (virSaveCpuSet, virParseXenCpuTopology): Likewise.
      (virDomainParseXMLGraphicsDescImage): Likewise.
      (virDomainParseXMLGraphicsDescVFB, virDomainParseXMLOSDescHVM): Likewise.
      (virDomainParseXMLOSDescPV, virDomainParseXMLDiskDesc): Likewise.
      (virDomainParseXMLIfDesc, virDomainParseXMLDesc): Likewise.
      fb66d5ab
    • J
      Enable more checks for unmarked messages; fix violators. · ecaa6962
      Jim Meyering 提交于
      * Makefile.maint (sc_unmarked_diagnostics): Check for more functions.
      * src/conf.c (virConfParseValue): Remove trailing space in diagnostic.
      * src/libvirt.c (do_open, virDomainMigrate): Mark diagnostics.
      * src/xend_internal.c (do_connect, xenDaemonDomainDumpXMLByID): Likewise.
      (xenDaemonDomainDumpXMLByName, xenDaemonCreateLinux): Likewise.
      (xenDaemonDomainMigratePerform, xenDaemonDomainDefineXML): Likewise.
      * src/xml.c (virXPathString, virXPathNumber, virXPathLong): Likewise.
      (virXPathBoolean, virXPathNode, virXPathNodeSet): Likewise.
      (virDomainParseXMLOSDescHVM): Likewise.
      * src/xmlrpc.c (xmlRpcValueNew): Likewise.
      (xmlRpcValueUnmarshalDictElement): Likewise.
      ecaa6962
  6. 04 2月, 2008 2 次提交
  7. 31 1月, 2008 9 次提交
  8. 30 1月, 2008 4 次提交
    • D
      21416a47
    • J
      Also detect and remove unnecessary if-before-xmlXPathFreeContext. · 2367caa3
      Jim Meyering 提交于
      * build-aux/find-unnecessary-if-before-free: Update regexp.
      * src/openvz_conf.c: Remove unnecessary "if (P)"-before xmlXPathFreeContext.
      * src/qemu_conf.c: Likewise.
      * src/virsh.c: Likewise.
      * src/xm_internal.c: Likewise.
      * src/xml.c: Likewise.
      * tests/xmlrpctest.c: Likewise.
      2367caa3
    • J
      Enable the <config.h>-requiring test; fix violations · a3781881
      Jim Meyering 提交于
      Use <config.h>, not "config.h", per autoconf documentation.
      * Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable.
      * .x-sc_require_config_h: New file, to list exempted files.
      * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.
      a3781881
    • J
      Given code like if (foo) free (foo); remove the useless "if (foo) " part. · acff2d11
      Jim Meyering 提交于
      Likewise, given if (foo != NULL) free (foo); remove the useless "if" test.
      
      * proxy/libvirt_proxy.c: Remove unnecessary "if" test before free.
      * python/generator.py: Likewise.
      * qemud/qemud.c: Likewise.
      * src/buf.c: Likewise.
      * src/conf.c: Likewise.
      * src/hash.c: Likewise.
      * src/iptables.c: Likewise.
      * src/libvirt.c: Likewise.
      * src/openvz_conf.c: Likewise.
      * src/qemu_conf.c: Likewise.
      * src/qemu_driver.c: Likewise.
      * src/remote_internal.c: Likewise.
      * src/test.c: Likewise.
      * src/virsh.c: Likewise.
      * src/virterror.c: Likewise.
      * src/xen_internal.c: Likewise.
      * src/xen_unified.c: Likewise.
      * src/xend_internal.c: Likewise.
      * src/xm_internal.c: Likewise.
      * src/xml.c: Likewise.
      * src/xmlrpc.c: Likewise.
      * src/xs_internal.c: Likewise.
      * tests/testutils.c: Likewise.
      * tests/xencapstest.c: Likewise.
      * tests/xmconfigtest.c: Likewise.
      acff2d11
  9. 25 1月, 2008 2 次提交
  10. 23 1月, 2008 3 次提交
  11. 22 1月, 2008 1 次提交
  12. 21 1月, 2008 2 次提交