1. 19 8月, 2013 8 次提交
    • P
      nwfilter: Don't fail to start if DBus isn't available · e0e61b4c
      Peter Krempa 提交于
      When the daemon is compiled with firewalld support but the DBus message
      bus isn't started in the system, the initialization of the nwfilter
      driver fails even if there are fallback options.
      e0e61b4c
    • P
      virsystemd: Don't fail to start VM if DBus isn't available or compiled in · ee3db56f
      Peter Krempa 提交于
      On hosts that don't have the DBus service running or installed the new
      systemd cgroups code failed with hard error instead of falling back to
      "manual" cgroup creation.
      
      Use the new helper to check for the system bus and use the fallback code
      in case it isn't available.
      ee3db56f
    • P
      virdbus: Add virDBusHasSystemBus() · 2398dd3d
      Peter Krempa 提交于
      Some systems may not use DBus in their system. Add a method to check if
      the system bus is available that doesn't print error messages so that
      code can later check for this condition and use an alternative approach.
      2398dd3d
    • P
      virbitmaptest: Shut coverity up in case of broken test · 39d963d1
      Peter Krempa 提交于
      Coverity reported a memleak in the test added in 7efd5fd1. In case
      the code will be broken and the code will actually parse a faulty bitmap
      the resulting pointer would be leaked. Free it although that shouldn't
      ever happen.
      39d963d1
    • D
      Make max_clients in virtlockd configurable · 9f5b4b1f
      David Weber 提交于
      Each new VM requires a new connection from libvirtd to virtlockd.
      The default max clients limit in virtlockd of 20 is thus woefully
      insufficient. virtlockd sockets are only accessible to matching
      users, so there is no security need for such a tight limit. Make
      it configurable and default to 1024.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      9f5b4b1f
    • M
      docs: Discourage users to set hard_limit · 09adfdc6
      Michal Privoznik 提交于
      In one of my previous patches I am removing the hard_limit heuristic to
      guess the correct value if none set. However, it turned out, this limit
      is hard to guess even for users. We should advise them to not set the
      limit as their domains may be OOM killed. Sigh.
      09adfdc6
    • M
      qemu: Drop qemuDomainMemoryLimit · 16bcb3b6
      Michal Privoznik 提交于
      This function is to guess the correct limit for maximal memory
      usage by qemu for given domain. This can never be guessed
      correctly, not to mention all the pains and sleepless nights this
      code has caused. Once somebody discovers algorithm to solve the
      Halting Problem, we can compute the limit algorithmically. But
      till then, this code should never see the light of the release
      again.
      16bcb3b6
    • O
      storage: Update pool metadata after adding/removing/resizing volume · e0139e30
      Osier Yang 提交于
      One has to refresh the pool to get the correct pool info after
      adding/removing/resizing a volume, this updates the pool metadata
      (allocation, available) after those operation are done.
      e0139e30
  2. 18 8月, 2013 1 次提交
  3. 17 8月, 2013 7 次提交
  4. 16 8月, 2013 9 次提交
    • D
      Update polkit examples to use 'lookup' method · 7a7cb093
      Daniel P. Berrange 提交于
      Feedback from the polkit developers indicates that the
      "_detail_XXXX" attributes are a private implementation
      detail. Our examples should be recommending use of the
      "action.lookup('XXX')" method instead.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      7a7cb093
    • P
      virbitmaptest: Add test for out of bounds condition · 7efd5fd1
      Peter Krempa 提交于
      Previous patch fixed an issue where, when parsing a bitmap from the
      string, the bounds of the bitmap weren't checked. That flaw resulted into
      crashes. This test tests that case to avoid it in the future.
      7efd5fd1
    • P
      virbitmaptest: Fix function header formatting · 536d3812
      Peter Krempa 提交于
      536d3812
    • P
      virbitmap: Refactor virBitmapParse to avoid access beyond bounds of array · 47b9127e
      Peter Krempa 提交于
      The virBitmapParse function was calling virBitmapIsSet() function that
      requires the caller to check the bounds of the bitmap without checking
      them. This resulted into crashes when parsing a bitmap string that was
      exceeding the bounds used as argument.
      
      This patch refactors the function to use virBitmapSetBit without
      checking if the bit is set (this function does the checks internally)
      and then counts the bits in the bitmap afterwards (instead of keeping
      track while parsing the string).
      
      This patch also changes the "parse_error" label to a more common
      "error".
      
      The refactor should also get rid of the need to call sa_assert on the
      returned variable as the callpath should allow coverity to infer the
      possible return values.
      
      Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=997367
      
      Thanks to Alex Jia for tracking down the issue. This issue is introduced
      by commit 0fc89098.
      47b9127e
    • P
      virsh-domain: Fix memleak in cmdCPUBaseline · f4ec8616
      Peter Krempa 提交于
      https://bugzilla.redhat.com/show_bug.cgi?id=997765
      
      ==1349431== 8 bytes in 1 blocks are definitely lost in loss record 11 of 760
      ==1349431==    at 0x4C2A554: calloc (vg_replace_malloc.c:593)
      ==1349431==    by 0x4E9AA3E: virAllocN (in /usr/lib64/libvirt.so.0.1001.1)
      ==1349431==    by 0x4EF28C4: virXPathNodeSet (in /usr/lib64/libvirt.so.0.1001.1)
      ==1349431==    by 0x130B83: cmdCPUBaseline (in /usr/bin/virsh)
      ==1349431==    by 0x12C608: vshCommandRun (in /usr/bin/virsh)
      ==1349431==    by 0x12889A: main (in /usr/bin/virsh)
      f4ec8616
    • E
      maint: update gnulib submodule · 692a4fc4
      Eric Blake 提交于
      Gnulib recently patched gcc warning detection so that it does
      not treat things like -Wno-unused-command-line-argument as
      supported in gcc (treating it as supported merely resulted in
      extra verbosity when an actual compile error occurred).  It
      has also improved bootstrap to work with less hassle on OpenBSD.
      
      * .gnulib: Update to latest, in part for bootstrap and warnings
      improvements.
      * bootstrap: Resync from gnulib.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      692a4fc4
    • E
      maint: avoid bootstrap warning · 14b4b1e2
      Eric Blake 提交于
      I noticed that in a fresh checkout, autogen.sh generated the
      following output, but continued on with execution:
      
      autoreconf: running: automake --add-missing --copy --force-missing
      gnulib/tests/Makefile.am:28: TESTS was already defined in condition TRUE, which includes condition WITH_EXPENSIVE_TESTS ...
      gnulib/tests/gnulib.mk:28: ... `TESTS' previously defined here
      gnulib/tests/Makefile.am:19:   `gnulib/tests/gnulib.mk' included from here
      
      and after the run, line 28 of gnulib.mk lists GNULIB_TESTS, not TESTS.
      After more investigation, I found that it is because gnulib bootstrap
      provides two hooks, one before automake, and the other after; we used
      the one that ran after, and were then rerunning automake ourselves;
      and the warning was from the first run.  But a manual second run is
      pointless if we use the right hook in the first place.
      
      The wrong function name has been latent since commit 38c9440a, and we
      tried to work around it in commit 6cbab7c1, but it took commit 70363ea9
      to finally change output enough for me to realize the root cause.
      
      * bootstrap.conf (bootstrap_epilogue): Rename...
      (bootstrap_post_import_hook): ...so that it gets run before automake.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      14b4b1e2
    • E
      maint: fix typo for 'switch' · c53b9c3e
      Eric Blake 提交于
      * src/util/virnetdevvportprofile.c: Fix typo.
      * src/conf/domain_conf.c: Likewise.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      c53b9c3e
    • J
      libxl: unref DomainObjPrivate on error path · f0c513a6
      Jim Fehlig 提交于
      There is a potential leak of a newly created libxlDomainObjPrivate
      when subsequent allocation of the object's chrdev field fails.
      Unref the object on such an error so that it is properly disposed.
      f0c513a6
  5. 15 8月, 2013 5 次提交
  6. 14 8月, 2013 5 次提交
    • P
      virtio-rng: Remove double space in error message · 6ebdf35c
      Peter Krempa 提交于
      6ebdf35c
    • L
      network: permit upstream forwarding of unqualified DNS names · 4f595ba6
      Laine Stump 提交于
      This resolves the issue that prompted the filing of
      
        https://bugzilla.redhat.com/show_bug.cgi?id=928638
      
      (although the request there is for something much larger and more
      general than this patch).
      
      commit f3868259 disabled the
      forwarding to upstream DNS servers of unresolved DNS requests for
      names that had no domain, but were just simple host names (no "."
      character anywhere in the name). While this behavior is frowned upon
      by DNS root servers (that's why it was changed in libvirt), it is
      convenient in some cases, and since dnsmasq can be configured to allow
      it, it must not be strictly forbidden.
      
      This patch restores the old behavior, but since it is usually
      undesirable, restoring it requires specification of a new option in
      the network config. Adding the attribute "forwardPlainNames='yes'" to
      the <dns> elemnt does the trick - when that attribute is added to a
      network config, any simple hostnames that can't be resolved by the
      network's dnsmasq instance will be forwarded to the DNS servers listed
      in the host's /etc/resolv.conf for an attempt at resolution (just as
      any FQDN would be forwarded).
      
      When that attribute *isn't* specified, unresolved simple names will
      *not* be forwarded to the upstream DNS server - this is the default
      behavior.
      4f595ba6
    • R
      virt-login-shell: improve error message grammar · 11cdc424
      Ruben Kerkhof 提交于
      and wrap some long lines
      Signed-off-by: NEric Blake <eblake@redhat.com>
      11cdc424
    • L
      cpu: Add Power7+ and Power8 CPU definition in map.xml · b777a12d
      Li Zhang 提交于
      Power7+ and Power8 are supported in QEMU, so it needs to define CPUs
      in libvirt to support them.
      Signed-off-by: NLi Zhang <zhlcindy@linux.vnet.ibm.com>
      b777a12d
    • P
      doc: storage pool permission copy-paste fix · ced2e3be
      Philipp Hahn 提交于
      The description for <permissions> was copied from the storage volume
      section to the storage pool section, but the semantics are different:
      1. Currently only the "dir", "fs" and "netfs" storage pools use it.
      2. They use it only to build the final directory.
      3. A default for the storage volumes can't be set.
      Signed-off-by: NPhilipp Hahn <hahn@univention.de>
      ced2e3be
  7. 13 8月, 2013 5 次提交