Skip to content

L
libvirt

openeuler / libvirt

通知 3
Star 0
Fork 0
L
libvirt

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 05 1月, 2017 11 次提交
  3. 04 1月, 2017 12 次提交
    • P
      qemu: snapshot: Resume VM after live snapshot · 2e86c081
      由 Peter Krempa 提交于 
      Commit 4b951d1e missed the fact that the
VM needs to be resumed after a live external checkpoint (memory
snapshot) where the cpus would be paused by the migration rather than
libvirt.
      2e86c081
    • A
      HACKING: Reduce vertical whitespace · 6488a6c6
      由 Andrea Bolognani 提交于 
      When generating the plain text version of the contributor
guidelines we add a ludicrous amount of vertical whitespace
in some spots. Tweak the XSLT stylesheet and regenerate the
now much better looking file.
      6488a6c6
    • M
      qemuDomainCreateDevice: Be more careful about device path · dd78da09
      由 Michal Privoznik 提交于 
      Again, not something that I'd hit, but there is a chance in
theory that this might bite us. Currently the way we decide
whether or not to create /dev entry for a device is by marching
first four characters of path with "/dev". This might be not
enough. Just imagine somebody has a disk image stored under
"/devil/path/to/disk". We ought to be matching against "/dev/".
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      dd78da09
    • M
      qemuDomainAttachDeviceMknodHelper: Don't unlink() so often · ce01a2b1
      由 Michal Privoznik 提交于 
      Not that I'd encounter any bug here, but the code doesn't look
100% correct. Imagine, somebody is trying to attach a device to a
domain, and the device's /dev entry already exists in the qemu
namespace. This is handled gracefully and the control continues
with setting up ACLs and calling security manager to set up
labels. Now, if any of these steps fail, control jump on the
'cleanup' label and unlink() the file straight away. Even when it
was not us who created the file in the first place. This can be
possibly dangerous.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      ce01a2b1
    • M
      qemu: Handle EEXIST gracefully in qemuDomainCreateDevice · 3aae99fe
      由 Michal Privoznik 提交于 
      https://bugzilla.redhat.com/show_bug.cgi?id=1406837

Imagine you have a domain configured in such way that you are
assigning two PCI devices that fall into the same IOMMU group.
With mount namespace enabled what happens is that for the first
PCI device corresponding /dev/vfio/X entry is created and when
the code tries to do the same for the second mknod() fails as
/dev/vfio/X already exists:

2016-12-21 14:40:45.648+0000: 24681: error :
qemuProcessReportLogError:1792 : internal error: Process exited
prior to exec: libvirt: QEMU Driver error : Failed to make device
/var/run/libvirt/qemu/windoze.dev//vfio/22: File exists

Worse, by default there are some devices that are created in the
namespace regardless of domain configuration (e.g. /dev/null,
/dev/urandom, etc.). If one of them is set as backend for some
guest device (e.g. rng, chardev, etc.) it's the same story as
described above.

Weirdly, in attach code this is already handled.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      3aae99fe
    • M
      networkxml2conftest: Rename outxml to outconf · 8388b1c8
      由 Martin Kletzander 提交于 
      Just a name, I know, but it bothered me a lot since it does not refer
to XML.
Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>
      8388b1c8
    • M
      docs: Use href_base in absolute links · 6e0a1663
      由 Martin Kletzander 提交于 
      That way all links work even if you click them in a subdirectory.
Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>
      6e0a1663
    • A
      HACKING: Regenerate · d39e3b71
      由 Andrea Bolognani 提交于 
      When updating the source file in commit bd4f4d16, I forgot
that we also store the generated plain text version in git and
didn't regenerate it.

I also missed one spot that required an additional <p> tag, so
fix both mistakes in one go.
      d39e3b71
    • A
      util: Fix syntax-check · f0af48f0
      由 Andrea Bolognani 提交于 
      Commit b9cc2483 introduced a new #define but neglected
to format it properly, thus breaking syntax-check.
      f0af48f0
    • A
      docs: Add missing <p> elements · bd4f4d16
      由 Andrea Bolognani 提交于 
      Some of the <li> elements in the "General tips for contributing
patches" section were missing the corresponding inner <p> element,
so they ended up all lumped together.
      bd4f4d16
    • A
      util: Turn virFirewallAddRule() into a macro · b9cc2483
      由 Andrea Bolognani 提交于 
      Clang 3.9 refuses to compile the existing code with the
following error:

  util/virfirewall.c:425:20: error: passing an object that undergoes
                             default argument promotion to 'va_start'
                             has undefined behavior [-Werror,-Wvarargs]
      va_start(args, layer);
                     ^
  util/virfirewall.c:420:37: note: parameter of type 'virFirewallLayer'
                             is declared here
                     virFirewallLayer layer,
                                      ^

This happens because 'layer' is of type virFirewallLayer, which
is an enum type and not a standard type such as eg. void* or int.

To solve the issue, turn virFirewallAddRule() from a very thin
wrapper around virFirewallAddRuleFullV() to a macro that expands
to a call to virFirewallAddRuleFull() - itself a very thin wrapper
around the aforementioned virFirewallAddRuleFullV() - with no loss
of functionality or type safety.
      b9cc2483
    • J
      qemu: Don't assume secret provided for LUKS encryption · 7f7d9904
      由 John Ferlan 提交于 
      https://bugzilla.redhat.com/show_bug.cgi?id=1405269

If a secret was not provided for what was determined to be a LUKS
encrypted disk (during virStorageFileGetMetadata processing when
called from qemuDomainDetermineDiskChain as a result of hotplug
attach qemuDomainAttachDeviceDiskLive), then do not attempt to
look it up (avoiding a libvirtd crash) and do not alter the format
to "luks" when adding the disk; otherwise, the device_add would
fail with a message such as:

   "unable to execute QEMU command 'device_add': Property 'scsi-hd.drive'
    can't find value 'drive-scsi0-0-0-0'"

because of assumptions that when the format=luks that libvirt would have
provided the secret to decrypt the volume.

Access to unlock the volume will thus be left to the application.
      7f7d9904
  5. 02 1月, 2017 13 次提交
  7. 25 12月, 2016 1 次提交
  9. 23 12月, 2016 3 次提交