1. 06 2月, 2008 3 次提交
  2. 05 2月, 2008 2 次提交
    • J
      Eliminate all uses of virBufferAdd with string literals. · fb66d5ab
      Jim Meyering 提交于
      * Makefile.maint (sc_prohibit_virBufferAdd_with_string_literal):
      New rule.
      * src/buf.h (virBufferAddLit): Define.
      * src/conf.c (virConfSaveValue): Use virBufferAddLit, in place
      of virBufferAdd everywhere possible.
      (virConfSaveEntry): Likewise.
      * src/qemu_conf.c (qemudGenerateXML, qemudGenerateNetworkXML): Likewise.
      * src/qemu_driver.c (qemudGetFeatures, qemudGetCapabilities): Likewise.
      * src/test.c (testDomainDumpXML, testNetworkDumpXML): Likewise.
      * src/xen_internal.c (xenHypervisorMakeCapabilitiesXML): Likewise.
      * src/xend_internal.c (xend_parse_sexp_desc_os): Likewise.
      (xend_parse_sexp_desc, sexpr_to_xend_topology_xml): Likewise.
      * src/xm_internal.c (xenXMDomainFormatXML, xenXMDomainPinVcpu): Likewise.
      * src/xml.c (virSaveCpuSet, virParseXenCpuTopology): Likewise.
      (virDomainParseXMLGraphicsDescImage): Likewise.
      (virDomainParseXMLGraphicsDescVFB, virDomainParseXMLOSDescHVM): Likewise.
      (virDomainParseXMLOSDescPV, virDomainParseXMLDiskDesc): Likewise.
      (virDomainParseXMLIfDesc, virDomainParseXMLDesc): Likewise.
      fb66d5ab
    • J
      Enable more checks for unmarked messages; fix violators. · ecaa6962
      Jim Meyering 提交于
      * Makefile.maint (sc_unmarked_diagnostics): Check for more functions.
      * src/conf.c (virConfParseValue): Remove trailing space in diagnostic.
      * src/libvirt.c (do_open, virDomainMigrate): Mark diagnostics.
      * src/xend_internal.c (do_connect, xenDaemonDomainDumpXMLByID): Likewise.
      (xenDaemonDomainDumpXMLByName, xenDaemonCreateLinux): Likewise.
      (xenDaemonDomainMigratePerform, xenDaemonDomainDefineXML): Likewise.
      * src/xml.c (virXPathString, virXPathNumber, virXPathLong): Likewise.
      (virXPathBoolean, virXPathNode, virXPathNodeSet): Likewise.
      (virDomainParseXMLOSDescHVM): Likewise.
      * src/xmlrpc.c (xmlRpcValueNew): Likewise.
      (xmlRpcValueUnmarshalDictElement): Likewise.
      ecaa6962
  3. 04 2月, 2008 2 次提交
  4. 02 2月, 2008 1 次提交
  5. 01 2月, 2008 1 次提交
  6. 31 1月, 2008 9 次提交
  7. 30 1月, 2008 11 次提交
    • J
      Arrange for "make syntax-check" to pass. · 51dd1d9e
      Jim Meyering 提交于
      * .x-sc_avoid_if_before_free: Exempt ChangeLog.
      * tests/statstest.c: Include <config.h>, not "config.h".
      51dd1d9e
    • D
      21416a47
    • J
      Also detect and remove unnecessary if-before-xmlXPathFreeContext. · 2367caa3
      Jim Meyering 提交于
      * build-aux/find-unnecessary-if-before-free: Update regexp.
      * src/openvz_conf.c: Remove unnecessary "if (P)"-before xmlXPathFreeContext.
      * src/qemu_conf.c: Likewise.
      * src/virsh.c: Likewise.
      * src/xm_internal.c: Likewise.
      * src/xml.c: Likewise.
      * tests/xmlrpctest.c: Likewise.
      2367caa3
    • J
      Enable two more tests. · 1be2c8c8
      Jim Meyering 提交于
      * Makefile.cfg (local-checks-to-skip)
      [sc_cast_of_x_alloc_return_value, sc_cast_of_argument_to_free]: Enable.
      1be2c8c8
    • J
      Enable the <assert.h>-checking test; fix violations. · 2c725623
      Jim Meyering 提交于
      * Makefile.cfg (local-checks-to-skip)
      [sc_prohibit_assert_without_use]: Enable.
      * qemud/mdns.c: Don't include <assert.h>; no uses of assert here.
      * qemud/qemud.c: Likewise.
      * qemud/remote.c: Likewise.
      2c725623
    • J
      Enable the po-check test; fix violations. · 05ae9d8b
      Jim Meyering 提交于
      * Makefile.cfg (local-checks-to-skip) [po-check]: Enable.
      * po/POTFILES.in: Add three file names.  Sort.
      05ae9d8b
    • J
      Update from gnulib · bc48db57
      Jim Meyering 提交于
      * lib/poll.c: Update.
      * lib/string.in.h: Update.
      * m4/string_h.m4: Update.
      * tests/test-getaddrinfo.c: Update.
      * lib/Makefile.am: Regenerate.
      bc48db57
    • J
      Enable the <config.h>-requiring test; fix violations · a3781881
      Jim Meyering 提交于
      Use <config.h>, not "config.h", per autoconf documentation.
      * Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable.
      * .x-sc_require_config_h: New file, to list exempted files.
      * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.
      a3781881
    • J
      Enable the duplicate-"the" test; fix violations · 9e4c8fcb
      Jim Meyering 提交于
      * Makefile.cfg (local-checks-to-skip) [sc_the_the]: Enable.
      * docs/virsh.pod: Remove a duplicate "the".
      * libvirt.spec.in: Likewise.
      * virsh.1: Likewise.
      9e4c8fcb
    • J
      Add framework for code style- and syntax-checking rules. · cc337da2
      Jim Meyering 提交于
      	Almost all tests are initially disabled via the list in Makefile.cfg.
      	* Makefile.am (EXTRA_DIST): Add .x-sc_avoid_if_before_free.
      	Omit names of files that automake includes automatically.
      	* .x-sc_avoid_if_before_free: New file.
      	* build-aux/vc-list-files: Likewise.
      	* build-aux/find-unnecessary-if-before-free: Likewise.
      	* GNUmakefile, Makefile.cfg, Makefile.maint: New files.
      cc337da2
    • J
      Given code like if (foo) free (foo); remove the useless "if (foo) " part. · acff2d11
      Jim Meyering 提交于
      Likewise, given if (foo != NULL) free (foo); remove the useless "if" test.
      
      * proxy/libvirt_proxy.c: Remove unnecessary "if" test before free.
      * python/generator.py: Likewise.
      * qemud/qemud.c: Likewise.
      * src/buf.c: Likewise.
      * src/conf.c: Likewise.
      * src/hash.c: Likewise.
      * src/iptables.c: Likewise.
      * src/libvirt.c: Likewise.
      * src/openvz_conf.c: Likewise.
      * src/qemu_conf.c: Likewise.
      * src/qemu_driver.c: Likewise.
      * src/remote_internal.c: Likewise.
      * src/test.c: Likewise.
      * src/virsh.c: Likewise.
      * src/virterror.c: Likewise.
      * src/xen_internal.c: Likewise.
      * src/xen_unified.c: Likewise.
      * src/xend_internal.c: Likewise.
      * src/xm_internal.c: Likewise.
      * src/xml.c: Likewise.
      * src/xmlrpc.c: Likewise.
      * src/xs_internal.c: Likewise.
      * tests/testutils.c: Likewise.
      * tests/xencapstest.c: Likewise.
      * tests/xmconfigtest.c: Likewise.
      acff2d11
  8. 25 1月, 2008 3 次提交
  9. 24 1月, 2008 2 次提交
  10. 23 1月, 2008 3 次提交
  11. 22 1月, 2008 2 次提交
  12. 21 1月, 2008 1 次提交