1. 21 12月, 2012 7 次提交
    • L
      Support all backend serial devices for pSeries guest · da3d40c0
      Li Zhang 提交于
      Currently, it only considers PTY backend serial devices for pseries.
      It need to support all kinds of serial devices.
      
      This patch is to fix the problem which is that it doesn't work
      when specifying source type as file.
      Signed-off-by: NLi Zhang <zhlcindy@linux.vnet.ibm.com>
      da3d40c0
    • L
      Remove QEMU_CAPS_NO_ACPI capability for non-x86 platform · c4bbaaf8
      Li Zhang 提交于
      ACPI is only supported on x86 platform, PPC can't support it.
      So QEMU_CAPS_NO_ACPI shouldn't be set.
      
      This patch is to remove QEMU_CAPS_NO_ACPI capability for
      non-x86 platform.
      Signed-off-by: NLi Zhang <zhlcindy@linux.vnet.ibm.com>
      c4bbaaf8
    • L
      Set std VGA model as default model for ppc64. · 3b2e021a
      Li Zhang 提交于
      Cirrus VGA model is not supported on ppc64 currently.
      It needs to set std VGA model as the default model.
      Signed-off-by: NLi Zhang <zhlcindy@linux.vnet.ibm.com>
      3b2e021a
    • L
      Add sysinfo data and enable virSysinfoRead test case for POWER · 99c55456
      Li Zhang 提交于
      This patch is to enable virSysinfoRead test case for POWER,
      and provide sysinfo data on POWER.
      Signed-off-by: NLi Zhang <zhlcindy@linux.vnet.ibm.com>
      Reviewed-by: NViktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
      99c55456
    • L
      util: fix functions that retrieve SRIOV VF info · ac2797cf
      Laine Stump 提交于
      This patch resolves:
      
        https://bugzilla.redhat.com/show_bug.cgi?id=889319
      
      When assigning an SRIOV virtual function to a guest using "intelligent
      PCI passthrough" (<interface type='hostdev'>, which sets the MAC
      address and vlan tag of the VF before passing its info to qemu),
      libvirt first learns the current MAC address and vlan tag by sending
      an NLM_F_REQUEST message for the VF's PF (physical function) to the
      kernel via a NETLINK_ROUTE socket (see virNetDevLinkDump()); the
      response message's IFLA_VFINFO_LIST section is examined to extract the
      info for the particular VF being assigned.
      
      This worked fine with kernels up until kernel commit
      115c9b81928360d769a76c632bae62d15206a94a (first appearing in upstream
      kernel 3.3) which changed the ABI to not return IFLA_VFINFO_LIST in
      the response until a newly introduced IFLA_EXT_MASK field was included
      in the request, with the (newly introduced, of course) RTEXT_FILTER_VF
      flag set.
      
      The justification for this ABI change was that new fields had been
      added to the VFINFO, causing NLM_F_REQUEST messages to fail on systems
      with large numbers of VFs if the requesting application didn't have a
      large enough buffer for all the info. The idea is that most
      applications doing an NLM_F_REQUEST don't care about VFINFO anyway, so
      eliminating it from the response would lower the requirements on
      buffer size. Apparently, the people who pushed this patch made the
      mistaken assumption that iproute2 (the "ip" command) was the only
      package that used IFLA_VFINFO_LIST, so it wouldn't break anything else
      (and they made sure that iproute2 was fixed.
      
      The logic of this "fix" is debatable at best (one could claim that the
      proper fix would be for the applications in question to be fixed so
      that they properly sized the buffer, which is what libvirt does
      (purely by virtue of using libnl), but it is what it is and we have to
      deal with it.
      
      In order for <interface type='hostdev'> to work properly on systems
      with a kernel 3.3 or later, libvirt needs to add the afore-mentioned
      IFLA_EXT_MASK field with RTEXT_FILTER_VF set.
      
      Of course we also need to continue working on systems with older
      kernels, so that one bit of code is compiled conditionally. The one
      time this could cause problems is if the libvirt binary was built on a
      system without IFLA_EXT_MASK which was subsequently updated to a
      kernel that *did* have it. That could be solved by manually providing
      the values of IFLA_EXT_MASK and RTEXT_FILTER_VF and adding it to the
      message anyway, but I'm uncertain what that might actually do on a
      system that didn't support the message, so for the time being we'll
      just fail in that case (which will very likely never happen anyway).
      ac2797cf
    • L
      util: add missing error log messages when failing to get netlink VFINFO · 846770e5
      Laine Stump 提交于
      This patch fixes the lack of error messages when libvirt fails to find
      VFINFO in a returned netlinke response message.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=827519#c10 is an example
      of the error message that was previously logged when the
      IFLA_VFINFO_LIST object was missing from the netlink response. The
      reason for this failure is detailed in
      
         https://bugzilla.redhat.com/show_bug.cgi?id=889319
      
      Even though that root problem has been fixed, the experience of
      finding the root cause shows us how important it is to properly log an
      error message in these cases. This patch *seems* to replace the entire
      function, but really most of the changes are due to moving code that
      was previously inside an if() statement out to the top level of the
      function (the original if() was reversed and made to log an error and
      return).
      846770e5
    • J
      security: fix #endif comment in security_stack.h · 3e7890c8
      Ján Tomko 提交于
      3e7890c8
  2. 20 12月, 2012 3 次提交
    • E
      maint: formatting cleanups in buf.c · 258208e1
      Eric Blake 提交于
      * src/util/buf.c: Use consistent formatting.
      258208e1
    • E
      build: use strchr now that we can work around broken gcc · 622ceb34
      Eric Blake 提交于
      Revert the complex workaround of commit 39d91e9f, now that we have
      a nicer framework for shutting up broken gcc.
      
      * src/util/buf.c (virBufferEscape): Simplify.
      622ceb34
    • E
      build: make broken -Wlogical-op test be gcc-only · 6e148567
      Eric Blake 提交于
      Commit 8b8fcdea introduced a check for broken gcc -Wlogical-op,
      but did not guard the check against non-gcc compilers, which might
      lead to spurious failures when another compiler encounters an
      unknown pragma.  Additionally, all of our compiler warning logic
      should belong in a single file, and use cache variables to allow
      overriding the decision at configure time if necessary.
      
      * configure.ac (BROKEN_GCC_WLOGICALOP): Move...
      * m4/virt-compile-warnings.m4 (LIBVIRT_COMPILE_WARNINGS): ...here,
      and update to modern autoconf idioms.
      6e148567
  3. 19 12月, 2012 21 次提交
  4. 18 12月, 2012 9 次提交