- 21 4月, 2016 38 次提交
-
-
由 Peter Krempa 提交于
-
由 Peter Krempa 提交于
-
由 Peter Krempa 提交于
Additionally avoid initializing it after being calloced.
-
由 Peter Krempa 提交于
Additionally switch to using a common temp variable for the xml elements.
-
由 Peter Krempa 提交于
Use a single temporary variable instead shortening the code.
-
由 Peter Krempa 提交于
-
由 Peter Krempa 提交于
-
由 Peter Krempa 提交于
-
由 Peter Krempa 提交于
-
由 Peter Krempa 提交于
Rather than checking individual fields in dubious places extract them to a central point.
-
由 Andrea Bolognani 提交于
FreeBSD's sed(1) doesn't support using "\n" to insert a newline, so the installed default.xml file ends up containing a literal "n" between tags; to work around this problem, add a tr(1) invocation as suggested by the sed FAQ[1]. [1] http://sed.sourceforge.net/sedfaq4.html (4.1 c)
-
由 Michal Privoznik 提交于
Usually, we have this 'if() goto cleanup;' pattern in our new code. It is going to be useful here too. Thing is, there was a memleak. If there has been an error in virNetServerProgramSendStreamError() or virNetServerProgramSendStreamData() created message was never freed. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Michal Privoznik 提交于
After 434de30d the status values are prefixed VIR_NET_ rather than REMOTE_. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Michal Privoznik 提交于
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Michal Privoznik 提交于
This structure item is used as pure boolean. There's no need to hold whole integer for it. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Michal Privoznik 提交于
There is no need for doing that since we have a bool type. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Michal Privoznik 提交于
The stream serial number is the serial number of the RPC call that initiated a data transfer. And as such can never be negative. Moreover, when looking up internal state for a stream, the serial numbers are compared. But hey, the serial number in message header is unsigned too! Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Peter Krempa 提交于
-
由 Peter Krempa 提交于
Since commit f5d9c5d0 moved the virTypedParam stuff into libvirt-common we did not generate any docs for them and neither did we populate them into libvirt-api.xml. This broke the sanity check in libvirt python. Fix it by generating docs for libvirt-common.h too.
-
由 Peter Krempa 提交于
Some macros don't make sense to be documented at all. Add infrastructure to the web/api generator and add VIR_DEPRECATED and VIR_EXPORT_VAR as macros we should not document.
-
由 Peter Krempa 提交于
Our docs/web generator would take the complete license text and put it into the description of the file, since it depends on position of the "Author:" line. Move the author line to the top and remove the spurious emacs comment.
-
由 Andrea Bolognani 提交于
According to the autoconf manual, using '$(LN_S) -f' is not portable; remove the target explicitly beforehand to work around this limitation. Adjust some slightly awkward indentation while at it.
-
由 Cole Robinson 提交于
And document that these specific bits are done at startup time for back compat reasons
-
由 Cole Robinson 提交于
Now we can return early and save some indentation
-
由 Cole Robinson 提交于
virsh # list --all Id Name State ---------------------------------------------------- 1 test running virsh # connect frob error: Failed to connect to the hypervisor error: no connection driver available for frob virsh # list --all error: failed to connect to the hypervisor error: no valid connection error: no connection driver available for frob Seems sensible IMO to just not clear out the old connection state until the new virConnectOpen succeeds. https://bugzilla.redhat.com/show_bug.cgi?id=829160
-
由 Cole Robinson 提交于
My commit 0d157957 crashes on a URI without a scheme, like via 'virsh --connect frob' Add a check on uri->server too while we are at it, and centralize them all
-
由 Erik Skultety 提交于
Commit a8743c39 removed keepalive_required attribute from daemon, added a test case for it, but forgot to enable the test itself in virnetdaemontest. Signed-off-by: NErik Skultety <eskultet@redhat.com>
-
由 Erik Skultety 提交于
We already did this once, but somehow commit 252610f7 managed to bring the tabs back again. Signed-off-by: NErik Skultety <eskultet@redhat.com>
-
由 Erik Skultety 提交于
Commit a4746114 renamed virnetservertest to virnetdaemontest to reflect some refactor changes to virNetServer code (which moved daemon-related parts to virNetDaemon module). Moving test data from virnetserverdata to virnetdaemondata was also part of the commit, but the commit failed to clean half of the files that were copied (rather than moved). Signed-off-by: NErik Skultety <eskultet@redhat.com>
-
由 Roman Bogorodskiy 提交于
Re-do 0217089b so it does not add regression for commit c0726e07 that allowed to print help without making a connection to the daemon.
-
由 Andrea Bolognani 提交于
The autoconf documentation recommends to always use this construct when creating symbolic links with $(LN_S) to avoid unexpected behavior.
-
由 Andrea Bolognani 提交于
The current rule fails if the target already exists: cd /home/jenkins/build/libvirt/lib && \ ln -s libnss_libvirt.so.1 nss_libvirt.so.1 ln: nss_libvirt.so.1: File exists Makefile:3357: recipe for target 'install-exec-hook' failed However, all other rules concerned with installation are idempotent and will happily overwrite an existing target, so this one should as well.
-
由 Andrea Bolognani 提交于
We use $(LN_S) for creating symbolic links, but the appropriate autoconf macro was not included among the checks for external programs.
-
由 Andrea Bolognani 提交于
autotools provide those for our convenience, so let's use them everywhere instead of mixing in native command invocation.
-
由 Peter Krempa 提交于
The only place that uses it doesn't warrant a separate label.
-
由 Peter Krempa 提交于
After failing to parse the perf event list, the code would return failure without freeing the previously acquired object. Rearrange the code to avoid the problem. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1329046
-
由 Roman Bogorodskiy 提交于
Currently, if a connection URI was specified on the command line by the '-c' switch, virsh connects to it, but after connecting overrides its value with the one it tries to obtain from the VIRSH_DEFAULT_CONNECT_URI environment variable. This makes virsh connecting to the wrong URI if it disconnects from the hypervisor and then tries to reconnect, and also leaks the original connname. Fix by calling virGetEnvBlockSUID() before virshParseArgv().
-
由 Cole Robinson 提交于
The proper nwfilter docs go into full detail, but we should still have a brief bit about domain XML in the domain documentation
-
- 20 4月, 2016 2 次提交
-
-
由 Michal Privoznik 提交于
Our uninstall script is not exact counterpart of install one. Therefore we are leaving couple of files behind. This should not happen. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Michal Privoznik 提交于
While we could leave it behind as an indelible sign that libvirt has been running on host, other users might not be that fond of it. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-