Skip to content

L
libvirt

openeuler / libvirt

通知 3
Star 0
Fork 0
L
libvirt

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 12 11月, 2019 1 次提交
  3. 25 10月, 2019 2 次提交
  5. 24 10月, 2019 1 次提交
    • M
      Drop needless ret variable · 3b4df5d3
      由 Michal Privoznik 提交于 
      In few places we have the following code pattern:

  int ret;
  ... /* @ret is not accessed here */
  ret = f(...);
  return ret;

This pattern can be written less verbose:

  ...
  return f(...);

This patch was generated with following coccinelle spatch:

  @@
  type T;
  constant C;
  expression f;
  identifier ret;
  @@
  -T ret = C;
   ... when != ret
  -ret = f;
  -return ret;
  +return f;

Afterwards I needed to fix a few places, e.g. comment in
virDomainNetIPParseXML() was removed too because coccinelle
thinks it refers to @ret while in fact it doesn't. Also in few
places it replaced @ret declaration with a few spaces instead of
removing the line. But nothing terribly wrong.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
      3b4df5d3
  7. 21 10月, 2019 4 次提交
  9. 16 10月, 2019 5 次提交
  11. 15 10月, 2019 3 次提交
  13. 14 10月, 2019 1 次提交
  15. 07 10月, 2019 8 次提交
  17. 30 9月, 2019 3 次提交
  19. 27 9月, 2019 1 次提交
    • M
      qemu_monitor: s/size_t/ULL/ in qemuMonitorSave{Virtual,Physical}Memory · 9a293d33
      由 Michal Privoznik 提交于 
      As it turns out, on my 32bit ARM machine size_t is not the same
size as ULL. However, @length argument for both functions is type
of size_t but it's treated as ULL - for instance when passed to
qemuMonitorJSONMakeCommand(). The problem is that because of
"U:size" the virJSONValueObjectAddVArgs() expects an ULL argument
but on the stack there are size_t and char * arguments (which
coincidentally add up to size of ULL). So the created command has
only two arguments "val" and incorrect "size" and no "path" which
is required.

I've tried to find other occurrences of this pattern but at the
rest of places where size_t is used it tracks size of an array so
that's safe.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
ACKed-by: NPeter Krempa <pkrempa@redhat.com>
      9a293d33
  21. 25 9月, 2019 4 次提交
  23. 20 9月, 2019 4 次提交
  25. 04 9月, 2019 1 次提交
  27. 29 8月, 2019 1 次提交
  29. 23 7月, 2019 1 次提交