- 19 4月, 2013 1 次提交
-
-
由 Peter Krempa 提交于
This patch factors out the vCPU count retrieval including fallback means into vshCPUCountCollect() and removes the duplicated code to retrieve individual counts. The --current flag (this flag is assumed by default) now works also with --maximum or --active without the need to explicitly specify the state of the domain that is requested. This patch also fixes the output of "virsh vcpucount domain" on inactive domains: Before: $ virsh vcpucount domain maximum config 4 error: Requested operation is not valid: domain is not running current config 4 error: Requested operation is not valid: domain is not running After: $virsh vcpucount domain maximum config 4 current config 4 .. and for transient domains too: Before: $ virsh vcpucount transient-domain error: Requested operation is not valid: cannot change persistent config of a transient domain maximum live 3 error: Requested operation is not valid: cannot change persistent config of a transient domain current live 1 After: $ virsh vcpucount transient-domain maximum live 3 current live 1
-
- 18 4月, 2013 3 次提交
-
-
由 Peter Krempa 提交于
Using of a incorrect value for the --holdtime option was silently ignored and 0 was used. In case a negative number was used, it overflowed as the API expects a unsigned int. Fix the data type and getter function type and report errors on incorrect values.
-
由 Peter Krempa 提交于
Rename the get_integer_keycode helper to vshKeyCodeGetInt and get rid of a unneeded typecast.
-
由 Osier Yang 提交于
With this patch, include public headers in "" form is only allowed for "internal.h". And only the external tools (examples|tools|python |include/libvirt) can include the public headers in <> form.
-
- 12 4月, 2013 2 次提交
-
-
由 John Ferlan 提交于
-
由 John Ferlan 提交于
-
- 11 4月, 2013 2 次提交
-
-
由 Peter Krempa 提交于
Explicitly state that using incomplete XML definition snippets for hot-management commands may have unexpected results due to autogenerating values for some of the fields if they aren't specified explicitly.
-
由 Michal Privoznik 提交于
As of 76d9f656 we are supporting two new modes: initctl and signal. However, these are missing in help listing.
-
- 09 4月, 2013 2 次提交
-
-
-
由 Alex Jia 提交于
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=949483Signed-off-by: NAlex Jia <ajia@redhat.com>
-
- 06 4月, 2013 1 次提交
-
-
由 Eric Blake 提交于
Newer pod (hello rawhide) complains if you attempt to mix bullets and non-bullets in the same list: virsh.pod around line 3177: Expected text after =item, not a bullet As our intent was to nest an inner list, we make that explicit to keep pod happy. * tools/virsh.pod (ENVIRONMENT): Use correct pod syntax.
-
- 05 4月, 2013 3 次提交
-
-
由 Peter Krempa 提交于
This patch improves the error message after disconnecting from the hypervisor and adds the close callback operations required not to leak the callback reference.
-
由 Peter Krempa 提交于
The function is used to establish connection so it should be in the main virsh file. This movement also enables further improvements done in next patches. Note that the "connect" command has moved from the host section of virsh to the main section. It is now listed by 'virsh help virsh' instead of 'virsh help host'.
-
由 Viktor Mihajlovski 提交于
Before closing the connection we unregister the close callback to prevent a reference leak. Further, the messages on virConnectClose != 0 are a bit more specific now. Signed-off-by: NViktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
-
- 03 4月, 2013 4 次提交
-
-
由 Daniel P. Berrange 提交于
By passing the flags -z relro -z now to the linker, we can force it to resolve all library symbols at startup, instead of on-demand. This allows it to then make the global offset table (GOT) read-only, which makes some security attacks harder. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
由 Daniel P. Berrange 提交于
PIE (position independent executable) adds security to executables by composing them entirely of position-independent code (PIC. The .so libraries already build with -fPIC. This adds -fPIE which is the equivalent to -fPIC, but for executables. This for allows Exec Shield to use address space layout randomization to prevent attackers from knowing where existing executable code is during a security attack using exploits that rely on knowing the offset of the executable code in the binary, such as return-to-libc attacks. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
由 Peter Krempa 提交于
s/persitent/persistent/
-
由 Martin Kletzander 提交于
virsh schedinfo was able to set only one parameter at a time (not counting the deprecated options), but it is useful to set more at once, so this patch adds the possibility to do stuff like this: virsh schedinfo <domain> cpu_shares=0 vcpu_period=0 vcpu_quota=0 \ emulator_period=0 emulator_quota=0 Invalid scheduler options are reported as well. These were previously reported only if the command hadn't updated any values (when cmdSchedInfoUpdate returned 0). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=810078 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=919372 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=919375
-
- 02 4月, 2013 11 次提交
-
-
由 Michal Privoznik 提交于
https://bugzilla.redhat.com/show_bug.cgi?id=928197 The virsh domfstrim command was not freeing allocated domain, leaving leaked references behind.
-
由 Martin Kletzander 提交于
Descriptions for vol-download and vol-upload didn't make much sense. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=923613
-
由 Martin Kletzander 提交于
The virsh(1) man page wasn't saying anything about the 'migrateuri' parameter other than it can be usually omitted. A patched version of docs/migrate.html.in is taken in this patch to fix that up in the man page.
-
由 Peter Krempa 提交于
Use the established approach to improve this function too.
-
由 Peter Krempa 提交于
Use the established approach to improve this function too.
-
由 Peter Krempa 提交于
Use the established approach to improve this function too.
-
由 Peter Krempa 提交于
The man page states that with --config the next boot is affected. This can be understood as if _only_ the next boot was affected. This isn't true if the machine is running. This patch adds the full --live, --config, --current infrastructure and tweaks stuff to correctly support the obsolete --persistent flag. Note that this patch changes the the behavior of the --config flag to match the use of this flag in rest of libvirt. This flag was mistakenly renamed from --persistent that originaly had different semantics.
-
由 Peter Krempa 提交于
The parameter options can be declared directly. Also use macros for mutual exclusion on some of the incompatible parameter variables.
-
由 Peter Krempa 提交于
This patch uses the new helper to avoid the more complex check for domain state modification flags.
-
由 Peter Krempa 提交于
The domif-getlink command did not terminate successfully when the interface state was found. As the code used old and too complex approach to do the job, this patch refactors it and fixes the bug.
-
由 Osier Yang 提交于
The 'virsh vcpupin' and 'virsh emulatorpin' commands use the same code to parse the cpulist. This patch abstracts the same code as a helper. Along with various code style fixes, and error improvement (only error "Physical CPU %d doesn't exist" if the specified CPU exceed the range, no "cpulist: Invalid format", see the following for an example of the error prior to this patch). % virsh vcpupin 4 0 0-8 error: Physical CPU 4 doesn't exist. error: cpulist: Invalid format.
-
- 29 3月, 2013 1 次提交
-
-
由 Ján Tomko 提交于
Since the refactoring in fbe2d494 we call virSecretFree even if virSecretDefineXML fails, which leads to overwriting the error message with: error: Invalid secret: virSecretFree Bug: https://bugzilla.redhat.com/show_bug.cgi?id=929045
-
- 27 3月, 2013 2 次提交
-
-
由 Yanbing Du 提交于
Signed-off-by: NYanbing Du <ydu@redhat.com>
-
由 Ján Tomko 提交于
Some block commands and migrate ignored incorrect values. Bug: https://bugzilla.redhat.com/show_bug.cgi?id=927495
-
- 26 3月, 2013 2 次提交
-
-
由 Peter Krempa 提交于
Get rid of the "default" labels to do so.
-
由 Yanbing Du 提交于
Signed-off-by: NYanbing Du <ydu@redhat.com>
-
- 25 3月, 2013 3 次提交
-
-
由 Eric Blake 提交于
Right now, libvirt-guests gives awkward output. It's possible to force faster failure by setting /etc/sysconfig/libvirt-guests to use: ON_SHUTDOWN=shutdown PARALLEL_SHUTDOWN=0 SHUTDOWN_TIMEOUT=1 ON_BOOT=ignore at which point, we see: $ service libvirt-guests restart Running guests on default URI: a, b, d, c Shutting down guests on default URI... Starting shutdown on guest: a Shutdown of guest a failed to complete in time.Starting shutdown on guest: b Shutdown of guest b failed to complete in time.Starting shutdown on guest: d Shutdown of guest d failed to complete in time.Starting shutdown on guest: c Shutdown of guest c failed to complete in time.libvirt-guests is configured not to start any guests on boot * tools/libvirt-guests.sh.in (shutdown_guest): Add missing newline. Reported by Xuesong Zhang.
-
由 Osier Yang 提交于
VIR_CONNECT_LIST_NODE_DEVICES_CAP_FC_HOST to filter the FC HBA, and VIR_CONNECT_LIST_NODE_DEVICES_CAP_VPORTS to filter the FC HBA which supports vport.
-
由 Peter Krempa 提交于
The docs assumed the command works always for QEMU and other hypervisors. As this is done using the balloon mechainism live increase of the maximum memory limit isn't supported. Fix the docs to mention this limitation.
-
- 22 3月, 2013 1 次提交
-
-
由 Ján Tomko 提交于
Don't print the pool option name if it's null. Before: virsh # vol-name vol error: failed to get vol 'vol', specifying --(null) might help error: Storage volume not found: no storage vol with matching path vol After: virsh # vol-name vol error: failed to get vol 'vol' error: Storage volume not found: no storage vol with matching path vol Bug: https://bugzilla.redhat.com/show_bug.cgi?id=924571
-
- 21 3月, 2013 2 次提交
-
-
由 Peter Krempa 提交于
-
由 Peter Krempa 提交于
-