1. 13 2月, 2018 10 次提交
  2. 12 2月, 2018 6 次提交
    • D
      Revert "qemu: Expose rx/tx_queue_size in qemu.conf too" · 12bc2b81
      Daniel P. Berrangé 提交于
      This reverts commit 038eb472.
      
      On reflection adding defaults for arbitrary guest XML device config
      settings to the qemu.conf is not a sustainable path. Removing the
      support for rx/tx queue size so that it doesn't set a bad precedent.
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      12bc2b81
    • J
      qemu: Alter condition to avoid possible NULL deref · a1bce9ef
      John Ferlan 提交于
      Commit 'f0f2a5ec' neglected to adjust the if condition to split
      out the possibility that the @watchdog is NULL when altering the
      message to add detail about the model.
      
      Just split out the condition and use previous/original message, but
      with the new message code.
      
      Found by Coverity
      Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
      a1bce9ef
    • D
      tests: fix running of qemuxml2argvtest program · 9dac9509
      Daniel P. Berrangé 提交于
      The previous commit:
      
        commit a455d41e
        Author: Daniel P. Berrangé <berrange@redhat.com>
        Date:   Thu Jan 25 09:35:50 2018 +0000
      
          conf: expand network device callbacks to cover resolving NIC type
      
      mistakenly dropped qemuxml2argvtest from the tests due to a typo.
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      9dac9509
    • D
      log: fix deadlock obtaining hostname (related CVE-2018-6764) · c2dc6698
      Daniel P. Berrangé 提交于
      The fix for CVE-2018-6764 introduced a potential deadlock scenario
      that gets triggered by the NSS module when virGetHostname() calls
      getaddrinfo to resolve the hostname:
      
       #0  0x00007f6e714b57e7 in futex_wait
       #1  futex_wait_simple
       #2  __pthread_once_slow
       #3  0x00007f6e71d16e7d in virOnce
       #4  0x00007f6e71d0997c in virLogInitialize
       #5  0x00007f6e71d0a09a in virLogVMessage
       #6  0x00007f6e71d09ffd in virLogMessage
       #7  0x00007f6e71d0db22 in virObjectNew
       #8  0x00007f6e71d0dbf1 in virObjectLockableNew
       #9  0x00007f6e71d0d3e5 in virMacMapNew
       #10 0x00007f6e71cdc50a in findLease
       #11 0x00007f6e71cdcc56 in _nss_libvirt_gethostbyname4_r
       #12 0x00007f6e724631fc in gaih_inet
       #13 0x00007f6e72464697 in __GI_getaddrinfo
       #14 0x00007f6e71d19e81 in virGetHostnameImpl
       #15 0x00007f6e71d1a057 in virGetHostnameQuiet
       #16 0x00007f6e71d09936 in virLogOnceInit
       #17 0x00007f6e71d09952 in virLogOnce
       #18 0x00007f6e714b5829 in __pthread_once_slow
       #19 0x00007f6e71d16e7d in virOnce
       #20 0x00007f6e71d0997c in virLogInitialize
       #21 0x00007f6e71d0a09a in virLogVMessage
       #22 0x00007f6e71d09ffd in virLogMessage
       #23 0x00007f6e71d0db22 in virObjectNew
       #24 0x00007f6e71d0dbf1 in virObjectLockableNew
       #25 0x00007f6e71d0d3e5 in virMacMapNew
       #26 0x00007f6e71cdc50a in findLease
       #27 0x00007f6e71cdc839 in _nss_libvirt_gethostbyname3_r
       #28 0x00007f6e71cdc724 in _nss_libvirt_gethostbyname2_r
       #29 0x00007f6e7248f72f in __gethostbyname2_r
       #30 0x00007f6e7248f494 in gethostbyname2
       #31 0x000056348c30c36d in hosts_keys
       #32 0x000056348c30b7d2 in main
      
      Fortunately the extra stuff virGetHostname does is totally irrelevant to
      the needs of the logging code, so we can just inline a call to the
      native hostname() syscall directly.
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      c2dc6698
    • P
      qemu: command: Extract formatting of floppy related stuff into a helper · 42fd5a58
      Peter Krempa 提交于
      The floppy command formatting is special-cased since it does not
      directly translate to a single '-device' argument.
      
      Move the code from qemuBuildDiskDriveCommandLine to a new helper
      function so that all the related code is together.
      Signed-off-by: NPeter Krempa <pkrempa@redhat.com>
      42fd5a58
    • C
      qemu: don't leak in qemuGetDHCPInterfaces when failing to alloc · 60a95e52
      Chen Hanxiao 提交于
      We forgot to free alloced mem when failed to
      dup ifname or macaddr.
      
      Also use VIR_STEAL_PTR to simplify codes.
      Signed-off-by: NChen Hanxiao <chenhanxiao@gmail.com>
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      60a95e52
  3. 10 2月, 2018 4 次提交
  4. 09 2月, 2018 20 次提交