1. 14 3月, 2019 1 次提交
  2. 07 3月, 2019 3 次提交
  3. 18 12月, 2018 1 次提交
  4. 14 12月, 2018 1 次提交
    • D
      Remove all Author(s): lines from source file headers · 60046283
      Daniel P. Berrangé 提交于
      In many files there are header comments that contain an Author:
      statement, supposedly reflecting who originally wrote the code.
      In a large collaborative project like libvirt, any non-trivial
      file will have been modified by a large number of different
      contributors. IOW, the Author: comments are quickly out of date,
      omitting people who have made significant contribitions.
      
      In some places Author: lines have been added despite the person
      merely being responsible for creating the file by moving existing
      code out of another file. IOW, the Author: lines give an incorrect
      record of authorship.
      
      With this all in mind, the comments are useless as a means to identify
      who to talk to about code in a particular file. Contributors will always
      be better off using 'git log' and 'git blame' if they need to  find the
      author of a particular bit of code.
      
      This commit thus deletes all Author: comments from the source and adds
      a rule to prevent them reappearing.
      
      The Copyright headers are similarly misleading and inaccurate, however,
      we cannot delete these as they have legal meaning, despite being largely
      inaccurate. In addition only the copyright holder is permitted to change
      their respective copyright statement.
      Reviewed-by: NErik Skultety <eskultet@redhat.com>
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      60046283
  5. 20 9月, 2018 1 次提交
  6. 26 6月, 2018 1 次提交
  7. 21 6月, 2018 1 次提交
  8. 10 4月, 2018 1 次提交
  9. 30 11月, 2017 1 次提交
  10. 03 11月, 2017 1 次提交
    • A
      Remove backslash alignment attempts · 3e7db8d3
      Andrea Bolognani 提交于
      Right-aligning backslashes when defining macros or using complex
      commands in Makefiles looks cute, but as soon as any changes is
      required to the code you end up with either distractingly broken
      alignment or unnecessarily big diffs where most of the changes
      are just pushing all backslashes a few characters to one side.
      
      Generated using
      
        $ git grep -El '[[:blank:]][[:blank:]]\\$' | \
          grep -E '*\.([chx]|am|mk)$$' | \
          while read f; do \
            sed -Ei 's/[[:blank:]]*[[:blank:]]\\$/ \\/g' "$f"; \
          done
      Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
      3e7db8d3
  11. 09 5月, 2017 1 次提交
  12. 05 4月, 2017 1 次提交
    • P
      docs: Move news.rng out of docs/schemas · 8e013986
      Peter Krempa 提交于
      docs/schemas directory is meant for schemas which are installed on the
      system. The schema for the news file does not need to be installed.
      Store it along with the file it describes for simplicity.
      8e013986
  13. 04 4月, 2017 1 次提交
  14. 03 4月, 2017 2 次提交
  15. 14 12月, 2016 1 次提交
  16. 15 8月, 2016 1 次提交
    • M
      virschematest: Make sure that validator is initialized · cba18f8a
      Michal Privoznik 提交于
      It may happen that a developer wants to run just a specific
      subset of tests:
      
      tests $ VIR_TEST_RANGE=22 ../run ./virschematest
      
      This now fails miserably:
      
          ==6840== Invalid read of size 8
          ==6840==    at 0x4F397C0: virXMLValidatorValidate (virxml.c:1216)
          ==6840==    by 0x402B72: testSchemaFile (virschematest.c:53)
          ==6840==    by 0x403737: virTestRun (testutils.c:180)
          ==6840==    by 0x402CF5: testSchemaDir (virschematest.c:98)
          ==6840==    by 0x402EB1: testSchemaDirs (virschematest.c:131)
          ==6840==    by 0x40314D: mymain (virschematest.c:194)
          ==6840==    by 0x4051AF: virTestMain (testutils.c:982)
          ==6840==    by 0x4035A9: main (virschematest.c:217)
          ==6840==  Address 0x10 is not stack'd, malloc'd or (recently) free'd
      
      Problem is, we are trying to do two types of tests here: validate
      RNG schema itself, and validate XML files against RNG schemas.
      And the latter tries to re-use a resource allocated in the
      former. Therefore if the former is skipped (due to
      VIR_TEST_RANGE) we have to allocate the resource manually.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      cba18f8a
  17. 12 8月, 2016 1 次提交
    • M
      virschematest: Initialize @data · f87cc927
      Michal Privoznik 提交于
      ==8630== Invalid read of size 8
      ==8630==    at 0x4EA4F0F: virFree (viralloc.c:582)
      ==8630==    by 0x4F398F0: virXMLValidatorFree (virxml.c:1257)
      ==8630==    by 0x40305C: mymain (virschematest.c:191)
      ==8630==    by 0x405159: virTestMain (testutils.c:982)
      ==8630==    by 0x403553: main (virschematest.c:215)
      ==8630==  Address 0xcd72243 is 131 bytes inside a block of size 177 free'd
      ==8630==    at 0x4C2B1F0: free (vg_replace_malloc.c:473)
      ==8630==    by 0x4EA4F19: virFree (viralloc.c:582)
      ==8630==    by 0x4ED0973: virFindFileInPath (virfile.c:1646)
      ==8630==    by 0x405149: virTestMain (testutils.c:980)
      ==8630==    by 0x403553: main (virschematest.c:215)
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      f87cc927
  18. 02 8月, 2016 1 次提交
    • P
      tests: Make schema test fail on XML schema errors · 27bdc0af
      Peter Krempa 提交于
      Failure to parse the schema file would not trigger a test suite failure.
      
      In addition to making the test fail it's necessary to split up the
      parsing of the schema file into a separate test.
      
      This is necessary as the XML validator uses libvirt errors to report
      problems parsing of the actual schema RNG needs to be split out into a
      separate function and called via virTestRun which has the
      infrastructure to report them.
      27bdc0af
  19. 11 7月, 2016 1 次提交
  20. 24 6月, 2016 2 次提交
    • J
      Use virDirOpen · e81de04c
      Ján Tomko 提交于
      Switch from opendir to virDirOpen everywhere we need to report an error.
      e81de04c
    • J
      Introduce VIR_DIR_CLOSE · a4e6f1eb
      Ján Tomko 提交于
      Introduce a helper that only calls closedir if DIR* is non-NULL
      and sets it to NULL afterwards.
      a4e6f1eb
  21. 08 6月, 2016 4 次提交