1. 19 4月, 2013 16 次提交
    • P
      conf: Reword error message to be more universal · bcefb507
      Peter Krempa 提交于
      The error message reported when attempting to change/get persistent
      configuration of a transient domain suggests that changes are being
      made. Reword it to suit getter APIs too.
      
      Before:
      $ virsh vcpucount transient-domain --config
      error: Requested operation is not valid: cannot change persistent config of a transient domain
      
      After:
      $ virsh vcpucount transient-domain --config
      error: Requested operation is not valid: transient domains do not have any persistent config
      bcefb507
    • P
      network: bridge_driver: don't lose transient networks on daemon restart · 446dd66b
      Peter Krempa 提交于
      Until now tranisent networks weren't really useful as libvirtd wasn't
      able to remember them across restarts. This patch adds support for
      loading status files of transient networks (that already were generated)
      so that the status isn't lost.
      
      This patch chops up virNetworkObjUpdateParseFile and turns it into
      virNetworkLoadState and a few friends that will help us to load status
      XMLs and refactors the functions that are loading the configs to use
      them.
      446dd66b
    • J
      cpu: Rename PowerPCUpdate and PowerPCDataFree functions · f1a1ebf1
      Jiri Denemark 提交于
      For consistency with other functions in PowerPC CPU driver, the two
      functions are renamed as ppcUpdate and ppcDataFree, respectively.
      f1a1ebf1
    • J
      cpu: Remove hardcoded list of PowerPC models · 7a4f1238
      Jiri Denemark 提交于
      The cpu_map.xml file is there to separate CPU model definitions from the
      code. Having the only interesting data for PowerPC models only in the
      source code. This patch moves this data to the XML file and removes the
      hardcoded list completely.
      7a4f1238
    • J
      cpu: Reimplement PowerPCDecode · f42ecaf1
      Jiri Denemark 提交于
      PowerPC CPUs are either identical or incompatible and thus we just need
      to look up the right model for given PVR without pretending we have
      several candidates which we may choose from.
      
      The function is also renamed as ppcDecode to match other functions in
      PowerPC CPU driver.
      f42ecaf1
    • J
      cpu: Reimplement PowerPCBaseline · fdf6efde
      Jiri Denemark 提交于
      Baseline API is supposed to return guest CPU definition that can be used
      on any of the provided host CPUs. Since PowerPC CPUs are either
      identical or incompatible, the API just needs to check that all provided
      CPUs are identical. Previous implementation was completely bogus.
      
      The function is also renamed as ppcBaseline to match other functions in
      PowerPC CPU driver.
      fdf6efde
    • J
      cpu: Fix loading PowerPC vendor from cpu_map.xml · ba8ba247
      Jiri Denemark 提交于
      When ppcVendorLoad fails to parse the vendor element for whatever
      reason, it is supposed to ignore it and return 0 rather than -1. The
      patch also removes PowerPC vendor string from the XML as it is not
      actually used for anything.
      ba8ba247
    • J
      cpu: Fix PowerPCNodeData · 70349cb9
      Jiri Denemark 提交于
      Make getting node CPU data for PowerPC unsupported on other
      architectures. The function is also renamed as ppcNodeData to match
      other functions in PowerPC CPU driver.
      70349cb9
    • J
      cpu: Make comparing PowerPC CPUs easier to read · 6af5a062
      Jiri Denemark 提交于
      Revert the condition to make it easier to read. The function is also
      renamed as ppcCompare to match other functions in PowerPC CPU driver.
      6af5a062
    • J
      cpu: Introduce cpuModelIsAllowed internal API · 16c6b60c
      Jiri Denemark 提交于
      The API can be used to check if the model is on the supported models
      list, which needs to be done in several places.
      16c6b60c
    • P
      virsh-domain: Refactor cmdVcpucount and fix output on inactive domains · 642261a8
      Peter Krempa 提交于
      This patch factors out the vCPU count retrieval including fallback means
      into vshCPUCountCollect() and removes the duplicated code to retrieve
      individual counts.
      
      The --current flag (this flag is assumed by default) now works also with
      --maximum or --active without the need to explicitly specify the state
      of the domain that is requested.
      
      This patch also fixes the output of "virsh vcpucount domain" on inactive
      domains:
      
      Before:
      $ virsh vcpucount domain
      maximum      config         4
      error: Requested operation is not valid: domain is not running
      current      config         4
      error: Requested operation is not valid: domain is not running
      
      After:
      $virsh vcpucount domain
      maximum      config         4
      current      config         4
      
      .. and for transient domains too:
      
      Before:
      $ virsh vcpucount transient-domain
      error: Requested operation is not valid: cannot change persistent config of a transient domain
      maximum      live           3
      error: Requested operation is not valid: cannot change persistent config of a transient domain
      current      live           1
      
      After:
      $ virsh vcpucount transient-domain
      maximum      live           3
      current      live           1
      642261a8
    • L
      Set legacy USB option with default for ppc64. · 88c6159c
      Li Zhang 提交于
      Currently, -device xxx still doesn't work well for ppc64 platform.
      It's better use legacy USB option with default for ppc64.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      88c6159c
    • J
      qemu: fix default spice password setting · 4327df7e
      Ján Tomko 提交于
      Set spice password even if default VNC password hasn't been set.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=953720
      4327df7e
    • P
      78d7c3c5
    • P
      util: allow using virCommandAllowCap with setuid helpers · 5c1cfea4
      Paolo Bonzini 提交于
      When running unprivileged, virSetUIDGIDWithCaps will fail because it
      tries to add the requested capabilities to the permitted and effective
      sets.
      
      Detect this case, and invoke the child with cleared permitted and
      effective sets.  If it is a setuid program, it will get them.
      
      Some care is needed also because you cannot drop capabilities from the
      bounding set without CAP_SETPCAP.  Because of that, ignore errors from
      setting the bounding set.
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      5c1cfea4
    • P
      util: simplify virSetUIDGIDWithCaps · 65871845
      Paolo Bonzini 提交于
      The need_prctl variable is not really needed.  If it is false,
      capng_apply will be called twice with the same set, causing
      a little extra work but no problem.  This keeps the code a bit
      simpler.
      
      It is also clearer to invoke capng_apply(CAPNG_SELECT_BOUNDS)
      separately, to make sure it is done while we have CAP_SETPCAP.
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      65871845
  2. 18 4月, 2013 10 次提交
  3. 17 4月, 2013 6 次提交
    • O
      remote: Revert removing "libvirt/libvirt.h" in remote_protocol.x · f0431994
      Osier Yang 提交于
      Commit 2d25fd4f removed the including of "libvirt/libvirt.h",
      which breaks the build. Pushed under build-breaker rule.
      f0431994
    • O
      qemu: Allow the disk wwn to have "0x" prefix · 09d2547f
      Osier Yang 提交于
      The recent qemu requires "0x" prefix for the disk wwn, this patch
      changes virValidateWWN to allow the prefix, and prepend "0x" if
      it's not specified. E.g.
      
      qemu-kvm: -device scsi-hd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,\
      drive=drive-scsi0-0-0-0,id=scsi0-0-0-0,wwn=6000c60016ea71ad:
      Property 'scsi-hd.wwn' doesn't take value '6000c60016ea71ad'
      
      Though it's a qemu regression, but it's nice to allow the prefix,
      and doesn't hurt for us to always output "0x".
      09d2547f
    • O
      cleanup: Don't include libvirt/virterror.h · 5829054c
      Osier Yang 提交于
      Which is already included in "internal.h", later patch will add
      syntax-check to avoid it.
      5829054c
    • O
      cleanup: Don't include libvirt/libvirt.h · 2d25fd4f
      Osier Yang 提交于
      Which is already included by "internal.h", later patch will add
      syntax-check to avoid it.
      2d25fd4f
    • O
      cleanup: Remove the duplicate header · bc95be5d
      Osier Yang 提交于
      Detected by a simple Shell script:
      
      for i in $(git ls-files -- '*.[ch]'); do
          awk 'BEGIN {
              fail=0
          }
          /# *include.*\.h/{
              match($0, /["<][^">]*[">]/)
              arr[substr($0, RSTART+1, RLENGTH-2)]++
          }
          END {
              for (key in arr) {
                  if (arr[key] > 1) {
                      fail=1
                      printf("%d %s\n", arr[key], key)
                  }
              }
              if (fail == 1)
                  exit 1
          }' $i
      
          if test $? != 0; then
              echo "Duplicate header(s) in $i"
          fi
      done;
      
      A later patch will add the syntax-check to avoid duplicate
      headers.
      bc95be5d
    • O
      cleanup: Only include testutils.h once · 2beae9c2
      Osier Yang 提交于
      No reason to include it in both "if" and "else" branches.
      2beae9c2
  4. 16 4月, 2013 8 次提交
    • S
      Fix compilation error in util/vircgroup.c · 0cb171f6
      Stefan Berger 提交于
      Fix the error
      
      util/vircgroup.c: In function 'virCgroupNewDomainPartition':
      util/vircgroup.c:1299:11: error: declaration of 'dirname' shadows a global declaration [-Werror=shadow]
      Signed-off-by: NStefan Berger <stefanb@linux.vnet.ibm.com>
      0cb171f6
    • J
      Fix build breaker with ATTRIBUTE_NONNULL defs · d94a3cfc
      John Ferlan 提交于
      Using "./autogen.sh --system lv_cv_static_analysis=yes" for my daily
      Coverity builds resulted in the following error when building:
      
      In file included from util/vircgrouppriv.h:32:0,
                       from util/vircgroup.c:44:
      util/vircgroup.h:59:5: error: nonnull argument with out-of-range operand number (argument 1, operand 5)
      util/vircgroup.h:74:5: error: nonnull argument references non-pointer operand (argument 1, operand 4)
      make[3]: *** [libvirt_util_la-vircgroup.lo] Error 1
      make[3]: Leaving directory `/home/jferlan/libvirt.cov.curr/src'
      make[2]: *** [all] Error 2
      make[2]: Leaving directory `/home/jferlan/libvirt.cov.curr/src'
      make[1]: *** [all-recursive] Error 1
      make[1]: Leaving directory `/home/jferlan/libvirt.cov.curr'
      make: *** [all] Error 2
      d94a3cfc
    • J
      Resolve valgrind error · c3ad5a36
      John Ferlan 提交于
      Commit id '1acfc171' resulted in the following valgrind failure:
      
      ==25317== 136 (24 direct, 112 indirect) bytes in 1 blocks are definitely lost in loss record 4 of 4
      ==25317==    at 0x4A06B6F: calloc (vg_replace_malloc.c:593)
      ==25317==    by 0x4C6F851: virAlloc (viralloc.c:124)
      ==25317==    by 0x4C71493: virBitmapNew (virbitmap.c:74)
      ==25317==    by 0x4C71B79: virBitmapNewData (virbitmap.c:434)
      ==25317==    by 0x402EF2: test8 (virbitmaptest.c:436)
      ==25317==    by 0x40499F: virtTestRun (testutils.c:157)
      ==25317==    by 0x402E8D: mymain (virbitmaptest.c:474)
      ==25317==    by 0x404FDA: virtTestMain (testutils.c:719)
      ==25317==    by 0x39D0821A04: (below main) (in /usr/lib64/libc-2.16.so)
      c3ad5a36
    • S
      Check for unsupported QMP command · 8b934a5c
      Stefan Berger 提交于
      Check for an unsupported QMP command when using the query-tpm-models
      and query-tpm-types commands before checking for general errors
      in order to avoid error messages in the log.
      Signed-off-by: NStefan Berger <stefanb@linux.vnet.ibm.com>
      8b934a5c
    • S
      Revert checking for QMP query-tpm-models · f62cb556
      Stefan Berger 提交于
      Revert the patch checking for the QMP query-tpm-models
      command.
      Signed-off-by: NStefan Berger <stefanb@linux.vnet.ibm.com>
      f62cb556
    • P
      qemu_agent: Add support for appending arrays to commands · cbf8ebaa
      Peter Krempa 提交于
      Add support for array elements for agent commands just like 64d5e815 did for
      monitor commands
      cbf8ebaa
    • P
      lib: Fix docs about return value of virDomainGetVcpusFlags() · 13f26081
      Peter Krempa 提交于
      The return value description stated that 0 is returned in case of success
      instead of the count of vCPUs.
      13f26081
    • S
      Check for QMP query-tpm-models · 3208c562
      Stefan Berger 提交于
      Check for QMP query-tpm-models and set a capability flag. Do not use
      this QMP command if it is not supported.
      Signed-off-by: NStefan Berger <stefanb@linux.vnet.ibm.com>
      3208c562