Update the security drivers to use virReportError instead of
the virSecurityReportError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the Power-Hypervisor driver to use virReportError
instead of the PHYP_ERROR custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the Hyper-V driver to use virReportError instead
of the HYPERV_ERROR custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the ESX driver to use virReportError instead of
the ESX_ERROR & ESX_VI_ERROR custom macros
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the lock manager drivers to use virReportError instead
of the virLockError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the libxl driver to use virReportError instead of
the libxlError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Updates the lock manager code so that it passes "%s" as the format
string whenever raising an error message with a const string.

Updates the libxl driver code so that it passes "%s" as the format
string whenever raising an error message with a const string.

The 'lxc_driver' global variable is now used from several of
the LXC sources files. Thus it needs to be non-static to
avoid runtime linkage errors
Signed-off-by: NGao feng <gaofeng@cn.fujitsu.com>

Update the streams code to use virReportError instead of
the streamsReportError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the remote driver to use virReportError instead of
the remoteError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the XenXS shared code to use virReportError instead
of the XENXS_ERROR custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the OpenVZ driver to use virReportError instead of
the openvzError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

The Xen driver had a number of error reports which passed a
constant string without format specifiers and was missing
"%s". Furthermore the errors were related to failing system
calls, but virReportSystemError was not used. So the only
useful piece of info (the errno) was being discarded

Move all the code that manages stop/start of LXC processes
into separate lxc_process.{c,h} file to make the lxc_driver.c
file smaller
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Move the cgroup setup code out of the lxc_controller.c file
and into lxc_cgroup.{c,h}. This reduces the size of the
lxc_controller.c file and paves the way to invoke cgroup
setup from lxc_driver.c instead of lxc_controller.c in the
future
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Move the LXC driver code related to the virDomainObjPtr
private data into separate lxc_domain.{c,h} files
to reduce the size of lxc_driver.c
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the VMWare driver to use virReportError instead of
the vmwareError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the CPU helper APIs to use virReportError instead
of the virCPUReportError custom macor
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the test driver to use virReportError instead of the
testError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the VirtualBox driver to use virReportError instead of
the vboxError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the XenAPI driver to use virReportError instead of
the xenapiError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the QEMU driver to use virReportError instead of
the qemuReportError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

This patch cleans up some missing "%s" before translation macros,
for strings which are const without format specifiers

Update the UML driver to use virReportError instead of the
umlReportError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Make sure that libvirt_private.syms has all the internal symbols
from APIs in src/rpc/*.h and src/util/cgroup.h, since the LXC
controller/driver will shortly need them
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

To allow virNetServerRun/virNetServerQuit to be invoked multiple
times, we must reset the 'quit' flag in virNetServerRun
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

In the delayed close mode, we're just waiting for final data to
be written back to the client. While waiting, we should not
bother to read more data from the client.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

When sending SIGHUP to libvirtd, it will trigger the virStateDriver
reload operation. This is intended to reload the configuration files
for guests. For unknown historical reasons this is also triggering
autostart of all guests. Autostart is generally expected to be
something that happens on OS startup. Starting VMs on SIGHUP will
violate that expectation and potentially cause dangerous scenarios
if the admin has explicitly shutdown a misbehaving VM that has
been marked as autostart
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Update the linux bridge driver to use virReportError instead
of the networkReportError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Instead of only removing the ending newline character, it is
better to remove all of standard whitespace character for the
sake of log format.

One example that we have to do this is:
After three times incorrect password input, virsh command
virsh -c qemu://remoteserver/system will report error like:

: Connection reset by peerey,gssapi-keyex,gssapi-with-mic,password).

But it should be:
Permission denied (publickey,gssapi-keyex,gssapi-with-mic,password).
: Connection reset by peer

The reason is that we dropped the newline, but have a '\r' left.
The terminal interprets it as "move the cursor back to the start
of the current line", so the error string is messed up.

Noticed during the recent error cleanups.

* src/network/bridge_driver.c (networkStartRadvd): Fix spacing.
* src/openvz/openvz_conf.c (openvzReadMemConf): Likewise.
* src/qemu/qemu_command.c (qemuNetworkIfaceConnect): Likewise.
* src/qemu/qemu_hotplug.c (qemuDomainDetachNetDevice): Likewise.
* src/qemu/qemu_process.c (qemuProcessStop): Likewise.
* src/security/virt-aa-helper.c (vah_add_file): Likewise.

Detected on Cygwin.  Broken in commit 387117ad.

* src/util/virnetdev.c (virNetDevValidateConfig)
(virNetDevReplaceNetConfig): Fix prototypes.
* src/util/virnetlink.c (virNetlinkEventAddClient)
(virNetlinkEventRemoveClient): Likewise.

It was broken since forever as it expected a libxml2
XML_ELEMENT_NODE containing a XML_TEXT_NODE instead of
just a XML_TEXT_NODE.

This problem was not discovered for so long because
esxVI_String_Deserialize was not used until now.

Reported by Ata Bohra

Commit 80533ca2 forgot to think about offline cpus.  When a node
cpu is offline, then its topology/ subdirectory is not present,
leading to spurious error messages leaked to the user such as:

libvir:  error : cannot open /home/dummy/libvirt/tests/nodeinfodata/linux-nodeinfo-sysfs-test-6/node/node0/cpu7/topology/physical_package_id: No such file or directory

Fix that, as well as test it; the test data is gathered from a
machine with one NUMA node, hyperthreading, and with 2 of the
8 cpus offline.

* src/nodeinfo.c (virNodeParseNode): Don't parse topology of
offline cpus.
* tests/nodeinfotest.c (mymain): Run new test.
* tests/nodeinfodata/linux-nodeinfo-sysfs-test-6*: New data.

Also ensure that the virBuffer used to store the downloaded data
does not overflow.

Update the netcf driver to use virReportError instead of the
interfaceReportError custom macro

Update the network filter driver to use virReportError instead
of the virNWFilterReportError custom macro
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

This patch passes down the sec_mount_options to the
lxcContainerMountCGroups function and then mounts the tmpfs with
the correct label.