- 03 8月, 2017 20 次提交
-
-
由 Ján Tomko 提交于
My commit 0c1d8632 broke formatting of passthrough smartcard devices: <smartcard mode='passthrough' type='spicevmc'/> resulted in invalid XML: <smartcard mode='passthrough'> type='spicevmc'> <address type='ccid' controller='0' slot='0'/> </smartcard> Split out chardev source formatting function into two - one formatting the attributes and other formatting the subelements. Reported-by: NCole Robinson <crobinso@redhat.com> Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Peter Krempa 提交于
It turns out that our implementation of the hashing function is endian-dependent and thus if used on various architectures the testsuite may have different results. Work this around by mocking virHashCodeGen to something which does not use bit operations instead of just setting a deterministic seed.
-
由 Peter Krempa 提交于
Export the function from the util module so that dynamic linking can override it.
-
由 Peter Krempa 提交于
The functions declared in virhash.h return bool, but stdbool.h was not included.
-
由 Nikolay Shirokovskiy 提交于
Disk serial schema has extra '.+' allowed characters in comparison with check in code. Looks like there is no reason for that as qemu allows any character AFAIK for serial. This discrepancy is originated in commit id '85d15b51' where the ability to add serial was added. Alter the disk-serial test to add a disk with all the possible characters listed as the serial value.
-
由 John Ferlan 提交于
https://bugzilla.redhat.com/show_bug.cgi?id=1458630 Introduce virQEMUDriverConfigTLSDirResetDefaults in order to check if the defaultTLSx509certdir was changed, then change the default for any other *TLSx509certdir that was not set to the default default. Introduce virQEMUDriverConfigValidate to validate the existence of any of the *_tls_x509_cert_dir values that were uncommented/set, incuding the default. Update the qemu.conf description for default to describe the consequences if the default directory path does not exist. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
Commit id '94d2d642' caused a syntax-error check to fail: docs/Makefile.am:276: $(AM_V_GEN)sed -e '/<span id="php_placeholder"><\/span>/r '"$(srcdir)/$@.code.in" \ maint.mk: Wrap long lines in Makefiles cfg.mk:721: recipe for target 'sc_prohibit_long_lines' failed make: *** [sc_prohibit_long_lines] Error 1 make: *** Waiting for unfinished jobs.... Altered the line to put another line wrap between sed and -e
-
由 John Ferlan 提交于
commit id '40cb5581' caused syntax-check error: prohibit_empty_lines_at_EOF docs/manifest.json maint.mk: empty line(s) or no newline at EOF maint.mk:929: recipe for target 'sc_prohibit_empty_lines_at_EOF' failed make: *** [sc_prohibit_empty_lines_at_EOF] Error 1 I just edited the file and replaced the closing } and it made things happy
-
由 Daniel P. Berrange 提交于
Use of the relation "shortcut" for a favicon was an Internet Explorer only feature. Other browsers just require "icon". The new icons & metadata are generated using https://realfavicongenerator.net/ which is user tested to work well across all modern clients Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
由 Daniel P. Berrange 提交于
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com> -
由 Daniel P. Berrange 提交于
The 'shape' attribute on <a> is used together with a 'coords' attribute to create hot-zones in image maps. We're not using image maps so our inclusion of a 'shape' attribute is bogus. Furthermore this is forbidden in HTML5. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com> -
由 Daniel P. Berrange 提交于
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com> -
由 Daniel P. Berrange 提交于
The HTML5 doctype is simply <!DOCTYPE html> no DTD is present because HTML5 is no longer defined as an extension of SGML. XSL has no way to natively output a doctype without a public or system identifier, so we have to use an <xsl:text> hack instead. See also https://dev.w3.org/html5/html-author/#doctype-declarationSigned-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
由 Daniel P. Berrange 提交于
We have files which use HTML entities for decorating letters with unlauts, accents, etc. Other files just use UTF-8 characters directly for this. Remove the HTML entities since they have no benefit and use UTF-8 instead. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com> -
由 Daniel P. Berrange 提交于
A handful of places in the docs choose to use — instead of '-' for no clear reason. Remove this inconsistency. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com> -
由 Daniel P. Berrange 提交于
Some docs pages were using <p> </p> to add arbitrary whitespace in the page. This is something that should be done by CSS if needed, but it is not needed here, so delete it. There was also use of <td> </td> which adds no value at all when we have CSS to prettify tables. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com> -
由 Daniel P. Berrange 提交于
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com> -
由 Daniel P. Berrange 提交于
We already require libxml to be installed, so it is not unreasonable to require xmllint and xsltproc to be installed too - any platform with the former will have the latter too. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com> -
由 Daniel P. Berrange 提交于
The HTML pages are currently validated against an XHTML 1.0 DTD. This makes it impossible to take advantage of features that are introduced in HTML 5, because they'll fail validation. There is intentionally no DTD defined for HTML 5, so there's no alternative to XHTML 1.0 DTD that we could switch to. The only options are to stick with XHTML 1.0 forever, or drop the DTD validation, and we pick the latter. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com> -
由 Daniel P. Berrange 提交于
The 'name' attribute on <a...> elements is deprecated in favour of the 'id' attribute which is allowed on any element. HTML5 drops 'name' support entirely. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
- 02 8月, 2017 19 次提交
-
-
由 Ján Tomko 提交于
The rombar attribute was already validated at the time of parsing the XML.
-
由 Ján Tomko 提交于
After an OOM error, virBuffer* APIs set buf->use to zero. Adding a buffer to the parent buffer only if use is non-zero would quietly drop data on error. Check the error beforehand to make sure buf->use is zero because we have not attempted to add anything to it.
-
由 Ján Tomko 提交于
Switch virDomainHubDefFormat to use a separate buffer for subelements.
-
由 Ján Tomko 提交于
Convert virDomainWatchdogDefFormat to use a separate buffer for subelements.
-
由 Ján Tomko 提交于
Convert virDomainSoundDefFormat to use a separate buffer for subelements.
-
由 Ján Tomko 提交于
Convert virDomainSmartcardDefFormat to use a separate buffer for possible subelements, to avoid the need for duplicated formatting logic in virDomainDeviceInfoNeedsFormat.
-
由 Ján Tomko 提交于
This function has grown to format more than just the address. Delete the comment completely to avoid failing to update it in the future. Also, the indentation is now handled by the virBuffer APIs, so the comment about indentation no longer makes sense.
-
由 Ján Tomko 提交于
This function returns false if virDomainDeviceInfoFormat would not format anything. Using it as the sole condition to decide whether to call virDomainDeviceInfoFormat or not is pointless, since the conditions are repeated in virDomainDeviceInfoFormat.
-
由 Ján Tomko 提交于
This will simplify the cleanup when we start checking for buffer errors.
-
由 Michal Privoznik 提交于
https://bugzilla.redhat.com/show_bug.cgi?id=1462653 Just like I've added support for setting rx_queue_size (in c56cdf25 and friends), qemu just gained support for setting tx ring size. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Daniel P. Berrange 提交于
Not every platform is guaranteed to have dlopen/dlsym, so we should conditionalize its use. Suprisingly it is actually present for Win32 via the mingw-dlfcn add on, but we should still conditionalize it. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com> -
由 Daniel P. Berrange 提交于
A variable named 'socket' clashes with the function of the same name, causing build failures due to warnings on some platforms. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com> -
由 Michal Privoznik 提交于
These functions were made exportable back in 3aa3e072 when I was splitting network code into parsing and list management parts. Since then the split is finished now and these two functions do not need to be exported anymore. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Michal Privoznik 提交于
This member allows us to store a pointer to some private data. However, the comment says it's used in both domain driver and network driver. Well, it is not. It's just one pointer and domain driver uses it directly. Network driver has a global driver variable. Update the comment to not confuse others. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com> -
由 Julio Faracco 提交于
This commit adds the unix socket URL support to 'domdisplay' command. Before, even if an user was using unix socket to define a spice graphics, the command 'domdisplay' showed that the settings were not supported. Now, the command shows the proper URL: spice+unix://foo/bar.sock. Settings: <graphics type='vnc' port='-1' autoport='yes' listen='127.0.0.1'> <listen type='address' address='127.0.0.1'/> </graphics> <graphics type='spice'> <listen type='socket' socket='/tmp/spice.sock'/> </graphics> Before: virsh # domdisplay --all Windows7 vnc://127.0.0.1:0 After: virsh # domdisplay --all Windows7 vnc://127.0.0.1:0 spice+unix:///tmp/spice.sock Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1336720Signed-off-by: NJulio Faracco <jcfaracco@gmail.com>
-
由 Michal Privoznik 提交于
In 19581afd the configure.ac was updated. However, the news.xml was missing adjustment - creating the new section for the release. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Martin Kletzander 提交于
Since the introduction of shmem, there was a split of preparation code from the formatting code from qemuBuildCommandLine() into qemuProcessPrepareDomain(). Let's fix shmem in this regard, so that we can slowly get to a cleaner codebase. Signed-off-by: NMartin Kletzander <mkletzan@redhat.com> -
由 Martin Kletzander 提交于
Signed-off-by: NMartin Kletzander <mkletzan@redhat.com> -
由 Daniel Veillard 提交于
* docs/news.xml: updated for the release * po/*.po*: regenerated
-
- 01 8月, 2017 1 次提交
-
-
由 Michal Privoznik 提交于
So there are couple of issues here. Firstly, we never unref the @pendingReply and thus it leaks. ==13279== 144 (72 direct, 72 indirect) bytes in 1 blocks are definitely lost in loss record 1,095 of 1,259 ==13279== at 0x4C2E080: calloc (vg_replace_malloc.c:711) ==13279== by 0x781FA97: _dbus_pending_call_new_unlocked (in /usr/lib64/libdbus-1.so.3.14.11) ==13279== by 0x7812A4C: dbus_connection_send_with_reply (in /usr/lib64/libdbus-1.so.3.14.11) ==13279== by 0x56BEDF3: virNetDaemonCallInhibit (virnetdaemon.c:514) ==13279== by 0x56BEF18: virNetDaemonAddShutdownInhibition (virnetdaemon.c:536) ==13279== by 0x12473B: daemonInhibitCallback (libvirtd.c:742) ==13279== by 0x1249BD: daemonRunStateInit (libvirtd.c:823) ==13279== by 0x554FBCF: virThreadHelper (virthread.c:206) ==13279== by 0x8F913D3: start_thread (in /lib64/libpthread-2.23.so) ==13279== by 0x928DE3C: clone (in /lib64/libc-2.23.so) Secondly, while we send the message, we are suspended ('cos we're talking to a UNIX socket). However, until we are resumed back again the reply might have came therefore subsequent dbus_pending_call_set_notify() has no effect and in fact the virNetDaemonGotInhibitReply() callback is never called. Thirdly, the dbus_connection_send_with_reply() has really stupid policy for return values. To cite the man page: Returns FALSE if no memory, TRUE otherwise. Yes, that's right. If anything goes wrong and it's not case of OOM then TRUE is returned, i.e. you're trying to pass FDs and it's not supported, or you're not connected, or anything else. Therefore, checking for return value of dbus_connection_send_with_reply() is not enoguh. We also have to check if @pendingReply is not NULL before proceeding any further. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-