1. 19 4月, 2017 19 次提交
  2. 18 4月, 2017 7 次提交
  3. 14 4月, 2017 4 次提交
    • S
      pci: recognize/report GEN4 (PCIe 4.0) card 16GT/s Link speed · 8e09663f
      Shivaprasad G Bhat 提交于
      Without this added enum value, nodedev-dumpxml of a GEN4 (PCIe 4.0)
      card will fail (due to the unrecognized link speed), and since
      nodedev-detach and nodedev-reattach internally do a dumpxml+parse,
      they will also fail. With this patch, all those operations succeed.
      Signed-off-by: NShivaprasad G Bhat <sbhat@linux.vnet.ibm.com>
      8e09663f
    • A
      Drop autobuild.sh · 3bf3711a
      Andrea Bolognani 提交于
      The Test-AutoBuild project, that this script is supposed to
      be used with, hasn't seen any activity in ~6 years; libvirt's
      own CI is running on Jenkins with a completely independent
      setup that doesn't use the script at all.
      3bf3711a
    • W
      xenFormatXLDomainDisks: avoid double free on OOM testing · 2c1a31a3
      Wim ten Have 提交于
      Fix xlconfigtest runs build for --enable-test-oom on
              Xen XL-2-XML Parse  new-disk
      
          #0  0x00007ffff3bd791f in raise () from /lib64/libc.so.6
          #1  0x00007ffff3bd951a in abort () from /lib64/libc.so.6
          #2  0x00007ffff3c1b200 in __libc_message () from /lib64/libc.so.6
          #3  0x00007ffff3c2488a in _int_free () from /lib64/libc.so.6
          #4  0x00007ffff3c282bc in free () from /lib64/libc.so.6
          #5  0x00007ffff7864fcb in virFree (ptrptr=ptrptr@entry=0x7fffffffd868) at util/viralloc.c:582
          #6  0x00007ffff78776e5 in virConfFreeValue (val=<optimized out>) at util/virconf.c:178
      ==> #7  0x0000000000425759 in xenFormatXLDomainDisks (def=0x7fffffffd8c0, def=0x7fffffffd8c0, conf=0x658220)
              at xenconfig/xen_xl.c:1159
          #8  xenFormatXL (def=def@entry=0x66ec20, conn=conn@entry=0x668cf0) at xenconfig/xen_xl.c:1558
          #9  0x000000000040ea1d in testCompareParseXML (replaceVars=<optimized out>,
              xml=0x65f5e0 "/home/wtenhave/WORK/libvirt/history/libvirt/tests/xlconfigdata/test-fullvirt-ovmf.xml",
              xlcfg=0x65f6b0 "/home/wtenhave/WORK/libvirt/history/libvirt/tests/xlconfigdata/test-fullvirt-ovmf.cfg")
              at xlconfigtest.c:105
          #10 testCompareHelper (data=<optimized out>) at xlconfigtest.c:205
          #11 0x000000000041079a in virTestRun (title=title@entry=0x431cf0 "Xen XL-2-XML Parse  fullvirt-ovmf",
              body=body@entry=0x40e720 <testCompareHelper>, data=data@entry=0x7fffffffda50) at testutils.c:247
          #12 0x000000000040ebc2 in mymain () at xlconfigtest.c:256
          #13 0x0000000000411070 in virTestMain (argc=1, argv=0x7fffffffdc08, func=0x40f2c0 <mymain>) at testutils.c:992
          #14 0x00007ffff3bc2401 in __libc_start_main () from /lib64/libc.so.6
          #15 0x000000000040e5da in _start ()
      
      symmetry seems missing its sibbling coded functionality
      demonstrated under functions;
              xenFormatXLUSBController()
              xenFormatXLUSB()
              xenFormatXLDomainChannels()
              xenFormatXMDisks
      Signed-off-by: NWim ten Have <wim.ten.have@oracle.com>
      2c1a31a3
    • W
      virConfSaveValue: protect against a NULL pointer reference · ae5d7582
      Wim ten Have 提交于
      Fix xlconfigtest runs build for --enable-test-oom on
              Xen XL-2-XML Parse  channel-pty
      
      Program received signal SIGSEGV, Segmentation fault.
      
          #0  0x00007ffff3c2b373 in __strchr_sse2 () from /lib64/libc.so.6
      ==> #1  0x00007ffff7875701 in virConfSaveValue (buf=buf@entry=0x7fffffffd8a0, val=val@entry=0x674750) at util/virconf.c:290
          #2  0x00007ffff7875668 in virConfSaveValue (buf=buf@entry=0x7fffffffd8a0, val=<optimized out>) at util/virconf.c:306
          #3  0x00007ffff78757ef in virConfSaveEntry (buf=buf@entry=0x7fffffffd8a0, cur=cur@entry=0x674780) at util/virconf.c:338
          #4  0x00007ffff78783eb in virConfWriteMem (memory=0x665570 "", len=len@entry=0x7fffffffd910, conf=conf@entry=0x65b940)
              at util/virconf.c:1543
          #5  0x000000000040eccb in testCompareParseXML (replaceVars=<optimized out>, xml=<optimized out>,
              xlcfg=0x662c00 "/home/wtenhave/WORK/libvirt/OOMtesting/libvirt-devel/tests/xlconfigdata/test-channel-pty.cfg")
              at xlconfigtest.c:108
          #6  testCompareHelper (data=<optimized out>) at xlconfigtest.c:205
          #7  0x0000000000410b3a in virTestRun (title=title@entry=0x432cc0 "Xen XL-2-XML Parse  channel-pty",
              body=body@entry=0x40e9b0 <testCompareHelper>, data=data@entry=0x7fffffffd9f0) at testutils.c:247
          #8  0x000000000040f322 in mymain () at xlconfigtest.c:278
          #9  0x0000000000411410 in virTestMain (argc=1, argv=0x7fffffffdba8, func=0x40f660 <mymain>) at testutils.c:992
          #10 0x00007ffff3bc0401 in __libc_start_main () from /lib64/libc.so.6
          #11 0x000000000040e86a in _start ()
      
          (gdb) frame 1
          #1  0x00007ffff7875701 in virConfSaveValue (buf=buf@entry=0x7fffffffd8a0, val=val@entry=0x674750) at util/virconf.c:290
          290                 if (strchr(val->str, '\n') != NULL) {
          (gdb) print *val
          $1 = {type = VIR_CONF_STRING, next = 0x0, l = 0, str = 0x0, list = 0x0}
      Signed-off-by: NWim ten Have <wim.ten.have@oracle.com>
      ae5d7582
  4. 13 4月, 2017 10 次提交
    • J
      nwfilter: Introduce virNWFilterObjListExport · c7aa5c43
      John Ferlan 提交于
      Essentially code motion to move the ListExport function from nwfilter_driver
      into virnwfilterobj
      Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
      c7aa5c43
    • J
      nwfilter: Introduce virNWFilterObjGetNames · 206f71e1
      John Ferlan 提交于
      Mostly code motion to move nwfilterConnectListNWFilters into nwfilterobj.c
      and rename to virNWFilterObjGetNames.
      
      Also includes a couple of variable name adjustments to keep code consistent
      with other drivers.
      Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
      206f71e1
    • J
      nwfilter: Introduce virNWFilterObjNumOfNWFilters · 0c221628
      John Ferlan 提交于
      Mostly code motion from nwfilter_driver to virnwfilterobj with one caveat
      to add the virNWFilterObjListFilter typedef and pass it as an 'aclfilter'
      argument to allow for future possible test driver adjustments to count
      the number of filters (similar to how node device has done this).
      Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
      0c221628
    • J
      conf: Add check for non scsi_host parent during vport delete · 84f178bd
      John Ferlan 提交于
      https://bugzilla.redhat.com/show_bug.cgi?id=1420740
      
      If the parent is not a scsi_host, then we can just happily return since
      we won't be removing a vport.
      
      Fixes a bug with the following output:
      
      $ virsh pool-destroy host4_hba_pool
      error: Failed to destroy pool host4_hba_pool
      error: internal error: Invalid adapter name 'pci_0000_10_00_1' for SCSI pool
      
      $
      84f178bd
    • J
      conf: Check for storage conflicts across pool types · 4143b194
      John Ferlan 提交于
      https://bugzilla.redhat.com/show_bug.cgi?id=1233129
      
      The virStoragePoolObjSourceFindDuplicate logic used by PoolCreateXML
      and PoolDefineXML avoids comparing the new definition against "other"
      pool types. This can cause unexpected corruption if two different pool
      source types used the same source device path. For example, a 'disk'
      pool using source type device=/dev/sdc could be unwittingly overwritten
      by using /dev/sdc for a 'logical' pool which also uses the source
      device path.
      
      So rather than blindly ignoring those checks when def->type !=
      pool->def->type - have the pool->def->type switch logic handle the
      check for which def->type's should be checked.
      4143b194
    • J
      conf: Introduce virStoragePoolObjSourceMatchTypeDEVICE · f84b89fb
      John Ferlan 提交于
      Refactor virStoragePoolObjSourceFindDuplicate into smaller units
      separated by the "supported" pool source type. The ISCSI, FS,
      LOGICAL, DISK, and ZFS pools can use "<source>... <device='%s'/>...
      </source>".
      
      Alter the logic slightly to return the matching pool or NULL rather
      than setting matchpool = pool and break.  Easier to read that way.
      f84b89fb
    • J
      conf: Introduce virStoragePoolObjSourceMatchTypeISCSI · 2811e29e
      John Ferlan 提交于
      In the effort to reduce the virStoragePoolObjSourceFindDuplicate logic,
      create a new helper which will handle all the ISCSI type differences.
      
      Alter things just a little bit to return NULL or pool rather than
      using breaks and matchpool = pool, then break. Also rather than creating
      variables withing the if...else if... conditions, have them all at the
      top of the function to make things a bit easier to read.
      2811e29e
    • J
      conf: Introduce virStoragePoolObjSourceMatchTypeDIR · 6ddd6ae8
      John Ferlan 提交于
      Refactor virStoragePoolObjSourceFindDuplicate into smaller units
      separated by the "supported" pool source type. The DIR, GLUSTER,
      and NETFS pools all can use "<source>... <dir='%s'/>... </source>".
      
      Alter the logic slightly to return the matching pool or NULL rather
      than setting matchpool = pool and break.  Easier to read that way.
      6ddd6ae8
    • J
      qemu: refactor qemuBuildIOMMUCommandLine · b595cc05
      Ján Tomko 提交于
      Introduce a separate buffer for options and use a helper
      variable for def->iommu.
      b595cc05
    • J
      qemu: allow conditional device property probing · 4ae59411
      Ján Tomko 提交于
      Do not probe for devices that QEMU does not know
      when probing for device options.
      4ae59411