1. 04 11月, 2015 1 次提交
  2. 30 10月, 2015 2 次提交
    • L
      util: set max wait for IPv6 DAD to 20 seconds · ac339206
      Laine Stump 提交于
      This was originally set to 5 seconds, but times of 5.5 to 7 seconds
      were experienced. Since it's an arbitrary number intended to prevent
      an infinite hang, having it a bit too high won't hurt anything, and 20
      seconds looks to be adequate (i.e. I think/hope we don't need to make
      it tunable in libvirtd.conf)
      ac339206
    • L
      util: set error if DAD is not finished · d41a64a1
      Luyao Huang 提交于
      If DAD not finished in 5 seconds, user will get an
      unknown error like this:
      
       # virsh net-start ipv6
       error: Failed to start network ipv6
       error: An error occurred, but the cause is unknown
      
      Call virReportError to set an error.
      Signed-off-by: NLuyao Huang <lhuang@redhat.com>
      d41a64a1
  3. 29 10月, 2015 5 次提交
    • M
      wireshark: Install to generic plugin directory · 7c8250d7
      Michal Privoznik 提交于
      There has been a report on the list [1] that we are not
      installing the wireshark dissector into the correct plugin
      directory. And in fact we are not. The problem is, the plugin
      directory path is constructed at compile time. However, it's
      dependent on the wireshark version, e.g.
      
        /usr/lib/wireshark/plugins/1.12.6
      
      This is rather unfortunate, because if libvirt RPMs were built
      with one version, but installed on a system with newer one, the
      plugins are not really loaded. This problem lead fedora packagers
      to unify plugin path to:
      
        /usr/lib/wireshark/plugins/
      
      Cool! But this was enabled just in wireshark-1.12.6-4. Therefore,
      we must require at least that version.
      
      And while at it, on some distributions, the wireshark.pc file
      already has a variable that defines where plugin dir is. Use that
      if possible.
      
      1: https://www.redhat.com/archives/libvirt-users/2015-October/msg00063.htmlSigned-off-by: NMichal Privoznik <mprivozn@redhat.com>
      7c8250d7
    • R
      Fix virNetDevWaitDadFinish stub · 2589ca30
      Roman Bogorodskiy 提交于
      Build on non-Linux fails because the virNetDevWaitDadFinish() stub
      has unused parameters. Fix by adding appropriate ATTRIBUTE_UNUSED
      for these parameters.
      
      Pushing under build-breaker rule.
      2589ca30
    • M
      network: wait for DAD to finish for bridge IPv6 addresses · 0f7436ca
      Maxim Perevedentsev 提交于
      commit db488c79 assumed that dnsmasq would complete IPv6 DAD before
      daemonizing, but in reality it doesn't wait, which creates problems
      when libvirt's bridge driver sets the matching "dummy tap device" to
      IFF_DOWN prior to DAD completing.
      
      This patch waits for DAD completion by periodically polling the kernel
      using netlink to check whether there are any IPv6 addresses assigned
      to bridge which have a 'tentative' state (if there are any in this
      state, then DAD hasn't yet finished). After DAD is finished, execution
      continues. To avoid an endless hang in case something was wrong with
      the kernel's DAD, we wait a maximum of 5 seconds.
      0f7436ca
    • M
      netlink: add support for multi-part netlink messages. · 131e7245
      Maxim Perevedentsev 提交于
      Such messages do not have NLMSG_ERROR or NLMSG_DONE type
      but they are valid responses. We test 'multi-partness'
      by looking for NLM_F_MULTI flag.
      131e7245
    • L
      qemu: Use live autoNodeset when numatune placement is auto · 4eac5523
      Luyao Huang 提交于
      https://bugzilla.redhat.com/show_bug.cgi?id=1270715
      
      Commit id '9deb96f9' removed the code to fetch the nodeset from the
      CpusetMems cgroup for a running vm in favor of using the return from
      virDomainNumatuneFormatNodeset introduced by commit id '43b67f2e'.
      However, that API will return the value of the passed 'auto_nodeset'
      when placement is VIR_DOMAIN_NUMATUNE_PLACEMENT_AUTO, which happens
      to be NULL.
      
      Since commit id 'c74d58ad' started using priv->autoNodeset in order
      to manage the auto placement value during qemuProcessStart, it should
      be passed along in order to return the correct value if the domain
      requests the auto placement.
      Signed-off-by: NLuyao Huang <lhuang@redhat.com>
      4eac5523
  4. 28 10月, 2015 2 次提交
  5. 27 10月, 2015 7 次提交
  6. 26 10月, 2015 5 次提交
  7. 22 10月, 2015 6 次提交
    • A
      tests: Remove unused nodeinfo test data · e739d956
      Andrea Bolognani 提交于
      A bunch of files that we don't currently parse, and are very
      unlikely to ever start parsing, made their way into the nodeinfo
      test data. Get rid of them.
      e739d956
    • L
      virsh: Display an error when passing count <= 0 to setvcpus · c62c59a9
      Luyao Huang 提交于
      The number of vCPUs for a guest must be between 1 and the
      maximum value configured in the domain XML. This commit
      introduces checks to make sure that passing count <= 0
      results in an error.
      
      Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1248277Signed-off-by: NLuyao Huang <lhuang@redhat.com>
      c62c59a9
    • J
      conf: Fix error message to use correct parameter · 4527b2ae
      John Ferlan 提交于
      Fix a cut-n-paste error from commit id '35eecdde' where the previous
      check for max_sectors seems to have been copied, but the error message
      parameter not updated to be ioeventfd
      4527b2ae
    • L
      util: Produce friendlier error message to user · 4f9e61f6
      Luyao Huang 提交于
      Commit id '1c24cfe9' added error messages for virNumaSetPagePoolSize;
      however, virNumaGetHugePageInfo also uses virNumaGetHugePageInfoPath
      in order to build the path, but it never checked upon return if
      the built path exists which could lead to an error message as follows:
      
      $ virsh freepages 0 1
      error: Failed to open file
          '/sys/devices/system/node/node0/hugepages/hugepages-1kB/free_hugepages':
          No such file or directory
      
      Rather than add the same message for the other two callers, adjust
      the virNumaGetHugePageInfoPath in order not only build the path, but
      also check if the built path exists.  If the path does not exist,
      then generate the error message and return failure.
      Signed-off-by: NLuyao Huang <lhuang@redhat.com>
      4f9e61f6
    • L
      util: Adjust error paths for virNumaSetPagePoolSize · e802d7ef
      Luyao Huang 提交于
      Commit id '1c24cfe9' added new checks and error messaes for failure
      scenarios. Let's adjust those error messages to after the call to
      virNumaGetHugePageInfoPath in order to provide a more specific error
      message depending on node and page_size
      
      After this patch:
       # virsh allocpages --pagesize 2047 --pagecount 1 --cellno 0
       error: operation failed: page size 2047 is not available on node 0
      
       # virsh allocpages --pagesize 2047 --pagecount 1
       error: operation failed: page size 2047 is not available
      Signed-off-by: NLuyao Huang <lhuang@redhat.com>
      e802d7ef
    • L
      util: split the virNumaGetHugePageInfoPath into separate function · deb8c66d
      Luyao Huang 提交于
      https://bugzilla.redhat.com/show_bug.cgi?id=1265114
      
      Refactor helper virNumaGetHugePageInfoPath to handle returning a directory
      path when passed a page_size of 0 and suffix == NULL into a new helper
      virNumaGetHugePageInfoDir which will only be called when a directory
      path is expected to be returned. This solves the issue where the helper
      was called with page_size == 0 expecting a file path in return, but
      instead got a directory path and failed in virFileReadAll with:
      
          error : virFileReadAll:1358 : Failed to read file
                      '/sys/devices/system/node/node0/hugepages/': Is a directory
      
      Since virNumaGetPages API expects to return a directory by passing
      page_size == 0 and suffix == NULL, it will now call the new helper.
      Callers to virNumaGetHugePageInfoPath expect to return a file path
      which could then be used in the call to virFileReadAll.
      Signed-off-by: NLuyao Huang <lhuang@redhat.com>
      deb8c66d
  8. 21 10月, 2015 1 次提交
  9. 20 10月, 2015 5 次提交
  10. 16 10月, 2015 6 次提交