- 13 4月, 2017 2 次提交
-
-
由 Ján Tomko 提交于
Properly error out when the user requests a port from a bus that does not have a controller present in the domain XML. https://bugzilla.redhat.com/show_bug.cgi?id=1441589
-
由 Peter Krempa 提交于
Commit 4f4c3b13 added code to remember errors during freeing of domain objects. This changed the output when testing scaled numbers parsing in virsh-optparse. Adjust the expected output.
-
- 12 4月, 2017 18 次提交
-
-
由 Daniel P. Berrange 提交于
The virPerfGetEvent method pointlessly checks for a NULL parameter and the range of an enum value. The whole point of using an enum is that we can avoid such checks. Just replace calls to virPerfGetEvent, with perf->events[type] array access. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
由 Daniel P. Berrange 提交于
The virPerfGetEventAttr method contains a totally pointless loop. Remove it, verify the array size statically, and then just use an array index to access the perf event. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
由 Martin Kletzander 提交于
Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>
-
由 Peter Krempa 提交于
==20406== 8 bytes in 1 blocks are definitely lost in loss record 24 of 1,059 ==20406== at 0x4C2CF55: calloc (vg_replace_malloc.c:711) ==20406== by 0x54BF530: virAllocN (viralloc.c:191) ==20406== by 0x54D37C4: virConfGetValueStringList (virconf.c:1001) ==20406== by 0x144E4E8E: virQEMUDriverConfigLoadFile (qemu_conf.c:835) ==20406== by 0x1452A744: qemuStateInitialize (qemu_driver.c:664) ==20406== by 0x55DB585: virStateInitialize (libvirt.c:770) ==20406== by 0x124570: daemonRunStateInit (libvirtd.c:881) ==20406== by 0x5532990: virThreadHelper (virthread.c:206) ==20406== by 0x8C82493: start_thread (in /lib64/libpthread-2.24.so) ==20406== by 0x8F7FA1E: clone (in /lib64/libc-2.24.so)
-
由 Peter Krempa 提交于
==20406== 4 bytes in 1 blocks are definitely lost in loss record 6 of 1,059 ==20406== at 0x4C2AF3F: malloc (vg_replace_malloc.c:299) ==20406== by 0x8F17D39: strdup (in /lib64/libc-2.24.so) ==20406== by 0x552C0E0: virStrdup (virstring.c:784) ==20406== by 0x54D3622: virConfGetValueString (virconf.c:945) ==20406== by 0x144E4692: virQEMUDriverConfigLoadFile (qemu_conf.c:687) ==20406== by 0x1452A744: qemuStateInitialize (qemu_driver.c:664) ==20406== by 0x55DB585: virStateInitialize (libvirt.c:770) ==20406== by 0x124570: daemonRunStateInit (libvirtd.c:881) ==20406== by 0x5532990: virThreadHelper (virthread.c:206) ==20406== by 0x8C82493: start_thread (in /lib64/libpthread-2.24.so) ==20406== by 0x8F7FA1E: clone (in /lib64/libc-2.24.so)
-
由 Peter Krempa 提交于
Use the new XML helpers and use virXPathString rather than hand-rolling the code.
-
由 Peter Krempa 提交于
Reuse virshDomainGetXML and virshDomainGetXMLFromDom.
-
由 Peter Krempa 提交于
Reuse virshDomainGetXML and virshDomainGetXMLFromDom.
-
由 Peter Krempa 提交于
In virsh we quite often get the domain XML just to initialize the XPath parser so that we can extract information. Add helpers which will simplify this by wrapping the getting of the XML and parsing it along with error reporting. Additionally a second helper also gets the domain object from the parameters and releases it so that functions which need the XML as only source of data can be simplified further.
-
由 Peter Krempa 提交于
Avoid the annoying issue where the public object freeing APIs overwrite the error set by helper functions, since they don't invoke the callback. The new helper remembers the error only if no previous error was set.
-
由 Peter Krempa 提交于
Similarly to virshDomainFree add a wrapper for the snapshot object freeing function.
-
由 Peter Krempa 提交于
virDomainFree has it's quirks (does not like NULL pointers, resets libvirt errors). Replace it by a virsh helper which will allow us to centrally fix issues with it. The syntax-check rule will prohibit new uses of virDomainFree.
-
由 Peter Krempa 提交于
Move virshLookupDomainBy, virshCommandOptDomainBy and virshCommandOptDomainBy to the helper file. Additionally turn the virshCommandOptDomainBy macro into a function.
-
由 Peter Krempa 提交于
Don't accumulate helpers in virsh.c
-
由 Erik Skultety 提交于
Commit a4a39d90 added a check that checks for VFIO support with mediated devices. The problem is that the hostdev preparing functions behave like a fallthrough if device of that specific type doesn't exist. However, the check for VFIO support was independent of the existence of a mdev device which caused the guest to fail to start with any device to be directly assigned if VFIO was disabled/unavailable in the kernel. The proposed change first ensures that it makes sense to check for VFIO support in the first place, and only then performs the VFIO support check itself. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1441291Signed-off-by: NErik Skultety <eskultet@redhat.com>
-
由 Wang King 提交于
Coverity complains about virBufferCurrentContent might be return null when calling strlen, so check virBufferError first before calling strlen.
-
由 Wang King 提交于
On virGetInterface failure, call virInterfaceDefFree for the @def.
-
由 Wang King 提交于
==18591== 16 bytes in 1 blocks are definitely lost in loss record 41 of 183 ==18591== at 0x4C2B934: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==18591== by 0x54EBB1C: virAllocN (viralloc.c:191) ==18591== by 0x1628CA: _vshMalloc (vsh.c:136) ==18591== by 0x1344C4: virshVcpuPinQuery (virsh-domain.c:6603) ==18591== by 0x1344C4: cmdVcpuPin (virsh-domain.c:6707) ==18591== by 0x1631BF: vshCommandRun (vsh.c:1312) ==18591== by 0x12DBB1: main (virsh.c:961)
-
- 11 4月, 2017 20 次提交
-
-
由 John Ferlan 提交于
Create a couple of helpers that will perform the same call sequence. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
Alter virStoragePoolObjListExport in order to pass the drivers->pools by reference Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
Mostly code motion to move storageConnectList[Defined]StoragePools and similar test driver code into virstorageobj.c and rename to virStoragePoolObjGetNames. Also includes a couple of variable name adjustments to keep code consistent with other drivers. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
Unify the NumOf[Defined]StoragePools API into virstorageobj.c from storage_driver and test_driver. The only real difference between the two is the test driver doesn't call using the aclfilter API. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
Essentially code motion to move the storage/test driver ListAllVolumes logic into virstorageobj.c Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
Mostly code motion to move storagePoolListVolumes code into virstorageobj.c and rename to virStoragePoolObjVolumeGetNames. Also includes a couple of variable name adjustments to keep code consistent with other drivers. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
Unify the NumOfVolumes API into virstorageobj.c from storage_driver and test_driver. The only real difference between the two is the test driver doesn't call using the aclfilter API. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Pavel Hrdina 提交于
This removes the hacky extern global variable and modifies the test code to properly create QEMU capabilities cache for QEMU binaries used in our tests. Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Pavel Hrdina 提交于
Our test data used a lot of different qemu binary paths and some of them were based on downstream systems. Note that there is one file where I had to add "accel=kvm" because the qemuargv2xml code parses "/usr/bin/kvm" as virt type="kvm". Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Pavel Hrdina 提交于
The virt type for QEMU can be modified by -machine attribute "accel" so there is no need to have different QEMU binary paths. Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Pavel Hrdina 提交于
Let's group all the binaries that we use in our test suite to one array. Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Pavel Hrdina 提交于
All other architectures have separate functions to prepare guest capabilities, do the same for i686 and x86_64 as well. Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Pavel Hrdina 提交于
Most tests already use global driver variable that is initialized before any test case is executed, convert these remaining tests to the same concept. Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Pavel Hrdina 提交于
Commit 5572cd7f deprecated QEMU_CAPS_DEVICE capability but forgot to remove this call as well. Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Pavel Hrdina 提交于
This is not required to run our tests. Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Pavel Hrdina 提交于
Found by running valgrind for these tests. Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Pavel Hrdina 提交于
Commit 252610f7 switched to use hash to store servers. Function virHashGetItems returns allocated array which needs to be freed also for successful path, not only if there is an error. Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Pavel Hrdina 提交于
All of the variables are filled inside a loop and therefore needs to be also freed in every cycle. Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Pavel Hrdina 提交于
Commit 14319c81 introduced CPU host model in domain capabilities and the *hostmodel* variable is always filled by virCPUDefCopy() and needs to be freed. Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 John Ferlan 提交于
For both virNodeDeviceObjNumOfDevices and virNodeDeviceObjGetNames, the check should be if the aclfilter doesn't exist or if it does exist, then it must pass
-