1. 08 1月, 2019 9 次提交
    • E
      examples: Avoid gnulib, have standalone examples · acf522e8
      Eric Blake 提交于
      Commit 0c6ad476 updated gnulib, which rearranged some of the
      conditions in gnulib wrapper headers such that compilation
      started failing on BSD systems when the normal system <unistd.h>
      tried to include another system header but instead got a
      gnulib wrapper header in an incomplete state; this is because
      gnulib headers only work if <config.h> is included first.
      
      Commit b6f78259 papered over the symptoms of that by including
      <config.h> in all the examples.  But this logic is backwards -
      if our examples are truly meant to be stand-alone, they should
      NOT depend on how libvirt was configured, and should NOT
      depend on the gnulib fixes for system quirks.  In particular,
      if an example does not need to link against libgnulib.la,
      then it also does not need to use -Ignulib in its compile
      flags, and likewise does not need to include <config.h> since
      none of the gnulib wrapper headers should be interfering.
      
      So, revert (most of) b6f78259 (except for the bogus pre-patch
      use of "config.h" in admin/logging.c: if config.h is included,
      it should be via <> rather than "", and must be before any
      system headers); then additionally nuke all mention of
      <config.h>, -Ignulib, and -llibgnu.la, making all of the
      examples truly standalone.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      Acked-by: NMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: NJán Tomko <jtomko@redhat.com>
      acf522e8
    • E
      examples: Drop event-test.c dependency on gnulib <verify.h> · 6933ebc4
      Eric Blake 提交于
      Pulling in gnulib just for the <verify.h> header is rather
      expensive, especially since that header does not require us
      to link against gnulib.  It's better to make the event-test
      example be standalone by just open-coding a more limited form
      of a verify() macro that depends on modern gcc (we have enough
      CI coverage that even though the verify is now a no-op in
      older setups, we will still notice if we fail to add an event
      - as a quick test, I was still able to provoke a compile
      failure on Fedora 29 when deleting a line from domainEvents).
      Signed-off-by: NEric Blake <eblake@redhat.com>
      Acked-by: NMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: NJán Tomko <jtomko@redhat.com>
      6933ebc4
    • E
      util: Fix the default log output to 'journald' when running under systemd · 30727583
      Erik Skultety 提交于
      Essentially, bring back the old behaviour as of commit eba36a38 which
      was later changed by commit ae06048b. Even though all the stderr
      messages will eventually end up in the journal, we're not making use of
      the fields journald provides.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1592644Signed-off-by: NErik Skultety <eskultet@redhat.com>
      Acked-by: NMichal Privoznik <mprivozn@redhat.com>
      30727583
    • E
      maint: Fix VPATH build · f3a4fbd2
      Eric Blake 提交于
      In a VPATH build, <config.h> is in the builddir (which automake
      includes automatically), but it includes <config-post.h> from the
      top source directory (which is not automatic); hence, we need to
      keep the -I(top_srcdir) directive that was accidentally removed
      from commit 7a879323 (the problem is not visible in an in-tree
      build).
      Signed-off-by: NEric Blake <eblake@redhat.com>
      f3a4fbd2
    • E
      maint: Prefer AM_CPPFLAGS over INCLUDES · 1862a554
      Eric Blake 提交于
      Our use of INCLUDES in Makefile.am hearkens back to when we had to
      cater to automake 1.9.6 (thanks, RHEL 5) which lacked AM_CPPFLAGS.
      Modern Automake flags a warning that INCLUDES is deprecated, and
      now that we mandate RHEL 7 or better (see commit c1bc9c66), we no
      longer have to cater to the old spelling.  This change will also
      make it easier to do per-binary CPPFLAGS.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      Reviewed-by: NJán Tomko <jtomko@redhat.com>
      1862a554
    • E
      maint: Drop unused GETTEXT_CPPFLAGS variable · 7a879323
      Eric Blake 提交于
      Commit c0a8ea45 removed the use of gettextize, and the setting of
      GETTEXT_CPPFLAGS, but did not scrub the now-unused variable from
      Makefile.am snippets.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      Reviewed-by: NJán Tomko <jtomko@redhat.com>
      7a879323
    • E
      maint: split long lines for BSD syntax-check · ab51b22c
      Eric Blake 提交于
      Similar to the gnulib changes we just incorporated into maint.mk,
      it's time to use '$(VC_LIST) | xargs program' instead of
      'program $$($(VC_LIST))', in order to bypass the problem of hitting
      argv limits due to our large set of files.
      
      Drop several uses of $$files as a temporary variable when we can
      instead directly use xargs. While at it, fix a typo in the
      prohibit_windows_special_chars error message.
      
      Note that 'grep $pattern $(generate list)' has be be rewritten
      as 'generate list | xargs grep $pattern /dev/null' - this is
      because for a list that is just long enough, and without /dev/null,
      xargs could make a worst-case split of 'grep $pattern all but one;
      grep $pattern last' which has different output (grep includes the
      filename when there was more than one file, but omits it for a
      single file), while our conversion gives 'grep $pattern /dev/null
      all but one; grep $pattern /dev/null last'. We are less concerned
      about the empty list case (why would we run the syntax check if we
      didn't have at least one file?), but grepping /dev/null happens to
      produce no output and thus nicely also solves that problem without
      relying on the GNU extension of 'xargs -r'.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      Reviewed-by: NJán Tomko <jtomko@redhat.com>
      ab51b22c
    • E
      maint: prefer $(GREP) in cfg.mk · 2e258dae
      Eric Blake 提交于
      We already used $(GREP) in some places, but might as well use it
      everywhere during syntax check, in line with similar recent gnulib
      changes.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      Reviewed-by: NJán Tomko <jtomko@redhat.com>
      2e258dae
    • E
      maint: update gnulib for syntax-check on BSD · 7db886e7
      Eric Blake 提交于
      In particular, this incorporates Roman's patches to allow
      'make syntax-check' to work on BSD with its exec argv
      limitations that previously failed when trying to grep the
      large number of files present in libvirt.
      
      cfg.mk needs similar changes, but that will be tackled separately.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      Reviewed-by: NJán Tomko <jtomko@redhat.com>
      7db886e7
  2. 07 1月, 2019 4 次提交
  3. 04 1月, 2019 2 次提交
  4. 03 1月, 2019 1 次提交
  5. 02 1月, 2019 14 次提交
  6. 21 12月, 2018 5 次提交
  7. 19 12月, 2018 5 次提交