1. 15 7月, 2014 2 次提交
    • P
      qemu: blockcopy: Initialize correct source structure · 95d6aff7
      Peter Krempa 提交于
      4cc1f1a0 introduced a crash when doing a
      block copy as virStorageSourceInitChainElement was called on
      "disk->mirror" that is still NULL at that point instead of "mirror"
      which temporarily holds the mirror source struct until it's fully
      initialized. This resulted into a crash as a NULL was dereferenced.
      
      Reported by: Shanzi Yu <shyu@redhat.com>
      95d6aff7
    • J
      GetBlockInfo: Use the correct path to qemuOpenFile · 54d4619c
      John Ferlan 提交于
      Commit id '3ea661de' refactored the code to use the 'disk->src->path'
      instead of getting the path from virDomainDiskGetSource().  The one
      call to qemuOpenFile() didn't use the disk source path, rather it used
      the path as passed from the caller (in this case 'vda') - this caused
      a failure with the virt-test/tp-libvirt as follows:
      
      $ virsh domblkinfo virt-tests-vm1 vda
      error: cannot stat file '/home/virt-test/shared/data/images/jeos-20-64.qcow2': Bad file descriptor
      
      $
      54d4619c
  2. 14 7月, 2014 8 次提交
    • E
      capabilities: use bool instead of int · 58156f39
      Eric Blake 提交于
      While preparing to add a capability for active commit, I noticed
      that the existing code was abusing int for boolean values.
      
      * src/conf/capabilities.h (_virCapsGuestFeature, _virCapsHost)
      (virCapabilitiesNew, virCapabilitiesAddGuestFeature): Improve
      types.
      * src/conf/capabilities.c (virCapabilitiesNew)
      (virCapabilitiesAddGuestFeature): Adjust signature.
      * src/bhyve/bhyve_capabilities.c (virBhyveCapsBuild): Update
      clients.
      * src/esx/esx_driver.c (esxCapsInit): Likewise.
      * src/libxl/libxl_conf.c (libxlMakeCapabilities): Likewise.
      * src/lxc/lxc_conf.c (virLXCDriverCapsInit): Likewise.
      * src/openvz/openvz_conf.c (openvzCapsInit): Likewise.
      * src/parallels/parallels_driver.c (parallelsBuildCapabilities):
      Likewise.
      * src/phyp/phyp_driver.c (phypCapsInit): Likewise.
      * src/qemu/qemu_capabilities.c (virQEMUCapsInit)
      (virQEMUCapsInitGuestFromBinary): Likewise.
      * src/security/virt-aa-helper.c (get_definition): Likewise.
      * src/test/test_driver.c (testBuildCapabilities): Likewise.
      * src/uml/uml_conf.c (umlCapsInit): Likewise.
      * src/vbox/vbox_tmpl.c (vboxCapsInit): Likewise.
      * src/vmware/vmware_conf.c (vmwareCapsInit): Likewise.
      * src/xen/xen_hypervisor.c (xenHypervisorBuildCapabilities):
      Likewise.
      * src/xenapi/xenapi_driver.c (getCapsObject): Likewise.
      * tests/qemucaps2xmltest.c (testGetCaps): Likewise.
      * tests/testutils.c (virTestGenericCapsInit): Likewise.
      * tests/testutilslxc.c (testLXCCapsInit): Likewise.
      * tests/testutilsqemu.c (testQemuCapsInit): Likewise.
      * tests/testutilsxen.c (testXenCapsInit): Likewise.
      * tests/vircaps2xmltest.c (buildVirCapabilities): Likewise.
      * tests/vircapstest.c (buildNUMATopology): Likewise.
      * tests/vmx2xmltest.c (testCapsInit): Likewise.
      * tests/xml2vmxtest.c (testCapsInit): Likewise.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      58156f39
    • E
      docs: mention more about older capability feature bits · 06cf86e9
      Eric Blake 提交于
      Our documentation for features was rather sparse; this fleshes out
      more of the details for other existing capabilities (and cost me
      some time trawling git history).
      
      * docs/formatcaps.html.in: Document it feature bits.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      06cf86e9
    • C
      openvswitch: Delete port if it exists while adding a new one · 33445ce8
      Chunhe Li 提交于
      If the openvswitch service is stopped, and is followed by destroying a
      VM, the openvswitch bridge translates into a state where it doesn't
      recover the port configuration. While it successfully fetches data
      from the internal DB, since the corresponding virtual interface does
      not exists anymore the whole recovery process fails leaving restarted
      VM with inability to connect to the bridge. The following set of
      commands will trigger the problem:
      
      virsh start vm
      service openvswitch-switch stop
      virsh destroy vm
      service openvswitch-switch start
      virsh start vm
      Signed-off-by: NChunhe Li <lichunhe@huawei.com>
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      33445ce8
    • J
      virseclabel: Resolve Coverity FORWARD_NULL issue · 1c89f6eb
      John Ferlan 提交于
      Resolve issue introduced by commit id '13adf1b2'
      1c89f6eb
    • M
      virSecurityLabelDefParseXML: Rework · da78351b
      Michal Privoznik 提交于
      Instead of allocating the virSecurityLabelDef structure ourselves, we
      can utilize virSecurityLabelDefNew which even sets the default values
      for us.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      da78351b
    • M
      conf: Always format seclabel's model · 99c8d2e8
      Michal Privoznik 提交于
      https://bugzilla.redhat.com/show_bug.cgi?id=1113860
      
      We've always done that. Well, until 990e46c4. Point is, if we don't
      format model, we may lose a domain on libvirtd restart. If the
      seclabel is implicit however, we should skip it's formatting.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      99c8d2e8
    • P
      doc: Be more specific about semantics of _REUSE_EXT flag · 6f04fb15
      Peter Krempa 提交于
      Snapshots and block-copy have a flag that forces qemu to re-use existing
      file. Our docs weren't exactly clear on what the existing file should
      contain for this to actually work.
      
      Re-word the docs a bit to state that the file needs to be pre-created in
      the desired format and the backing chain metadata needs to be set prior
      to handing it over to qemu.
      
      Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1084360
      6f04fb15
    • P
      doc: Document that snapshot name of block-backed disk isn't autogenerated · 500f80a5
      Peter Krempa 提交于
      Libvirt generates external snapshot target file names for file backed
      storage but not for block backed storage. Document the limitation.
      
      Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1032363
      500f80a5
  3. 12 7月, 2014 3 次提交
  4. 11 7月, 2014 6 次提交
  5. 10 7月, 2014 4 次提交
    • J
      check for cfg->spiceTLS earlier in qemuProcessSPICEAllocatePorts · b02fca79
      Ján Tomko 提交于
      This saves a few lines of code and catches the error when:
      <spice autoport ='yes' defaultMode='any' ..>
        <channel name='main' mode='secure'/>
      </spice>
      is specified with spice_tls = 0 in qemu.conf.
      
      Instead of this error in qemuBuildGraphicsSPICECommandLine:
      error: unsupported configuration: spice secure channels set in XML
      configuration, but TLS port is not provided
      
      an error is reported in qemuProcessSPICEAllocatePorts:
      error: unsupported configuration: Auto allocation of spice TLS port
      requested but spice TLS is disabled in qemu.conf
      
      Inspired by:
      https://www.redhat.com/archives/libvir-list/2014-June/msg01408.html
      b02fca79
    • E
      build: package .pc files for mingw64 · ddf6b139
      Eric Blake 提交于
      Commit 65d8c92a fixed the mingw spec file for 32-bit builds,
      but forgot to make the adjustment for 64-bit builds:
      
      Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/eblake/rpmbuild/BUILDROOT/mingw-libvirt-1.2.7-1.fc20.eblake1404944503.x86_64
      error: Installed (but unpackaged) file(s) found:
         /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/libvirt-lxc.pc
         /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/libvirt-qemu.pc
      
      * mingw-libvirt.spec.in (%files): List missing .pc files.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      ddf6b139
    • E
      build: fix gnulib build for mingw · 0c33633f
      Eric Blake 提交于
      Pavel flagged a build regression under mingw, and traced it to a
      recent flaw in gnulib for working around nl_langinfo. This picks
      up the fix.
      
      * gnulib: Update to latest, for mingw build fixes.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      0c33633f
    • O
      libxl: add discard support to libxl_device_disk · 4e7e5e9f
      Olaf Hering 提交于
      Translate libvirt discard settings into libxl-4.5 discard settings.
      Signed-off-by: NOlaf Hering <olaf@aepfle.de>
      4e7e5e9f
  6. 09 7月, 2014 17 次提交