1. 11 7月, 2013 1 次提交
  2. 10 7月, 2013 1 次提交
  3. 29 6月, 2013 1 次提交
    • J
      Resolve valgrind error in virNetDevVlanParse() · babb57aa
      John Ferlan 提交于
      Commit '861d4056' introduced the following:
      
      TEST: networkxml2xmltest
            ..................                       18  OK
      ==25504== 7 bytes in 1 blocks are definitely lost in loss record 5 of 23
      ==25504==    at 0x4A0887C: malloc (vg_replace_malloc.c:270)
      ==25504==    by 0x37C1085D71: strdup (strdup.c:42)
      ==25504==    by 0x4CB835F: virStrdup (virstring.c:546)
      ==25504==    by 0x4CC5179: virXPathString (virxml.c:90)
      ==25504==    by 0x4CC75C2: virNetDevVlanParse (netdev_vlan_conf.c:78)
      ==25504==    by 0x4CF928A: virNetworkPortGroupParseXML (network_conf.c:1555)
      ==25504==    by 0x4CFE385: virNetworkDefParseXML (network_conf.c:2049)
      ==25504==    by 0x4D0113B: virNetworkDefParseNode (network_conf.c:2273)
      ==25504==    by 0x4D01254: virNetworkDefParse (network_conf.c:2234)
      ==25504==    by 0x401E80: testCompareXMLToXMLHelper (networkxml2xmltest.c:32)
      ==25504==    by 0x402D4F: virtTestRun (testutils.c:158)
      ==25504==    by 0x401CE9: mymain (networkxml2xmltest.c:110)
      ==25504==
      PASS: networkxml2xmltest
      
      Also changed the label from error to cleanup and adjusted code since it's
      all one exit path
      babb57aa
  4. 25 6月, 2013 1 次提交
  5. 08 2月, 2013 1 次提交
  6. 21 12月, 2012 2 次提交
  7. 21 9月, 2012 1 次提交
  8. 16 8月, 2012 1 次提交
    • L
      conf: add <vlan> element to network and domain interface elements · 3f9274a5
      Laine Stump 提交于
      The following config elements now support a <vlan> subelements:
      
      within a domain: <interface>, and the <actual> subelement of <interface>
      within a network: the toplevel, as well as any <portgroup>
      
      Each vlan element must have one or more <tag id='n'/> subelements.  If
      there is more than one tag, it is assumed that vlan trunking is being
      requested. If trunking is required with only a single tag, the
      attribute "trunk='yes'" should be added to the toplevel <vlan>
      element.
      
      Some examples:
      
        <interface type='hostdev'/>
          <vlan>
            <tag id='42'/>
          </vlan>
          <mac address='52:54:00:12:34:56'/>
          ...
        </interface>
      
        <network>
          <name>vlan-net</name>
          <vlan trunk='yes'>
            <tag id='30'/>
          </vlan>
          <virtualport type='openvswitch'/>
        </network>
      
        <interface type='network'/>
          <source network='vlan-net'/>
          ...
        </interface>
      
        <network>
          <name>trunk-vlan</name>
          <vlan>
            <tag id='42'/>
            <tag id='43'/>
          </vlan>
          ...
        </network>
      
        <network>
          <name>multi</name>
          ...
          <portgroup name='production'/>
            <vlan>
              <tag id='42'/>
            </vlan>
          </portgroup>
          <portgroup name='test'/>
            <vlan>
              <tag id='666'/>
            </vlan>
          </portgroup>
        </network>
      
        <interface type='network'/>
          <source network='multi' portgroup='test'/>
          ...
        </interface>
      
      IMPORTANT NOTE: As of this patch there is no backend support for the
      vlan element for *any* network device type. When support is added in
      later patches, it will only be for those select network types that
      support setting up a vlan on the host side, without the guest's
      involvement. (For example, it will be possible to configure a vlan for
      a guest connected to an openvswitch bridge, but it won't be possible
      to do that for one that is connected to a standard Linux host bridge.)
      3f9274a5