- 04 9月, 2009 23 次提交
-
-
由 Daniel Veillard 提交于
* libvirt.spec.in: activate phyp and fix the BuildDep to libssh2-devel * src/phyp/phyp_driver.c: fix a debug macro to use the normal logging API
-
由 Eduardo Otubo 提交于
* configure.in src/Makefile.am: change detection and flags * src/phyp/phyp_driver.c src/phyp/phyp_driver.h: connection now need to be done as part of the driver code, cleaned up by DV
-
由 Chris Lalancette 提交于
* src/remote_internal.c: in remoteOpen() allow the daemon itself to make RPCs to an external libvirtd, but only if the URI is fully specified.
-
由 Daniel P. Berrange 提交于
* src/qemu_driver.c: Free the vm->monitor_chr field at VM shutdown. Unlink the UNIX domain socket at VM shutdown to avoid littering FS with old sockets
-
由 Daniel P. Berrange 提交于
* src/qemu_driver.c: Change ownership of /var/{lib,cache}/libvirt/qemu to match user/group that QEMU VMs are configured to run as.
-
由 Daniel P. Berrange 提交于
Separate the guest created QEMU monitor socket location from the libvirtd create XML / PID data files, to improve security separation when running QEMU non-root * libvirt.spec.in: Leave /var/run/libvirt/qemu as root:root * src/qemu_conf.h: Add libDir and cacheDir directory paths * src/qemu_driver.c: Move QEMU monitor socket from stateDir to libDir to avoid making security critical directory accessible to QEMU guests. * src/util.c: Delay running hook till after damonizing to ensure pidfile is still written before changing UID/GID
-
由 Daniel P. Berrange 提交于
If a file descriptor with events=0 was added to the libvirtd event loop, it would still be added to the poll() fds' array. While it wouldn't see any POLLIN/OUT events, it'd still get triggered for HANGUP/ERROR events which was not in compliance with the libvirt events API contract. * qemud/event.c: Don't poll on FDs with events=0 * tests/eventtest.c: Add test case to validate fix to event.c
-
由 Jim Meyering 提交于
* src/xen_internal.c (xenHypervisorSetSchedulerParameters): Remove set-but-never-used local variables, cap_set and weight_set.
-
由 Matthias Bolte 提交于
* src/esx/esx_vi.c (esxVI_Enumeration_Deserialize): Fix reversed goto and result=-1 statements.
-
由 Jim Meyering 提交于
* python/libvir.c (libvirt_virConnectDomainEventCallback): Return 0 when successful, rather than always returning -1. clang flagged this function for its dead-store of "ret=0". Once "ret" was set to 0, it was never used, and the function would always return -1.
-
由 Jim Meyering 提交于
* qemud/mdns.c (libvirtd_mdns_client_callback): Remove dead initialization.
-
由 Jim Meyering 提交于
* src/node_device_conf.c (virNodeDeviceDefFormat): Remove dead initialization.
-
由 Jim Meyering 提交于
* src/openvz_conf.c (openvzReadNetworkConf): Initialize "net". Otherwise, upon openvzRead... failure, we would "goto error;" where an uninitialized "net" could be dereferenced.
-
由 Jim Meyering 提交于
* src/test.c (testOpenVolumesForPool): Upon early virAsprintf or virXPathNodeSet failure, "goto error" would take us to virStorageVolDefFree(def), but with "def" not defined. Initialize it to NULL.
-
由 Jim Meyering 提交于
* src/uml_conf.c (umlBuildCommandLineChr): Initialize "ret".
-
由 Jim Meyering 提交于
* src/storage_backend.c: Include "internal.h". (virStorageBackendCopyToFD): Mark inputvol parameter as "nonnull". Remove test for non-NULL inputvol. Both callers ensure it's non-NULL.
-
由 Jim Meyering 提交于
* src/libvirt.c (virStoragePoolSetAutostart): Return -1 if the pool argument is invalid, rather than "goto error" where we could dereference that possibly-NULL "pool". (virConnectFindStoragePoolSources): Likewise. (virConnectNumOfDomains): Likewise. Daniel P. Berrange spotted that the two latter functions needed the same treatment.
-
由 Jim Meyering 提交于
* src/remote_internal.c (remoteNetworkOpen): Mark "conn" parameter as non-NULL. Remove now-unnecessary "conn == NULL" test. (remoteDevMonOpen): Likewise. (remoteSecretOpen): Likewise. (remoteStorageOpen): Likewise. (remoteInterfaceOpen): Likewise.
-
由 Jim Meyering 提交于
* src/internal.h (ATTRIBUTE_NONNULL): Define.
-
由 Jim Meyering 提交于
* src/lxc_controller.c (main): Unlink sockpath only if it's non-NULL.
-
由 Jim Meyering 提交于
* src/lxc_container.c (lxcContainerUnmountOldFS): Don't pass a NULL pointer to qsort.
-
由 Jim Meyering 提交于
* src/storage_conf.c (virStorageSize): Don't try to compute 1024^7, since it's too large for a 64-bit type.
-
由 Jim Meyering 提交于
* src/storage_backend_fs.c (virStorageBackendFileSystemRefresh): Don't call closedir on a NULL pointer.
-
- 03 9月, 2009 7 次提交
-
-
由 Pritesh Kothari 提交于
* src/vbox/vbox_tmpl.c: merged vboxNetworkUndefine() and vboxNetworkDestroy() and added code to handle multiple hostonly interfaces.
-
由 Pritesh Kothari 提交于
* src/vbox/vbox_tmpl.c: merged vboxNetworkCreateXML() and vboxNetworkDefineXML() and added code to handle multiple hostonly interfaces.
-
由 Daniel P. Berrange 提交于
* docs/schemas/domain.rng: Add <serial> element to disks * src/domain_conf.h, src/domain_conf.c: XML parsing and formatting for disk serial numbers * src/qemu_conf.c: Set serial number when launching guests * tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.args, tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml: Add serial number to XML test
-
由 Daniel P. Berrange 提交于
Add option to domain XML for <memoryBacking> <hugepages/> </memoryBacking> * configure.in: Add check for mntent.h * qemud/libvirtd_qemu.aug, qemud/test_libvirtd_qemu.aug, src/qemu.conf Add 'hugetlbfs_mount' config parameter * src/qemu_conf.c, src/qemu_conf.h: Check for -mem-path flag in QEMU, and pass it when hugepages are requested. Load hugetlbfs_mount config parameter, search for mount if not given. * src/qemu_driver.c: Free hugetlbfs_mount/path parameter in driver shutdown. Create directory for QEMU hugepage usage, chowning if required. * docs/formatdomain.html.in: Document memoryBacking/hugepages elements * docs/schemas/domain.rng: Add memoryBacking/hugepages elements to schema * src/util.c, src/util.h, src/libvirt_private.syms: Add virFileFindMountPoint helper API * tests/qemuhelptest.c: Add -mem-path constants * tests/qemuxml2argvtest.c, tests/qemuxml2xmltest.c: Add tests for hugepage handling * tests/qemuxml2argvdata/qemuxml2argv-hugepages.xml, tests/qemuxml2argvdata/qemuxml2argv-hugepages.args: Data files for hugepage tests
-
由 Daniel P. Berrange 提交于
* tests/testutils.c: Run test function twice, once to prime it for static allocations, once to count the non-static allocations. * tests/testutilsqemu.c: Initialize variable correctl * src/capabilities.c: Don't free machines variable upon failure since caller must do that * src/xm_internal.c: Add missing check for OOM in building VIF config param
-
由 Pritesh Kothari 提交于
* src/vbox/vbox_tmpl.c: add setting of video and acceleration in VBox driver, and the ability to save this back for serialization
-
由 Pritesh Kothari 提交于
* docs/schemas/domain.rng: augment the video model with an optional acceleration element with optional accel2d and accel3d flags * src/domain_conf.c src/domain_conf.h: exten the virDomainVideoDef structure with an optional accel field, virDomainVideoAccelDefParseXML and virDomainVideoAccelDefFormat functions to parse and serialize the structure.
-
- 02 9月, 2009 10 次提交
-
-
由 Chris Lalancette 提交于
Paolo Bonzini points out that in my refactoring of the code for virDomainMigrate(), I added a check for the return value from virDomainMigratePerform(). The problem is that we don't want to exit if we fail, we actually want to go on and do virDomainMigrateFinish2() with a non-0 return code to clean things up. Remove the check. While reproducing this issue, I also noticed that we wouldn't always properly propagate an error message. In particular, I found that if you blocked off the migration ports (with iptables) and then tried the migration, it would actually fail but we would get no failure output from Qemu. Therefore, we would think we succeeded, and leave a huge mess behind us. Execute the monitor command "info migrate", and look for a failure string in there as well. Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
由 Matthias Bolte 提交于
* src/esx/esx_util.c: esxUtil_ParseQuery() warns if a known query parameter should be ignored due to the corresponding char/int pointer being NULL, instead of silently ignoring it. Fix the control flow.
-
由 Matthias Bolte 提交于
* src/esx/esx_vmx.c: add an extra type of addressType beside 'static' and 'generated', 'vpx' indicates that the MAC address was generated by a vCenter.
-
由 Daniel P. Berrange 提交于
Calling qsort() on the disks array causes disk to be unneccessarily re-ordered, potentially breaking the ability to boot if the boot disk gets moved later in the list. The new algorithm will insert a new disk as far to the end of the list as possible, while being ordered correctly wrt other disks on the same bus. * src/domain_conf.c, src/domain_conf.h: Remove disk sorting routines. Add API to insert a disk into existing list at the optimal position, without resorting disks * src/libvirt_private.syms: Export virDomainDiskInsert * src/xend_internal.c, src/xm_internal.c: Remove calls to qsort, use virDomainDiskInsert instead. * src/qemu_driver.c: Remove calls to qsort, use virDoaminDiskInsert instead. Fix reordering bugs when hotunplugging disks and networks. Fix memory leak in disk/net unplug
-
由 Pritesh Kothari 提交于
* src/vbox/vbox_tmpl.c: adds support for getting/setting number of cpus
-
由 Daniel P. Berrange 提交于
* proxy/Makefile.am: Build storage_encryption_conf.c since its a dependancy of domain_conf.c * src/storage_encryption_conf.c: Disable XML parsing APis when build under proxy * src/test.c: Add a dummy no-op secrets driver for test suite
-
由 Daniel P. Berrange 提交于
* libvirt.spec.in: Conditionalize glusterfs requires line for Fedora >= 11, since other distros don't have it available
-
由 Daniel P. Berrange 提交于
* src/storage_encryption_conf.c: Remove base64.h
-
由 Daniel P. Berrange 提交于
-
由 Miloslav Trmač 提交于
* src/qemu_driver.c: Support arbitrary callbacks for "secondary prompts". Reimplement qemudMonitorCommandExtra using such a callback.
-