1. 19 6月, 2008 1 次提交
    • C
      For 0.4.3, danpb's new memory management scheme went into libvirt. This is · 0aa6eedd
      Chris Lalancette 提交于
      fine, except that is subtly alters the semantics of malloc(), calloc(), and
      realloc().  In particular, if you say:
      
      foo = malloc(0);
      
      glibc will happily return a non-NULL pointer to you.  However, with the new
      memory management stuff, if you say:
      
      foo = VIR_ALLOC(0);
      
      you will actually get a NULL pointer back.  Personally, I think this is a
      dangerous deviation from malloc() semantics that everyone is used to, and is
      indeed causing problems with the remote driver.  The short of it is that the
      remote driver allocates memory on behalf of the remote side using VIR_ALLOC_N,
      and this call is returning NULL so that the NULL checks elsewhere in the code
      fire and return failure.
      
      The attached patch fixes this situation by removing the 0 checks from the memory
      allocation paths, and just lets them fall through to the normal malloc(),
      calloc(), or realloc() routines, restoring old semantics.
      Signed-off-by: NChris Lalancette <clalance@redhat.com>
      0aa6eedd
  2. 06 6月, 2008 2 次提交
  3. 30 5月, 2008 1 次提交
  4. 29 5月, 2008 1 次提交
  5. 07 5月, 2008 1 次提交
  6. 29 4月, 2008 2 次提交