1. 02 7月, 2013 9 次提交
    • G
      LXC: enable user namespace only when user set the uidmap · 8b58336e
      Gao feng 提交于
      User namespace will be enabled only when the idmap exist
      in configuration.
      
      If you want disable user namespace,just remove these
      elements from XML.
      
      If kernel doesn't support user namespace and idmap exist
      in configuration file, libvirt lxc will start failed and
      return "Kernel doesn't support user namespace" message.
      Signed-off-by: NGao feng <gaofeng@cn.fujitsu.com>
      8b58336e
    • G
      LXC: Introduce New XML element for user namespace · 6c30ea2c
      Gao feng 提交于
      This patch introduces new element <idmap> for
      user namespace. for example
      <idmap>
          <uid start='0' target='1000' count='10'/>
          <gid start='0' target='1000' count='10'/>
      </idmap>
      
      this new element is used for setting proc files
      /proc/<pid>/{uid_map,gid_map}.
      
      This patch also supports multiple uid/gid elements
      setting in XML configuration.
      
      We don't support the semi configuation, user has to
      configure uid and gid both.
      Signed-off-by: NGao feng <gaofeng@cn.fujitsu.com>
      6c30ea2c
    • P
      qemu: Improve info message and remove a variable in qemuDomainManagedSave · cbba3268
      Peter Krempa 提交于
      Mention the domain name that is being saved and remove the unneeded
      variable that only stores a constant.
      cbba3268
    • P
      docs: Document hypervisor drivers that support certain timer models · 23770d7b
      Peter Krempa 提交于
      Not every timer model is supported with each hypervisor. Explicitly
      mention the driver supporting each timer model.
      23770d7b
    • J
      qemu: fix return value of qemuDomainBlockPivot on errors · c34107df
      Ján Tomko 提交于
      If qemuMonitorBlockJob returned 0, qemuDomainBlockPivot
      might return 0 even if an error occured.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=977678
      c34107df
    • D
      libxl: implement per NUMA node free memory reporting · 4b9eec50
      Dario Faggioli 提交于
      By providing the implementation of nodeGetCellsFreeMemory for
      the driver. This is all just a matter of properly formatting, in
      a way that libvirt like, what Xen provides via libxl_get_numainfo().
      
      [raistlin@Zhaman ~]$ sudo virsh --connect xen:/// freecell --all
          0:      25004 KiB
          1:     105848 KiB
      --------------------
      Total:     130852 KiB
      Signed-off-by: NDario Faggioli <dario.faggioli@citrix.com>
      4b9eec50
    • E
      build: configure must not affect tarball contents · d79c9273
      Eric Blake 提交于
      On mingw, configure sets the name of the lxc symfile to
      libvirt_lxc.defs rather than libvirt_lxc.syms.  But tarballs
      must be arch-independent, regardless of the configure options
      used for the tree where we ran 'make dist'.  This led to the
      following failure in autobuild.sh:
      
        CCLD     libvirt-lxc.la
        CCLD     libvirt-qemu.la
      /usr/lib64/gcc/i686-w64-mingw32/4.7.2/../../../../i686-w64-mingw32/bin/ld: cannot find libvirt_lxc.def: No such file or directory
      collect2: error: ld returned 1 exit status
      make[3]: *** [libvirt-lxc.la] Error 1
      make[3]: *** Waiting for unfinished jobs....
      
      We were already doing the right thing with libvirt_qemu.syms.
      
      * src/Makefile.am (EXTRA_DIST): Don't ship a built file which
      depends on configure for its final name.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      d79c9273
    • E
      build: avoid build failure without gnutls · 4e6a78e7
      Eric Blake 提交于
      Found while trying to cross-compile to mingw:
      
        CC       libvirt_driver_remote_la-remote_driver.lo
      ../../src/remote/remote_driver.c: In function 'doRemoteOpen':
      ../../src/remote/remote_driver.c:487:23: error: variable 'verify' set but not used [-Werror=unused-but-set-variable]
      
      * src/remote/remote_driver.c (doRemoteOpen): Also ignore 'verify'.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      4e6a78e7
    • R
      Drop iptablesContext · 477a619e
      Roman Bogorodskiy 提交于
      iptablesContext holds only 4 pairs of iptables
      (table, chain) and there's no need to pass
      it around.
      
      This is a first step towards separating bridge_driver.c
      in platform-specific parts.
      477a619e
  2. 01 7月, 2013 7 次提交
    • J
      qemu: indentation fix · 87bbf83f
      Ján Tomko 提交于
      87bbf83f
    • M
      qemu: Implement CPUs check against machine type's cpu-max · ff968889
      Michal Novotny 提交于
      Implement check whether (maximum) vCPUs doesn't exceed machine
      type's cpu-max settings.
      
      On older versions of QEMU the check is disabled.
      Signed-off-by: NMichal Novotny <minovotn@redhat.com>
      ff968889
    • D
      Release of libvirt-1.1.0 · 034d3229
      Daniel Veillard 提交于
      * configure.ac docs/news.html.in libvirt.spec.in: updated for the release
      * po/*.po*: updated localizations and regenerated
      034d3229
    • D
      Crash of libvirtd by unprivileged user in virConnectListAllInterfaces · 244e0b8c
      Daniel P. Berrange 提交于
      On Thu, Jun 27, 2013 at 03:56:42PM +0100, Daniel P. Berrange wrote:
      > Hi Security Team,
      >
      > I've discovered a way for an unprivileged user with a readonly connection
      > to libvirtd, to crash the daemon.
      
      Ok, the final patch for this is issue will be the simpler variant that
      Eric suggested
      
      The embargo can be considered to be lifted on Monday July 1st, at
      0900 UTC
      
      The following is the GIT change that DV or myself will apply to libvirt
      GIT master immediately before the 1.1.0 release:
      
      >From 177b4165c531a4b3ba7f6ab6aa41dca9ceb0b8cf Mon Sep 17 00:00:00 2001
      From: "Daniel P. Berrange" <berrange@redhat.com>
      Date: Fri, 28 Jun 2013 10:48:37 +0100
      Subject: [PATCH] CVE-2013-2218: Fix crash listing network interfaces with
       filters
      
      The virConnectListAllInterfaces method has a double-free of the
      'struct netcf_if' object when any of the filtering flags cause
      an interface to be skipped over. For example when running the
      command 'virsh iface-list --inactive'
      
      This is a regression introduced in release 1.0.6 by
      
        commit 7ac2c4fe
        Author: Guannan Ren <gren@redhat.com>
        Date:   Tue May 21 21:29:38 2013 +0800
      
          interface: list all interfaces with flags == 0
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      244e0b8c
    • L
      pci: initialize virtual_functions array pointer to avoid segfault · 2c2525ab
      Laine Stump 提交于
      This fixes https://bugzilla.redhat.com/show_bug.cgi?id=971325
      
      The problem was that if virPCIGetVirtualFunctions was given the name
      of a non-existent interface, it would return to its caller without
      initializing the pointer to the array of virtual functions to NULL,
      and the caller (virNetDevGetVirtualFunctions) would try to VIR_FREE()
      the invalid pointer.
      
      The final error message before the crash would be:
      
       virPCIGetVirtualFunctions:2088 :
        Failed to open dir '/sys/class/net/eth2/device':
        No such file or directory
      
      In this patch I move the initialization in virPCIGetVirtualFunctions()
      to the begining of the function, and also do an explicit
      initialization in virNetDevGetVirtualFunctions, just in case someone
      in the future adds code into that function prior to the call to
      virPCIGetVirtualFunctions.
      2c2525ab
    • L
      node device driver: update driver name during dumpxml · 374c5e4f
      Laine Stump 提交于
      This fixes:
      
        https://bugzilla.redhat.com/show_bug.cgi?id=979290
        https://bugzilla.redhat.com/show_bug.cgi?id=979330
      
      The node device driver was written with the assumption that udev would
      use a "change" event to notify libvirt of any change to device status
      (including the name of the driver it was bound to). It turns out this
      is not the case (see Comment 4 of BZ 979290). That means that a
      dumpxml for a device would always show whatever driver happened to be
      bound at the time libvirt was started (when the node device cache was
      built).
      
      There was already code in the driver (for the benefit of the HAL
      backend) that updated the driver name from sysfs each time a device's
      info was retrieved from the cache. This patch just enables that manual
      update for the udev backend as well.
      374c5e4f
    • D
      Document security reporting & handling process · 49e6a16f
      Daniel P. Berrange 提交于
      Historically security issues in libvirt have been primarily
      triaged & fixed by the Red Hat libvirt members & Red Hat
      security team, who then usually notify other vendors via
      appropriate channels. There have been a number of times
      when vendors have not been properly notified ahead of
      announcement. It has also disadvantaged community members
      who have to backport fixes to releases for which there are
      no current libvirt stable branches.
      
      To address this, we want to make the libvirt security process
      entirely community focused / driven. To this end I have setup
      a new email address "libvirt-security@redhat.com" for end
      users to report bugs which have (possible) security implications.
      
      This email addr is backed by an invitation only, private
      archive, mailing list. The intent is for the list membership
      to comprise a subset of the libvirt core team, along with any
      vendor security team engineers who wish to participate in a
      responsible disclosure process for libvirt. Members of the
      list will be responsible for analysing the problem to determine
      if a security issue exists and then issue fixes for all current
      official stable branches & git master.
      
      I am proposing the following libvirt core team people as
      members of the security team / list (all cc'd):
      
         Daniel Berrange (Red Hat)
         Eric Blake (Red Hat)
         Jiri Denemar (Red Hat)
         Daniel Veillard (Red Hat)
         Jim Fehlig (SUSE)
         Doug Goldstein (Gentoo)
         Guido Günther (Debian)
      
      We don't have anyone from Ubuntu on the libvirt core team.
      Serge Hallyn is the most frequent submitter of patches from
      Ubuntu in recent history, so I'd like to invite him to join.
      Alternatively, Serge, feel free to suggest someone else to
      represent Ubuntu's interests.
      
      If any other vendors/distros have security people who are
      responsible for dealing with libvirt security issues, and
      want to join to get early disclosure of issues, they can
      suggest people. Existing security team members will vet /
      approve such requests to ensure they are genuine.
      
      Anyone on the team / list will be **required** to honour any
      embargo period agreed between members for non-public issues
      that are reported. The aim will be to have a maximum 2 week
      embargo period in the common case, extendable to 1 month if
      there is sufficient justification made. If anyone feels they
      are unable to follow such an embargo process for whatever
      reason, please decline membership of the security list/team.
      
      The patch which follows puts up some docs on the website
      about all of this....
      
      Document how to report security bugs and the process that
      will be used for addressing them.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      49e6a16f
  3. 30 6月, 2013 1 次提交
    • E
      spec: require xen-devel for libxl driver · 3a214482
      Eric Blake 提交于
      When using 'rpmbuild --define "_without_xen 1"', but on a new enough
      Fedora where %{with_libxl} still gets set to 1 by default, the
      build dependencies were incomplete, which could result in 'make rpm'
      failing because ./configure failed to build the libxl driver.
      
      * libvirt.spec.in (BuildRequires): Fix xen-devel condition.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      3a214482
  4. 29 6月, 2013 5 次提交
    • J
      Resolve valgrind errors for nodedev cap parsing · 79e9a224
      John Ferlan 提交于
      There were two errors, one as a direct result of commit id '8807b285'
      and the other from cut-n-paste
      
      TEST: nodedevxml2xmltest
            ..............                           14  OK
      ==25735== 3 bytes in 1 blocks are definitely lost in loss record 1 of 24
      ==25735==    at 0x4A0887C: malloc (vg_replace_malloc.c:270)
      ==25735==    by 0x344D2AF275: xmlStrndup (in /usr/lib64/libxml2.so.2.9.1)
      ==25735==    by 0x4D0C767: virNodeDeviceDefParseNode (node_device_conf.c:997)
      ==25735==    by 0x4D0D3D2: virNodeDeviceDefParse (node_device_conf.c:1337)
      ==25735==    by 0x401CA4: testCompareXMLToXMLHelper (nodedevxml2xmltest.c:28)
      ==25735==    by 0x402B2F: virtTestRun (testutils.c:158)
      ==25735==    by 0x401B27: mymain (nodedevxml2xmltest.c:81)
      ==25735==    by 0x40316A: virtTestMain (testutils.c:722)
      ==25735==    by 0x37C1021A04: (below main) (libc-start.c:225)
      ==25735==
      ==25735== 16 bytes in 1 blocks are definitely lost in loss record 10 of 24
      ==25735==    at 0x4A08A6E: realloc (vg_replace_malloc.c:662)
      ==25735==    by 0x4C7385E: virReallocN (viralloc.c:184)
      ==25735==    by 0x4C73906: virExpandN (viralloc.c:214)
      ==25735==    by 0x4C73B4A: virInsertElementsN (viralloc.c:324)
      ==25735==    by 0x4D0C84C: virNodeDeviceDefParseNode (node_device_conf.c:1026)
      ==25735==    by 0x4D0D3D2: virNodeDeviceDefParse (node_device_conf.c:1337)
      ==25735==    by 0x401CA4: testCompareXMLToXMLHelper (nodedevxml2xmltest.c:28)
      ==25735==    by 0x402B2F: virtTestRun (testutils.c:158)
      ==25735==    by 0x401B27: mymain (nodedevxml2xmltest.c:81)
      ==25735==    by 0x40316A: virtTestMain (testutils.c:722)
      ==25735==    by 0x37C1021A04: (below main) (libc-start.c:225)
      ==25735==
      PASS: nodedevxml2xmltest
      
      The first error was resolved by adding a missing VIR_FREE(numberStr); in
      the new function virNodeDevCapPciDevIommuGroupParseXML().
      
      The second error was a bit more opaque as the error was a result of copying
      the free methodolgy of the existing code in virNodeDevCapsDefFree(). The code
      would free each of the entries in the array, but not the memory for the
      array itself.  Added the necessary VIR_FREE(data->pci_dev.iommuGroupDevices)
      and while at it added the missing VIR_FREE(data->pci_dev.virtual_functions)
      although there wasn't a test that tripped across it (thus it's been lurking
      since commit id 'a010165d').
      79e9a224
    • J
      Resolve valgrind error in remoteConfigGetStringList() · ba6e187f
      John Ferlan 提交于
      Commit id 'ed3bac71' introduced the following:
      
      TEST: libvirtdconftest
            ........................................ 40  OK
      ==25875== 690 (480 direct, 210 indirect) bytes in 30 blocks are definitely lost in loss record 18 of 24
      ==25875==    at 0x4A06B6F: calloc (vg_replace_malloc.c:593)
      ==25875==    by 0x4C737DF: virAllocN (viralloc.c:152)
      ==25875==    by 0x403BC8: remoteConfigGetStringList (libvirtd-config.c:74)
      ==25875==    by 0x4042CF: daemonConfigLoadOptions (libvirtd-config.c:382)
      ==25875==    by 0x4052F5: daemonConfigLoadData (libvirtd-config.c:479)
      ==25875==    by 0x40222C: testCorrupt (libvirtdconftest.c:112)
      ==25875==    by 0x40321F: virtTestRun (testutils.c:158)
      ==25875==    by 0x401FEE: mymain (libvirtdconftest.c:228)
      ==25875==    by 0x40385A: virtTestMain (testutils.c:722)
      ==25875==    by 0x37C1021A04: (below main) (libc-start.c:225)
      ==25875==
      PASS: libvirtdconftest
      ba6e187f
    • J
      Resolve valgrind error in virStorageBackendCreateQemuImgCmd() · 164d46e8
      John Ferlan 提交于
      Commit id '53d5967c' introduced the following:
      
      TEST: storagevolxml2argvtest
            ..............                           14  OK
      ==25636== 358 (264 direct, 94 indirect) bytes in 1 blocks are definitely lost in loss record 67 of 75
      ==25636==    at 0x4A06B6F: calloc (vg_replace_malloc.c:593)
      ==25636==    by 0x4C95791: virAlloc (viralloc.c:124)
      ==25636==    by 0x4CA0BB4: virCommandNewArgs (vircommand.c:805)
      ==25636==    by 0x4CA0C88: virCommandNew (vircommand.c:789)
      ==25636==    by 0x408602: virStorageBackendCreateQemuImgCmd (storage_backend.c:849)
      ==25636==    by 0x405427: testCompareXMLToArgvHelper (storagevolxml2argvtest.c:61)
      ==25636==    by 0x4064DF: virtTestRun (testutils.c:158)
      ==25636==    by 0x40516F: mymain (storagevolxml2argvtest.c:195)
      ==25636==    by 0x406B1A: virtTestMain (testutils.c:722)
      ==25636==    by 0x37C1021A04: (below main) (libc-start.c:225)
      ==25636==
      PASS: storagevolxml2argvtest
      164d46e8
    • J
      Resolve valgrind error in virNetDevVlanParse() · babb57aa
      John Ferlan 提交于
      Commit '861d4056' introduced the following:
      
      TEST: networkxml2xmltest
            ..................                       18  OK
      ==25504== 7 bytes in 1 blocks are definitely lost in loss record 5 of 23
      ==25504==    at 0x4A0887C: malloc (vg_replace_malloc.c:270)
      ==25504==    by 0x37C1085D71: strdup (strdup.c:42)
      ==25504==    by 0x4CB835F: virStrdup (virstring.c:546)
      ==25504==    by 0x4CC5179: virXPathString (virxml.c:90)
      ==25504==    by 0x4CC75C2: virNetDevVlanParse (netdev_vlan_conf.c:78)
      ==25504==    by 0x4CF928A: virNetworkPortGroupParseXML (network_conf.c:1555)
      ==25504==    by 0x4CFE385: virNetworkDefParseXML (network_conf.c:2049)
      ==25504==    by 0x4D0113B: virNetworkDefParseNode (network_conf.c:2273)
      ==25504==    by 0x4D01254: virNetworkDefParse (network_conf.c:2234)
      ==25504==    by 0x401E80: testCompareXMLToXMLHelper (networkxml2xmltest.c:32)
      ==25504==    by 0x402D4F: virtTestRun (testutils.c:158)
      ==25504==    by 0x401CE9: mymain (networkxml2xmltest.c:110)
      ==25504==
      PASS: networkxml2xmltest
      
      Also changed the label from error to cleanup and adjusted code since it's
      all one exit path
      babb57aa
    • P
      doc: Fix reference to #elementsUSB · dc8614d7
      Philipp Hahn 提交于
      aae0fc2a removed the #elementsUSB anchor
      but did not update the links to point to the new section #elementsHostDev.
      Signed-off-by: NPhilipp Hahn <hahn@univention.de>
      dc8614d7
  5. 28 6月, 2013 8 次提交
  6. 27 6月, 2013 4 次提交
    • X
      virsh: Add parenthesis into virsh nodedev-detach help · f542a0de
      xuzhang 提交于
      f542a0de
    • J
      bridge: don't crash on bandwidth unplug with no bandwidth · 658c932a
      Ján Tomko 提交于
      If networkUnplugBandwidth is called on a network which has
      no bandwidth defined, print a warning instead of crashing.
      
      This can happen when destroying a domain with bandwidth if
      bandwidth was removed from the network after the domain was
      started.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=975359
      658c932a
    • L
      nodedev: add iommuGroup to node device object · 8807b285
      Laine Stump 提交于
      This includes adding it to the nodedev parser and formatter, docs, and
      test.
      
      An example of the new iommuGroup element that is a part of the output
      from "virsh nodedev-dumpxml" (virNodeDeviceGetXMLDesc()):
      
        <device>
          <name>pci_0000_02_00_1</name>
          <capability type='pci'>
          ...
            <iommuGroup number='12'>
              <address domain='0x0000' bus='0x02' slot='0x00' function='0x0'/>
              <address domain='0x0000' bus='0x02' slot='0x00' function='0x1'/>
            </iommuGroup>
          </capability>
        </device>
      8807b285
    • L
      pci: new iommu_group functions · 72c029d8
      Laine Stump 提交于
      Any device which belongs to an "IOMMU group" (used by vfio) will
      have links to all devices of its group listed in
      /sys/bus/pci/$device/iommu_group/devices;
      /sys/bus/pci/$device/iommu_group is actually a link to
      /sys/kernel/iommu_groups/$n, where $n is the group number (there
      will be a corresponding device node at /dev/vfio/$n once the
      devices are bound to the vfio-pci driver)
      
      The following functions are added:
      
      virPCIDeviceGetIOMMUGroupList
      
        Gets a virPCIDeviceList with one virPCIDeviceList for each device
        in the same IOMMU group as the provided virPCIDevice (a copy of the
        original device object is included in the list.
      
      virPCIDeviceAddressIOMMUGroupIterate
      
        Calls the function @actor once for each device in the group that
        contains the given virPCIDeviceAddress.
      
      virPCIDeviceAddressGetIOMMUGroupAddresses
      
        Fills in a virPCIDeviceAddressPtr * with an array of
        virPCIDeviceAddress, one for each device in the iommu group of the
        provided virPCIDeviceAddress (including a copy of the original).
      
      virPCIDeviceAddressGetIOMMUGroupNum
      
        Returns the group number as an int (a valid group number will always
        be 0 or greater).  If there is no iommu_group link in the device's
        directory (usually indicating that vfio isn't loaded), -2 will be
        returned. On any real error, -1 will be returned.
      72c029d8
  7. 26 6月, 2013 6 次提交
    • J
      Plug leak in virCgroupMoveTask · 5bc8ecb8
      Ján Tomko 提交于
      We only break out of the while loop if *content is an empty string.
      However the buffer has been allocated to BUFSIZ + 1 (8193 in my case),
      but it gets overwritten in the next for iteration.
      
      Move VIR_FREE right before we overwrite it to avoid the leak.
      
      ==5777== 16,386 bytes in 2 blocks are definitely lost in loss record 1,022 of 1,027
      ==5777==    by 0x5296E28: virReallocN (viralloc.c:184)
      ==5777==    by 0x52B0C66: virFileReadLimFD (virfile.c:1137)
      ==5777==    by 0x52B0E1A: virFileReadAll (virfile.c:1199)
      ==5777==    by 0x529B092: virCgroupGetValueStr (vircgroup.c:534)
      ==5777==    by 0x529AF64: virCgroupMoveTask (vircgroup.c:1079)
      
      Introduced by 83e4c775.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=978352
      5bc8ecb8
    • J
      Fix invalid read in virCgroupGetValueStr · 306c49ff
      Ján Tomko 提交于
      Don't check for '\n' at the end of file if zero bytes were read.
      
      Found by valgrind:
      ==404== Invalid read of size 1
      ==404==    at 0x529B09F: virCgroupGetValueStr (vircgroup.c:540)
      ==404==    by 0x529AF64: virCgroupMoveTask (vircgroup.c:1079)
      ==404==    by 0x1EB475: qemuSetupCgroupForEmulator (qemu_cgroup.c:1061)
      ==404==    by 0x1D9489: qemuProcessStart (qemu_process.c:3801)
      ==404==    by 0x18557E: qemuDomainObjStart (qemu_driver.c:5787)
      ==404==    by 0x190FA4: qemuDomainCreateWithFlags (qemu_driver.c:5839)
      
      Introduced by 0d0b4098.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=978356
      306c49ff
    • S
      Fix sample TPM XML · 7070a572
      Stefan Berger 提交于
      Fix an error in the sample TPM XML.
      Signed-off-by: NStefan Berger <stefanb@linux.vnet.ibm.com>
      7070a572
    • L
      network: allow <vlan> in type='hostdev' networks · 4b42e3b9
      Laine Stump 提交于
      Although SRIOV network cards support setting a vlan tag on their
      virtual functions, and although setting this vlan tag via a <vlan>
      element in a domain's <interface> works, setting a vlan tag for these
      devices in a <network> definition, or in a network <portgroup>
      definition is also supposed to work (and the comment that validates
      <vlan> usage even says that!). However, the check to allow it only
      checked for an openvswitch network, so attempts to add <vlan> to a
      network of type='hostdev' would fail.
      4b42e3b9
    • L
      docs: correct and update network vlan example · ab0c8df0
      Laine Stump 提交于
      Somehow I put an example of a domain interface with a <vlan> element
      into the network documentation.
      
      This patch replaces that with an example of a network definition that
      has a vlan element with trunk='yes', multiple tags, and even the new
      nativeMode attribute. It also includes a <portgroup> that has a vlan
      defined.
      ab0c8df0
    • L
      test: include qemuhotplugtest data files in source rpm · ec30f0f7
      Laine Stump 提交于
      commit 0fc12bca added a new test called qemuhotplugtest which has
      several data files in tests/qemuhotplugtestdata, but didn't add that
      directory to EXTRA_DIST in the tests Makefile.am, so the make check
      done during a make rpm was failing due to missing data files.
      ec30f0f7