- 11 3月, 2010 1 次提交
-
-
由 Eric Blake 提交于
Since cppi is not part of Fedora Core 12, the check is conditional: without cppi, running 'make syntax-check' merely warns: $ make sc_preprocessor_indentation preprocessor_indentation maint.mk: skipping test sc_preprocessor_indentation: cppi not installed * cfg.mk (sc_preprocessor_indentation): New syntax-check rule. (preprocessor_exempt): New macro, with first exemption.
-
- 02 3月, 2010 1 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (sc_TAB_in_indentation): Also check .rng files.
-
- 25 2月, 2010 1 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (_curr_status): Accommodate leading "+" or "-" in the output of git submodule status. * autogen.sh: Likewise.
-
- 24 2月, 2010 1 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (local-checks-to-skip): Disable sc_prohibit_hash_without_use for now, since it fails with a false-positive match.
-
- 22 1月, 2010 1 次提交
-
-
由 Chris Lalancette 提交于
Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
- 18 1月, 2010 1 次提交
-
-
由 Jim Meyering 提交于
The latter is not officially "wrong", but *is* terribly anachronistic. I think automake documentation or comments call that syntax obsolescent. * cfg.mk (_makefile_at_at_check_exceptions): Exempt @SCHEMADIR@ and @SYSCONFDIR@ uses -- there are no Makefile variables for those. * docs/Makefile.am: Use $(INSTALL), not @install@. * examples/dominfo/Makefile.am: Similar. * examples/domsuspend/Makefile.am: Similar. * proxy/Makefile.am: Similar. * python/Makefile.am: Similar. * python/tests/Makefile.am: Similar. * src/Makefile.am: Similar. * tests/Makefile.am: Similar.
-
- 26 10月, 2009 2 次提交
-
-
由 Chris Lalancette 提交于
We should always be using virGetHostname in place of gethostname; thus add in a new syntax-check rule to make sure no new uses creep in. Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
由 Chris Lalancette 提交于
Make a pass over the syntax-check files, tightening up regex's, un-ignoring certain files, and cleaning things up. Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
- 01 10月, 2009 1 次提交
-
-
由 Jiri Denemark 提交于
* cfg.mk: use $(srcdir)/ prefix for Makefile.nonreentrant include * examples/domain-events/events-c/Makefile.am tools/Makefile.am examples/hellolibvirt/Makefile.am: extend the include paths to use $(top_srcdir)/include too.
-
- 23 9月, 2009 2 次提交
-
-
由 Chris Lalancette 提交于
Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
由 Chris Lalancette 提交于
Add the virStrncpy function, which takes a dst string, source string, the number of bytes to copy and the number of bytes available in the dest string. If the source string is too large to fit into the destination string, including the \0 byte, then no data is copied and the function returns NULL. Otherwise, this function copies n bytes from source into dst, including the \0, and returns a pointer to the dst string. This function is intended to replace all unsafe uses of strncpy in the code base, since strncpy does *not* guarantee that the buffer terminates with a \0. Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
- 17 7月, 2009 1 次提交
-
-
由 Jim Meyering 提交于
The code in cfg.mk to detect when the git submodule was out of date worked most of the time, but not when checked out in a certain way. * cfg.mk: Extract submodule hash from command output and file, and compare only that, since the format of the full line may vary. Reported by Mike Burns, with some diagnosis by Daniel P Berrange.
-
- 16 7月, 2009 1 次提交
-
-
由 Jim Meyering 提交于
This makes "make syntax-check" fail when a version-controlled file contains a trailing blank line. * cfg.mk (sc_prohibit_trailing_blank_lines): New rule.
-
- 10 7月, 2009 1 次提交
-
-
由 Jim Meyering 提交于
When "git pull" (or any other operation) brings in a new version of the gnulib git submodule, you must rerun the autogen.sh script. With this change, "make" now fails and tells you to run ./autogen.sh, when needed. * autogen.sh: Maintain a new file, .git-module-status, containing the current submodule status. If it doesn't exist or its content is different from what "git submodule status" prints, then run ./bootstrap * .gitignore: Add .git-module-status * cfg.mk: Diagnose out of date submodule and fail. * README-hacking: Update not to mention bootstrap. * Makefile.am (MAINTAINERCLEANFILES): Add .git-module-status, so that "make maintainerclean" will remove it.
-
- 08 7月, 2009 4 次提交
-
-
由 Jim Meyering 提交于
* bootstrap (modules): Add gnumakefile and maintainer-makefile. * GNUmakefile: Remove file, now provided by gnulib. * Makefile.maint: Remove. Replaced by maint.mk from gnulib. .gitignore: Add GNUmakefile and maint.mk. * cfg.mk (prev_version_file): Disable this feature. Setting this to /dev/null avoids an otherwise harmless diagnostic.
-
由 Jim Meyering 提交于
* cfg.mk (local-checks-to-skip): Add these: sc_error_message_uppercase, sc_program_name, sc_require_test_exit_idiom, sc_makefile_check.
-
由 Jim Meyering 提交于
Since Makefile.maint will soon come from gnulib's maint.mk, sync Makefile.maint to have the same contents (modulo minor things). In syncing it, we have to remove some libvirt-specific rules. Since we want to keep them (of course), put those in cfg.mk. * Makefile.maint: Merge from gnulib's maint.mk. * cfg.mk (sc_avoid_write): New rule. From Makefile.cfg. (sc_prohibit_strcmp_and_strncmp): Likewise, and rename. (sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise. (sc_prohibit_nonreentrant): Likewise. (sc_prohibit_ctype_h): Likewise. (sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise. (sc_prohibit_virBufferAdd_with_string_literal): Likewise. (sc_prohibit_gethostby): Likewise. (sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the rule, inserting "_libvirt", since this rule is a specialization of the one in gnulib. * GNUmakefile: Include cfg.mk, not Makefile.cfg * .x-sc_prohibit_strcmp_and_strncmp: New file. * Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp
-
由 Jim Meyering 提交于
* cfg.mk: ...this. New file.
-
- 03 2月, 2009 3 次提交
-
-
由 Jim Meyering 提交于
* Makefile.cfg (local-checks-to-skip): Remove sc_redundant_const. * src/lxc_controller.c: Remove redundant "const"(s). * src/storage_backend_fs.c: Likewise. * src/util.h: Likewise. * src/xen_internal.c: Likewise. * tests/qparamtest.c: Likewise.
-
由 Jim Meyering 提交于
* Makefile.cfg (local-checks-to-skip): Don't skip sc_m4_quote_check. Don't skip sc_prohibit_nonreentrant. * Makefile.nonreentrant (NON_REENTRANT): Comment out until we've remove all remaining uses of strerror.
-
由 Jim Meyering 提交于
* Makefile.cfg (useless_free_options): Also check for VIR_FREE. * src/iptables.c (iptRulesFree): Remove useless if-before-VIR_FREE. * src/remote_internal.c (remoteAuthSASL): Likewise. * src/test.c (testOpenFromFile): Likewise.
-
- 29 1月, 2009 1 次提交
-
-
由 Jim Meyering 提交于
-
- 21 1月, 2009 1 次提交
-
-
由 Daniel P. Berrange 提交于
-
- 15 5月, 2008 1 次提交
-
-
由 Daniel P. Berrange 提交于
-
- 29 4月, 2008 1 次提交
-
-
由 Jim Meyering 提交于
* Makefile.cfg (useless_free_options): Add --name=xmlFree.
-
- 21 4月, 2008 1 次提交
-
-
由 Jim Meyering 提交于
* Makefile.maint (sc_changelog): Adapt to work with legacy ChangeLog entry header lines. * Makefile.cfg (local-checks-to-skip): Remove sc_changelog.
-
- 08 2月, 2008 2 次提交
-
-
由 Jim Meyering 提交于
* Makefile.cfg (local-checks-to-skip): Remove sc_no_have_config_h. * qemud/mdns.c: Remove "#ifdef HAVE_CONFIG_H". * Makefile.maint (sc_no_have_config_h): Tighten up regexp, so that the above mention of "HAVE_CONFIG_H" doesn't match. * .x-sc_no_have_config_h: New file, to exempt gnulib/ straggler.
-
由 Jim Meyering 提交于
* build-aux/useless-if-before-free: Rename from ... * build-aux/find-unnecessary-if-before-free: ... this. Remove file. Also changed it so that new names are no longer hard-coded in the script. Instead, they're supplied via options: * Makefile.cfg (useless_free_options): Define. Add xmlXPathFreeObject to the list of free-like functions it detects. * Makefile.maint (sc_avoid_if_before_free): Reflect script renaming. * .x-sc_avoid_if_before_free: Likewise. * src/openvz_conf.c (openvzParseXML): Remove useless "if"-before-free. * src/qemu_conf.c (qemudParseXML, qemudParseNetworkXML): Likewise. * src/virsh.c (cmdVNCDisplay, cmdTTYConsole, cmdDetachInterface): (cmdDetachDisk): Likewise. * src/xm_internal.c (xenXMConfigSetIntFromXPath): Likewise. (xenXMConfigSetStringFromXPath, xenXMParseXMLToConfig): Likewise. (xenXMDomainAttachDevice, xenXMAttachDisk, xenXMAttachInterface): (xenXMDomainDetachDevice): Likewise. * src/xml.c (virXPathString): Likewise. * tests/xmlrpctest.c (checkRequestValue): Likewise.
-
- 06 2月, 2008 1 次提交
-
-
由 Jim Meyering 提交于
* Makefile.cfg (local-checks-to-skip): Remove sc_trailing_blank. * .x-sc_trailing_blank: New file, to exempt the few binary files.
-
- 04 2月, 2008 1 次提交
-
-
由 Jim Meyering 提交于
involving the "error" function. * Makefile.cfg (local-checks-to-skip): Remove from skip list. * src/remote_internal.c: Mark translatable strings.
-
- 30 1月, 2008 6 次提交
-
-
由 Jim Meyering 提交于
* Makefile.cfg (local-checks-to-skip) [sc_cast_of_x_alloc_return_value, sc_cast_of_argument_to_free]: Enable.
-
由 Jim Meyering 提交于
* Makefile.cfg (local-checks-to-skip) [sc_prohibit_assert_without_use]: Enable. * qemud/mdns.c: Don't include <assert.h>; no uses of assert here. * qemud/qemud.c: Likewise. * qemud/remote.c: Likewise.
-
由 Jim Meyering 提交于
* Makefile.cfg (local-checks-to-skip) [po-check]: Enable. * po/POTFILES.in: Add three file names. Sort.
-
由 Jim Meyering 提交于
Use <config.h>, not "config.h", per autoconf documentation. * Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable. * .x-sc_require_config_h: New file, to list exempted files. * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.
-
由 Jim Meyering 提交于
* Makefile.cfg (local-checks-to-skip) [sc_the_the]: Enable. * docs/virsh.pod: Remove a duplicate "the". * libvirt.spec.in: Likewise. * virsh.1: Likewise.
-
由 Jim Meyering 提交于
Almost all tests are initially disabled via the list in Makefile.cfg. * Makefile.am (EXTRA_DIST): Add .x-sc_avoid_if_before_free. Omit names of files that automake includes automatically. * .x-sc_avoid_if_before_free: New file. * build-aux/vc-list-files: Likewise. * build-aux/find-unnecessary-if-before-free: Likewise. * GNUmakefile, Makefile.cfg, Makefile.maint: New files.
-