- 23 1月, 2013 11 次提交
-
-
由 John Ferlan 提交于
It was possible to call VIR_FREE in cleanup prior to initialization
-
由 John Ferlan 提交于
It was possible to call VIR_FREE in cleanup prior to initialization.
-
由 John Ferlan 提交于
It was possible to call VIR_FREE in error prior to initialization.
-
由 John Ferlan 提交于
It was possible to call VIR_FREE in cleanup prior to initialization
-
由 John Ferlan 提交于
It was possible to call VIR_FREE in cleanup prior to initialization.
-
由 John Ferlan 提交于
It was possible to call VIR_FREE in cleanup prior to initialization
-
由 John Ferlan 提交于
It was possible to call VIR_FREE in cleanup prior to initialization
-
由 John Ferlan 提交于
It was possible to call VIR_FREE in cleanup prior to initialization
-
由 John Ferlan 提交于
It was possible to call VIR_FREE in error prior to initialization
-
由 John Ferlan 提交于
Resolve a couple of instances where variables were not initialized prior to potential VIR_FREE call in cleanup path.
-
由 John Ferlan 提交于
If there was more than one inotify_event found in the read/while loop, then only the last event found would have been queued.
-
- 22 1月, 2013 20 次提交
-
-
由 Claudio Bley 提交于
-
由 John Ferlan 提交于
The local redefinition of PED_PARTITION_PROTECTED results in the error but is not a problem especially if the built code doesn't have the latest definitions.
-
由 John Ferlan 提交于
On error, the 'tapfd' in networkStartNetworkVirtual() is synonymous with 'macTapIfName' and will be closed in the appropriate error path.
-
由 John Ferlan 提交于
Upon successful return of virNetClientStreamEventAddCallback() the allocated cbdata field will be freed by virNetClientStreamEventRemoveCallback() as cbOpaque using the free function remoteStreamCallbackFree().
-
由 John Ferlan 提交于
This avoids "Event negative_returns: A negative constant "-1" is passed as an argument to a parameter that cannot be negative.". The called function uses -1 to determine whether it needs to traverse all the hostdevs.
-
由 John Ferlan 提交于
Coverity misses the nuance of VIR_FREE(privkey) setting privkey = NULL when if (!(virFileExists(privkey))) is true and thus declares the code dead.
-
由 John Ferlan 提交于
The old cpu bitmap setting algorithm causes a couple of complaints which have been tagged.
-
由 John Ferlan 提交于
The use of switch statements inside a bounded for loop resulted in some false positives regarding the "default:" label which cannot be reached since each of the other case statements use the possible for loop values. A [dead_error_begin] was added before the default label. Commit id ebdbe25a adjusted the algorithm and the caller guarantees that the 'params' will have a '_' in the name being searched. Add the [returned_null] tag to the two instances.
-
由 John Ferlan 提交于
The use of switch statements inside a bounded for loop resulted in some false positives regarding the "default:" label which cannot be reached since each of the other case statements use the possible for loop values.
-
由 John Ferlan 提交于
The various _for_i loops with both u.s.car and u.s.cdr were being reported as COPY_PASTE errors by Coverity. This just quiets those messages.
-
由 John Ferlan 提交于
Commit id a994ef2d changed the mechanism to store/update the default security label from using disk->seclabels[0] to allocating one on the fly. That change allocated the label, but never saved it. This patch will save the label. The new virDomainDiskDefAddSecurityLabelDef() is a copy of the virDomainDefAddSecurityLabelDef().
-
由 John Ferlan 提交于
-
由 John Ferlan 提交于
-
由 John Ferlan 提交于
The code is not reachable as of commit id: bb85f229. Removed virKeepAliveStop() and virObjectUnref() because 'ka' cannot be anything but NULL at the cleanup label.
-
由 John Ferlan 提交于
-
由 Peter Krempa 提交于
Forbid the names to match the loading procedure of snapshots.
-
由 Michal Privoznik 提交于
Currently, whenever somebody calls saferead() on nonblocking FD (safewrite() is totally interchangeable for purpose of this message) he might get wrong return value. For instance, in the first iteration some data is read. The number of bytes read is stored into local variable 'nread'. However, in next iterations we can get -1 from read() with errno == EAGAIN, in which case the -1 is returned despite fact some data has already been read. So the caller gets confused. Bare read() should be used for nonblocking FD.
-
由 Jiri Denemark 提交于
-
由 Jiri Denemark 提交于
-
由 Eric Blake 提交于
Nested conditionals are hard to read if they are not indented. We can't add arbitrary whitespace to everything in spec files, but we CAN add spaces before %if and %define. Use this trick, plus a fancy sed script that rewrites a spec file into a C file, so we can use cppi to keep our spec file nice. For reference, the sed script converts code like: |# RHEL-5 builds are client-only for s390, ppc |%if 0%{?rhel} == 5 | %ifnarch %{ix86} x86_64 ia64 | %define client_only 1 | %endif |%endif into the following for cppi: |// # RHEL-5 builds are client-only for s390, ppc |#if a // 0%{?rhel} == 5 |# if a // %{ix86} x86_64 ia64 |# define client_only 1 |# endif |#endif and errors from 'make syntax-check' look like: spec_indentation cppi: mingw-libvirt.spec.in: line 130: not properly indented maint.mk: incorrect preprocessor indentation * libvirt.spec.in: Add some indentation to make it easier to follow various conditionals. * mingw-libvirt-spec.in: Likewise. * cfg.mk (sc_spec_indentation): New syntax check to enforce it.
-
- 21 1月, 2013 2 次提交
-
-
由 Peter Krempa 提交于
The snapshot name is used to create path to the definition save file. When the name contains slashes the creation of the file fails. Reject such names.
-
由 Peter Krempa 提交于
When the snapshot definition can't be saved, the qemuDomainSnapshotCreate function succeeded without filling some of the fields in the internal definition. This patch removes the snapshot and returns failure if the XML file cannot be written.
-
- 19 1月, 2013 2 次提交
-
-
由 Michal Privoznik 提交于
We are already logging other arguments passed, however, @flags were missing there.
-
由 Viktor Mihajlovski 提交于
Added missing entries to makefile and spec. Signed-off-by: NViktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
-
- 18 1月, 2013 5 次提交
-
-
由 Daniel P. Berrange 提交于
When running virDomainDestroy, we need to make sure that no other background thread cleans up the domain while we're doing our work. This can happen if we release the domain object while in the middle of work, because the monitor might detect EOF in this window. For this reason we have a 'beingDestroyed' flag to stop the monitor from doing its normal cleanup. Unfortunately this flag was only being used to protect qemuDomainBeginJob, and not qemuProcessKill This left open a race condition where either libvirtd could crash, or alternatively report bogus error messages about the domain already having been destroyed to the caller Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
由 Claudio Bley 提交于
Signed-off-by: NClaudio Bley <cbley@av-test.de>
-
由 Claudio Bley 提交于
Use of <tt> is discouraged in HTML 4.x and has finally been obsoleted in HTML 5. Likewise for the <i> tag. Using tables for layout is (widely) considered bad style, too. Use defintion lists, definition term and defintion description elements instead. Signed-off-by: NClaudio Bley <cbley@av-test.de>
-
由 Claudio Bley 提交于
In CSS the following class names are available: * keyword (keywords like "typedef", "struct") * type (types like "int", "void*") * comment (comments after members of enums or structs) * directive (preprocessor directives, #define) * undisclosed (text saying that the API is not public) Additionally, kill all of the left-over "programlisting" class assignments. There are no CSS rules for them. Signed-off-by: NClaudio Bley <cbley@av-test.de>
-
由 Jiri Denemark 提交于
The function is just a renamed public version of former virTypedParameterArrayClear.
-