Move some parts of virStorageFileRemoveLastPathComponent
into a separate function so they can be reused.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>

Further followup discussions in list on commit 192a53e0 concluded
that we should be leaving out the USB controller only for
i440fx machines as default USB can be used by someone on q35
at random slots.
Signed-off-by: NShivaprasad G Bhat <sbhat@linux.vnet.ibm.com>

The initialization vector is a technical term by itself different from
the key.

The preferred name will be AES not IV, change current references
Signed-off-by: NJohn Ferlan <jferlan@redhat.com>

My commit 3e428670 started filling out the video size in post-parse,
but did not adjust the tests.

Move filling out the default video (v)ram to DeviceDefPostParse.

This means it can be removed from virDomainVideoDefParseXML
and qemuParseCommandLine. Also, we no longer need to special case
VIR_DOMAIN_VIRT_XEN, since the per-driver callback gets called
before the generic one.

Commit 6879be48 moved adding of an implicit video device after XML
parsing. As a result, libxlDomainDeviceDefPostParse() is no longer
called to set the default vram when adding an implicit device.
Commit 6879be48 assumes virDomainVideoDefaultRAM() will set the
default vram, but it returns 0 if the domain virtType is
VIR_DOMAIN_VIRT_XEN. Attempting to start an HVM domain with vram=0
results in

error: unsupported configuration: videoram must be at least 4MB for CIRRUS

The default vram setting for Xen HVM domains depends on the device
model used (qemu-xen vs qemu-traditional), hence setting the
default is deferred to libxlDomainDeviceDefPostParse().

Call the device post-parse callback even for implicit video,
to fill out the default vram even for VIR_DOMAIN_VIRT_XEN.

https://bugzilla.redhat.com/show_bug.cgi?id=1334557Most-of-commit-message-by: NJim Fehlig <jfehlig@suse.com>

Future commit will call DeviceDefPostParse on a device auto-added
in DomainDefPostParse.

Both virGetLastError and virGetLastErrorMessage call virLastErrorObject method
that returns a thread-local error object. However, if a direct call to malloc
or pthread_setspecific (probably also due to malloc, since it sets ENOMEM)
fail, virLastErrorObject returns NULL which, although incorrectly interpreted
by virGetLastError as no error, still requires the caller to check for NULL
pointer. This isn't the case with virGetLastErrorMessage that also treated it
incorrectly as no error, but returned the literal "no error".
This patch tweaks the checks in the virGetLastErrorMessage function, so that
if virLastErrorObject failed, it returned "unknown error" which is equivalent
to the current approach with virGetLastError and if it returned NULL,
"unknown error" was set.
Signed-off-by: NErik Skultety <eskultet@redhat.com>

syntax-check complained about broken indentation in libvirt.spec.in which was
broken by commit 3694e038Signed-off-by: NErik Skultety <eskultet@redhat.com>

We were adding a sheepdog requirement at runtime, but forgetting
to turn it on at build time, so the underlying code was never
built.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

The %changelog entries in the RPM are just a poor immitation
of the release notes, which is not what %changelog section
is for. It should be reflecting changes in the RPM packaging,
not changes in the application releases. Further, this bogus
list of changes has to be manually deleted every time we sync
the RPM with Fedora. Remove them, since they serve no useful
purpose.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Rather than letting the configure script auto-detect features
we expect, use --with-xxx to explicitly mandate them. This
ensures that we get an error upfront when running configure,
rather than a failure later during build or RPM file packaging
time.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build the nss plugin at all times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with libnl3 at all times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with macvtap at all times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with libpcap at all times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with the nwfilter driver enabled
at all times
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with the nodedev driver enabled
at all times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with the storage driver and
most of its sub-drivers enabled at all times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with the network driver
enabled at all times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with the interface driver
enabled at all times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with selinux enabled at all
times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with yajl enabled at all times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with polkit enabled at all
times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with sasl enabled at all times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with dtrace enabled at all
times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with audit enabled at all
times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with netcf enabled at all
times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with udev enabled at all
times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with capng enabled at all
times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Neither RHEL or Fedora build apparmor
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Neither RHEL or Fedora build HAL anymore.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with avahi enabled at all
times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with libvirtd enabled at
all times.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Both RHEL and Fedora build with driver modules enabled by
default, so there is no need for any conditional.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

A client only build dates back to RHEL5 where some architectures
did not build the libvirtd daemon, only the clients. Since RHEL5
was dropped this is no longer required.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

Simplify conditionals to assume Fedora >= 20 or RHEL >= 6

The %prep section will explicitly check the version and
refuse to run if insufficient.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>

The xenapi & vz drivers won't build in Fedora or RHEL
since their deps don't exist there.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>