提交 · 7d9f7e1731811d474079eee28cfbc835ce9e232f · openeuler / libvirt

21 10月, 2019 30 次提交

test: use g_strdup instead of VIR_STRDUP · 7d9f7e17

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

7d9f7e17

storage: use g_strdup instead of VIR_STRDUP · a7fb30e3

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

a7fb30e3

security: use g_strdup instead of VIR_STRDUP · 25d3fc7a

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

25d3fc7a

rpc: use g_strdup instead of VIR_STRDUP · 45bf10ba

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

45bf10ba

remote: use g_strdup instead of VIR_STRDUP · b2d079c1

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

b2d079c1

qemu: use g_strdup instead of VIR_STRDUP · ce36e33c

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

ce36e33c

nwfilter: use g_strdup instead of VIR_STRDUP · a0bb1369

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

a0bb1369

node_device: use g_strdup instead of VIR_STRDUP · 7f1f0453

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

7f1f0453

network: use g_strdup instead of VIR_STRDUP · 4d81b800

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

4d81b800

lxc: use g_strdup instead of VIR_STRDUP · 380bc1be

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

380bc1be

logging: use g_strdup instead of VIR_STRDUP · 620cd4d0

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

620cd4d0

locking: use g_strdup instead of VIR_STRDUP · 9e96101d

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

9e96101d

libxl: use g_strdup instead of VIR_STRDUP · b1145715

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

b1145715

interface: use g_strdup instead of VIR_STRDUP · 2f3b7a55

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

2f3b7a55

esx: use g_strdup instead of VIR_STRDUP · 07ef8893

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

07ef8893

datatypes: use g_strdup instead of VIR_STRDUP · 923ab677

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

923ab677

cpu: use g_strdup instead of VIR_STRDUP · df753c85

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

df753c85

conf: use g_strdup instead of VIR_STRDUP · 17561eb3

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

17561eb3

bhyve: use g_strdup instead of VIR_STRDUP · 652cdbe3

由 Ján Tomko 提交于 10月 20, 2019

Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

652cdbe3

Use g_strdup to fill in default values · 7b48bb8c

由 Ján Tomko 提交于 10月 18, 2019

Replace:
  if (!s && VIR_STRDUP(s, str) < 0)
    goto;
with:
  if (!s)
    s = g_strdup(str);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

7b48bb8c

Use g_strdup where VIR_STRDUP's return value was propagated · 3cbd4351

由 Ján Tomko 提交于 10月 20, 2019

All the callers of these functions only check for a negative
return value.

However, virNetDevOpenvswitchGetVhostuserIfname is documented
as returning 1 for openvswitch interfaces so preserve that.
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

3cbd4351

drivers: use g_strdup in probe functions · 94c98eb5

由 Ján Tomko 提交于 10月 20, 2019

The callers expect '1' on a successful probe,
so return 1 just like VIR_STRDUP would.
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

94c98eb5

Use g_strdup instead of ignoring VIR_STRDUP_QUIET's value · ea5bb994

由 Ján Tomko 提交于 10月 18, 2019

Replace all the occurrences of
  ignore_value(VIR_STRDUP_QUIET(a, b));
with
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

ea5bb994

Use g_strdup instead of ignoring VIR_STRDUP's value · 64023f6d

由 Ján Tomko 提交于 10月 18, 2019

Replace all the occurrences of
  ignore_value(VIR_STRDUP(a, b));
with
  a = g_strdup(b);
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

64023f6d

conf: use g_strdup in virDomainDiskSet · d74067c0

由 Ján Tomko 提交于 10月 19, 2019

Use a temporary variable to allow copying from the
currently set source.

Always return 0 since none of the callers distinguishes
between 0 and 1 propagated from VIR_STRDUP.
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

d74067c0

util: fix check for iscsi initiator copy · cb756a99

由 Ján Tomko 提交于 10月 20, 2019

virStorageSourceInitiatorCopy propagates the return
value from VIR_STRDUP, which returns 1 on a successful
copy.

Only error out on < 0, not non-zero values.

Fixes: 9ea3fdc6Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

cb756a99

scripts: introduce a macro file for coccinelle · 5f9c0625

由 Ján Tomko 提交于 10月 19, 2019

Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>

5f9c0625

qemu: fix CPU model error probing capabilities for ppc · d46734e7

由 Daniel P. Berrangé 提交于 10月 18, 2019

The CPU driver only supports CPU models for PPC64 architecture, not
plain PPC.

  Failed to probe capabilities for /usr/bin/qemu-system-ppc:
  this function is not supported by the connection driver:
  'ppc' architecture is not supported by CPU driver

This fixes a bug in

  commit db873ab3
  Author: Jiri Denemark <jdenemar@redhat.com>
  Date:   Thu May 17 17:08:42 2018 +0200

    qemu: Adapt to changed ppc64 CPU model names
Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: NAndrea Bolognani <abologna@redhat.com>
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>

d46734e7

gitdm: Add other emails into IBM company · f0190491

由 Julio Faracco 提交于 10月 20, 2019

Some people from IBM does not use 'ibm.com' domain emails.
They use personal or other domains.
Signed-off-by: NJulio Faracco <jcfaracco@gmail.com>
Reviewed-by: NAndrea Bolognani <abologna@redhat.com>

f0190491

vsh: mark ctl as unused in vshReadline · fbc5a153

由 Ján Tomko 提交于 10月 21, 2019

My commit removed the last use in the version for platforms
without readline.

Fixes: c937c1d2Signed-off-by: NJán Tomko <jtomko@redhat.com>

fbc5a153

20 10月, 2019 10 次提交

tools: delete vshStrdup · f31bdc7c

由 Ján Tomko 提交于 10月 18, 2019

Now that we use g_strdup everywhere, delete vshStrdup.
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>

f31bdc7c

tools: prefer g_strdup to vshStrdup · c937c1d2

由 Ján Tomko 提交于 10月 18, 2019

Remove all the uses of vshStrdup in favor of GLib's g_strdup.
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>

c937c1d2

tools: vshCommandArgvGetArg: prefer g_strdup · 7863f154

由 Ján Tomko 提交于 10月 19, 2019

Remove the use of vshStrdup.
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>

7863f154

tools: vshCommandArgvGetArg: one parameter per line · df329e94

由 Ján Tomko 提交于 10月 19, 2019

Split the parameters to make changes more readable.
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>

df329e94

virsh: getSignalNumber: use g_strdup · fc941b2c

由 Ján Tomko 提交于 10月 18, 2019

Eliminate the use of vshStrdup.
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>

fc941b2c

virsh: getSignalNumber: use g_autofree · 5c808a09

由 Ján Tomko 提交于 10月 18, 2019

Mark the 'str' variable as g_autofree and avoid the need for
a separate cleanup label.
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>

5c808a09

virsh: getSignalNumber: rename variables · b6a8c9df

由 Ján Tomko 提交于 10月 18, 2019

Use 'str' for the allocated copy of the string and 'p'
for the pointer into that string.
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>

b6a8c9df

virsh: use g_strdup in virshDomainGetEditMetadata · 76b4cd88

由 Ján Tomko 提交于 10月 18, 2019

Prefer GLib's g_strdup to vshStrdup.
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>

76b4cd88

virsh: use g_strdup in cmdDomblkinfoGet · d20f55c0

由 Ján Tomko 提交于 10月 18, 2019

Prefer GLib's g_strdup to vshStrdup.
Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>

d20f55c0

tools: cmdDomblkinfoGet: reindent parameters · 4e66c386

由 Ján Tomko 提交于 10月 19, 2019

Signed-off-by: NJán Tomko <jtomko@redhat.com>
Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>

4e66c386