1. 15 8月, 2010 6 次提交
  2. 14 8月, 2010 3 次提交
    • S
      nwfilter: Discard class D,E IP addresses when sniffing pkts · 753d76e0
      Stefan Berger 提交于
      When sniffing the network traffic, discard class D and E IP addresses when sniffing traffic. This was a reason why filters were not correctly rebuilt on VMs on the local 192.* network when libvirt was restarted and those VMs did not use a DHCP request to get its IP address.
      753d76e0
    • S
      nwfilter: serialize execution of scripts with ebtables cmds · bed3a217
      Stefan Berger 提交于
      While testing the SIGHUP handling and reloading of the nwfilter driver, I found that when the filters are rebuilt and mutlipe threads handled the individual interfaces, concurrently running multiple external bash scripts causes strange failures even though the executed ebtables commands are working on different tables for different interfaces. I cannot say for sure where the concurrency problems are caused, but introducing this lock definitely helps.
      bed3a217
    • M
      8b4eedc8
  3. 13 8月, 2010 4 次提交
    • C
      Move the tunnelled migration unix socket to /var/lib/libvirt/qemu · e80f1a7e
      Chris Lalancette 提交于
      Since the qemu process is running as qemu:qemu, it can't actually
      look at the unix socket in /var/run/libvirt/qemu which is owned by
      root and has permission 700.  Move the unix socket to
      /var/lib/libvirt/qemu, which is already owned by qemu:qemu.
      
      Thanks to Justin Clift for test this out for me.
      Signed-off-by: NChris Lalancette <clalance@redhat.com>
      e80f1a7e
    • C
      Fix tunnelled migration with qemu running as qemu:qemu. · a2f0b6b8
      Chris Lalancette 提交于
      The problem is that on the source of the migration, libvirtd
      is responsible for creating the unix socket over which the data
      will flow.  Since libvirtd is running as root, this file will
      be created as root.  When the qemu process running as qemu:qemu
      goes to access the unix file to write data to it, it will get
      permission denied and fail.  Make sure to change the owner
      of the unix file to qemu:qemu.
      
      Thanks to Justin Clift for testing this patch out for me.
      Signed-off-by: NChris Lalancette <clalance@redhat.com>
      a2f0b6b8
    • S
      Fix valgrind complaints when using kill -SIGHUP on libvirtd · 18b6323a
      Stefan Berger 提交于
      This patch fixes a couple of complaints from valgrind when tickling libvirtd with SIGHUP.
      
      The first two files contain fixes for memory leaks. The 3rd one initializes an uninitialized variable. The 4th one is another memory leak.
      18b6323a
    • D
      qemu: avoid calling the balloon info command if disabled · 986c2086
      Daniel Veillard 提交于
       Basically a followup of the previous patch about balloon desactivation
      if desactivated, to not ask for balloon information to qemu as we will
      just get an error back.
       This can make a huge difference in the time needed for domain
      information or list when a machine is loaded, and balloon has been
      desactivated in the guests.
      
      * src/qemu/qemu_driver.c: do not get the balloon info if the balloon
        suppor is disabled
      986c2086
  4. 12 8月, 2010 3 次提交
    • J
      bridge: Add --dhcp-no-override option to dnsmasq · e26672f7
      Jiri Denemark 提交于
      --dhcp-no-override description from dnsmasq man page:
      
            Disable  re-use  of  the  DHCP servername and filename fields as
            extra option space. If it can, dnsmasq moves the boot server and
            filename  information  (from  dhcp-boot)  out of their dedicated
            fields into DHCP options. This make extra space available in the
            DHCP  packet  for options but can, rarely, confuse old or broken
            clients. This flag forces "simple and safe" behaviour  to  avoid
            problems in such a case.
      
      It seems some virtual network card ROMs are this old/buggy so let's add
      --dhcp-no-override as a workaround for them. We don't use extra DHCP
      options so this should be safe. The option was added in dnsmasq-2.41,
      which becomes the minimum required version.
      e26672f7
    • M
      esx: Improve VMX file name parsing and formatting · 145d6cb0
      Matthias Bolte 提交于
      For parsing try to match by datastore mount path first, if that
      fails fallback to /vmfs/volumes/<datastore>/<path> parsing. This
      also fixes problems with GSX on Windows. Because GSX on Windows
      doesn't use /vmfs/volumes/ style file names.
      
      For formatting use the datastore mount path too, instead of using
      /vmfs/volumes/<datastore>/<path> as fixed format.
      145d6cb0
    • J
      bridge: Fix potential segfault when preparing dnsmasq arguments · 6f42d325
      Jiri Denemark 提交于
      We add --dhcp-lease-max=xxx argument when network->def->nranges > 0 but
      we only allocate space for in the opposite case :-) I guess we are lucky
      enough to miscount somewhere else so that we actually allocate more
      space than we need since no-one has hit this bug so far.
      6f42d325
  5. 11 8月, 2010 6 次提交
    • M
      esx: Split VMX code into a general and an ESX specific part · 3de82455
      Matthias Bolte 提交于
      Introduce esxVMX_Context containing functions pointers to
      glue both parts together in a generic way.
      
      Move the ESX specific part to esx_driver.c.
      
      This is a step towards making the VMX code reusable in a
      potential VMware Workstation and VMware Player driver.
      3de82455
    • D
      allow memballoon type of none to desactivate it · 79c27a62
      Daniel Veillard 提交于
        The balloon device is automatically added to qemu guests if supported,
      but it may be useful to desactivate it. The simplest to not change the
      existing behaviour is to allow
        <memballoon type="none"/>
      as an extra option to desactivate it (it is automatically added if the
      memballoon construct is missing for the domain).
      The following simple patch just adds the extra option and does not
      change the default behaviour but avoid creating a balloon device if
      type="none" is used.
      
      * docs/schemas/domain.rng: add the extra type attribute value
      * src/conf/domain_conf.c src/conf/domain_conf.h: add the extra enum
        value
      * src/qemu/qemu_conf.c: if enum is NONE, don't activate the device,
        i.e. don't pass the args to qemu/kvm
      79c27a62
    • J
      Avoid unnecessary bootstrap runs in VPATH builds · 0495fe59
      Jiri Denemark 提交于
      0495fe59
    • D
      Add a detailed message when tap device add fails · efdd0ffc
      Doug Goldstein 提交于
      Added a more detailed error message when adding a tap devices fails and
      the kernel is missing tun support.
      Signed-off-by: NDoug Goldstein <cardoe@gentoo.org>
      efdd0ffc
    • D
      Fix return value usage · c0b0e8d0
      Doug Goldstein 提交于
      Fix the error checking to use the return value from brAddTap() instead
      of checking the current errno value which might have been changed by
      clean up calls inside of brAddTap().
      Signed-off-by: NDoug Goldstein <cardoe@gentoo.org>
      c0b0e8d0
    • E
      nodeinfo: skip offline CPUs · d413e5d7
      Eric Blake 提交于
      https://bugzilla.redhat.com/622515 - When hot-unplugging CPUs,
      libvirt failed to start a guest that had been pinned to CPUs that
      were still online.
      
      Tested on a dual-core laptop, where I also discovered that, per
      http://www.cyberciti.biz/files/linux-kernel/Documentation/cpu-hotplug.txt,
      /sys/devices/system/cpu/cpu0/online does not exist on systems where it
      cannot be hot-unplugged.
      
      * src/nodeinfo.c (linuxNodeInfoCPUPopulate): Ignore CPUs that are
      currently offline.  Detect readdir failure.
      (parse_socket): Move guts...
      (get_cpu_value): ...to new function, shared with...
      (cpu_online): New function.
      d413e5d7
  6. 10 8月, 2010 6 次提交
    • J
      qemu: Hack around asynchronous device_del · d1e5676c
      Jiri Denemark 提交于
      device_del command is not synchronous for PCI devices, it merely asks
      the guest to release the device and returns. If the host wants to use
      that device before the guest actually releases it, we are in big
      trouble. To avoid this, we already added a loop which waits up to 10
      seconds until the device is actually released before we do anything else
      with that device. But we only added this loop for managed PCI devices
      before we try reattach them back to the host.
      
      However, we need to wait even for non-managed devices. We don't reattach
      them automatically, but we still want to prevent the host from using it.
      This was revealed thanks to sVirt: when we relabel sysfs files
      corresponding to the PCI device before the guest finished releasing the
      device, qemu is no longer allowed to access those files and if it wants
      (as a result of guest's request) to write anything to them, it just
      exits, which kills the guest.
      
      This is not a proper fix and needs some further work both on libvirt and
      qemu side in the future.
      d1e5676c
    • E
      maint: update an email address preference · 1ddefd18
      Eric Blake 提交于
      * AUTHORS (Soren Hansen): Update address.
      * .mailmap: Alias other addresses to new preference.
      1ddefd18
    • D
      build-sys: only build the test programs during the check phase. · 2bd24003
      Diego Elio Pettenò 提交于
      This avoids building the tests when testing libvirt is not the aim.
      2bd24003
    • S
      Add "ubd" to the list of disk prefixes · 92e43e6d
      Soren Hansen 提交于
      virDiskNameToIndex has a list of disk name prefixes that it uses in the
      process of finding the disk's index. This list is missing "ubd" which
      is the disk prefix used for UML domains.
      Signed-off-by: NSoren Hansen <soren@linux2go.dk>
      92e43e6d
    • D
      Extend virSocketParseAddr() to allow a NULL result pointer · e9a8f3c6
      Daniel Veillard 提交于
      That way it can be used to verify a numeric address without storing
      the details
      * src/util/network.c: change virSocketParseAddr to allow a null @addr
        parameter
      e9a8f3c6
    • P
      bootloader_args is named bootargs in xen-xm · ab8b2bea
      Philipp Hahn 提交于
      According to <xen-3.4.3/tools/python/xen/xm/create.py:158>
      	gopts.var('bootargs', val='NAME',
      			  fn=set_value, default=None,
      			  use="Arguments to pass to boot loader")
      the "bootloader_args" parameter needs to be translated into "bootargs"
      when using "virsh domxml-to-native xen-xm".
      The reverse direction (domxml-from-native) is already okay.
      
      This patch fixes domxml-to-native and adds two test files to catch this
      problem.
      Signed-off-by: NPhilipp Hahn <hahn@univention.de>
      ab8b2bea
  7. 06 8月, 2010 6 次提交
  8. 05 8月, 2010 2 次提交
    • E
      build: rerun bootstrap if po/Makevars got nuked · 5f211d4b
      Eric Blake 提交于
      There has been a frequent complaint of:
      
      make[2]: Entering directory `/home/remote/eblake/libvirt/po'
      make[2]: *** No rule to make target `/config.status', needed by `Makefile'.  Stop.
      
      It happens after nuking and regenerating the po directory,
      which is a common action after running anything like
      'make dist' or 'make rpm' that dirties all the .po files.
      
      Teach autogen.sh that it must regenerate po/Makevars to avoid
      the missing variable declaration, and teach cfg.mk to recognize
      that a nuked po directory is cause to rerun autogen.sh.
      
      * cfg.mk (_update_required): Check for po/Makevars.
      * autogen.sh (bootstrap): Run bootstrap if it got lost.
      Diagnosed by Justin Clift.
      5f211d4b
    • D
      Do not use boot=on on IDE device · 634ea3fa
      Daniel Veillard 提交于
      the followup on the boot=on problem, basically it's not needed to
      specify it when booting out of IDE devices when using KVM
      * src/qemu/qemu_conf.c: do not use boot=on for IDE devices
      * tests/qemuxml2argvdata/qemuxml2argv*.args: this changes the output
        for 5 of the tests
      634ea3fa
  9. 04 8月, 2010 3 次提交
    • D
      Release of libvirt-0.8.3 · d3d33c82
      Daniel Veillard 提交于
      * configure.ac docs/news.html.in libvirt.spec.in: updates
      * po/*.po*: update and regenerated
      d3d33c82
    • J
      qemu: Fix PCI address allocation · bf0bf4e7
      Jiri Denemark 提交于
      Patch version revamped by Eric Blake <eblake@redhat.com> of Jiri
      Denemark <jdenemar@redhat.com> original patch
      
      When attaching a PCI device which doesn't explicitly set its PCI
      address, libvirt allocates the address automatically. The problem is
      that when checking which PCI address is unused, we only check for those
      with slot number higher than the highest slot number ever used.
      
      Thus attaching/detaching such device several times in a row (31 is the
      theoretical limit, less then 30 tries are enough in practise) makes any
      further device attachment fail. Furthermore, attaching a device with
      predefined PCI address to 0:0:31 immediately forbids attachment of any
      PCI device without explicit address.
      
      This patch changes the logic so that we always check all PCI addresses
      before we say there is no PCI address available.
      
      Modifications from v1: revert back to remembering the last slot
      reserved, but allow wraparound to not be limited by the end.
      In this way, slots are still assigned in the same order as
      before the patch, rather than filling in the gaps closest to
      0 and risking making windows guests mad.
      
      * src/qemu/qemu_conf.c: fix pci reservation code to do a round-robbin
        check of all available PCI splot availability before failing.
      bf0bf4e7
    • J
      OpenVZ: implement suspend/resume driver APIs · 9cbc3c8e
      Jean-Baptiste Rouault 提交于
      * src/openvz/openvz_driver.c: implements openvzDomainSuspend and
        openvzDomainResume
      9cbc3c8e
  10. 03 8月, 2010 1 次提交